Skip to content

Commit a2df32f

Browse files
committed
fix(source-control): select repository names using the mapped provider
1 parent 425650e commit a2df32f

2 files changed

Lines changed: 37 additions & 2 deletions

File tree

‎apps/server/src/pullRequest/PullRequestService.test.ts‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,6 +561,40 @@ it.effect.each(["forgejo", "azure-devops"] as const)(
561561
}),
562562
);
563563

564+
it.effect("uses the configured provider's repository selector for a mapped Azure checkout", () =>
565+
Effect.gen(function* () {
566+
const service = yield* makeService({
567+
settings: {
568+
...DEFAULT_SERVER_SETTINGS,
569+
sourceControlHostOverrides: { "code.example.test": { kind: "azure-devops" } },
570+
},
571+
projects: [
572+
project({
573+
id: "azure",
574+
title: "Azure",
575+
workspaceRoot: "/azure",
576+
repository: "org/project/_git/web",
577+
host: "code.example.test",
578+
provider: "unknown",
579+
}),
580+
],
581+
providers: [
582+
fakeProvider(SourceControlProviderKind.make("azure-devops"), {
583+
getChangeRequestSummary: (input) => {
584+
assert.strictEqual(input.repository, "web");
585+
assert.strictEqual(input.host, "code.example.test");
586+
return Effect.succeed(changeRequest(42, "2026-07-02T00:00:00Z"));
587+
},
588+
}),
589+
],
590+
});
591+
yield* service.summary(
592+
{ projectId: "azure" as ProjectId, host: "code.example.test", repository: "web", number: 42 },
593+
{ recoverTransientFailure: false },
594+
);
595+
}),
596+
);
597+
564598
function makeService(input: {
565599
readonly settings?: ServerSettings;
566600
readonly projects: ReadonlyArray<OrchestrationProjectShell>;

‎apps/server/src/pullRequest/PullRequestService.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,7 @@ export const make = Effect.gen(function* () {
737737
if (filter.projectIds !== undefined && !filter.projectIds.includes(project.id)) continue;
738738
const identity = project.repositoryIdentity;
739739
let kind = identity?.provider as SourceControlProviderKind | undefined;
740-
const repository = sourceControlRepositorySelector(project.repositoryIdentity);
741-
if (!identity || repository === null) continue;
740+
if (!identity) continue;
742741
let refinedProvider: SourceControlProviderInfo | null | undefined;
743742
const overridden =
744743
sourceControlHostOverrideForRemoteUrl(identity.locator.remoteUrl, overrides) !==
@@ -758,6 +757,8 @@ export const make = Effect.gen(function* () {
758757
kind = refinedProvider?.kind ?? kind;
759758
}
760759
if (kind === undefined) continue;
760+
const repository = sourceControlRepositorySelector({ ...identity, provider: kind });
761+
if (repository === null) continue;
761762
const host =
762763
refinedProvider && (overridden || refinedProvider.kind === "forgejo")
763764
? new URL(refinedProvider.baseUrl).host.toLowerCase()

0 commit comments

Comments
 (0)