Skip to content

Commit a166a79

Browse files
fix(web): trust saved cloud computer compatibility
1 parent ff1a13f commit a166a79

1 file changed

Lines changed: 18 additions & 14 deletions

File tree

‎apps/web/src/components/cloud/CloudEnvironmentConnectList.tsx‎

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,11 @@ export function CloudEnvironmentConnectRows({
203203
if (!isVisibleEnvironment(environment.environmentId)) continue;
204204
const id = environment.environmentId;
205205
if (availability === "checking") continue;
206+
const savedEnvironment = savedById.get(id);
206207
if (
207-
discoveredCompatibilityError(status) !== null ||
208-
savedById.get(id)?.connection.phase === "unsupported"
208+
savedEnvironment
209+
? savedEnvironment.connection.phase === "unsupported"
210+
: discoveredCompatibilityError(status) !== null
209211
) {
210212
seen.add(id);
211213
if (selection.selectedIds.has(id)) selection.onChange(id, false);
@@ -308,18 +310,20 @@ export function CloudEnvironmentConnectRows({
308310
return visibleEnvironments.map(({ environment, availability, error, status }) => {
309311
const savedEnvironment = savedById.get(environment.environmentId);
310312
const compatibilityError = discoveredCompatibilityError(status);
311-
const unsupported =
312-
compatibilityError !== null || savedEnvironment?.connection.phase === "unsupported";
313-
const unsupportedDetail =
314-
compatibilityError?.message ?? savedEnvironment?.connection.error ?? null;
315-
const savedConnection = unsupported
316-
? presentSavedCloudEnvironmentConnection({
317-
phase: "unsupported",
318-
error: unsupportedDetail,
319-
traceId: null,
320-
})
321-
: savedEnvironment
322-
? presentSavedCloudEnvironmentConnection(savedEnvironment.connection)
313+
const unsupported = savedEnvironment
314+
? savedEnvironment.connection.phase === "unsupported"
315+
: compatibilityError !== null;
316+
const unsupportedDetail = savedEnvironment
317+
? savedEnvironment.connection.error
318+
: (compatibilityError?.message ?? null);
319+
const savedConnection = savedEnvironment
320+
? presentSavedCloudEnvironmentConnection(savedEnvironment.connection)
321+
: unsupported
322+
? presentSavedCloudEnvironmentConnection({
323+
phase: "unsupported",
324+
error: unsupportedDetail,
325+
traceId: null,
326+
})
323327
: null;
324328
const relayStatus = status === undefined ? null : Option.getOrNull(status);
325329
const descriptor = relayStatus?.descriptor;

0 commit comments

Comments
 (0)