You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a0f6cd0
Browse filesBrowse the repository at this point in the historyBrowse files
`This PR changes the test suite by **${signed(delta.net)} test cases** `+
62
+
`(browser ${signed(delta.kinds.browser)}, unit ${signed(delta.kinds.unit)}, server ${signed(delta.kinds.server)}).`,
63
+
];
64
+
if(delta.newBrowserFiles.length>0){
65
+
lines.push(
66
+
"",
67
+
`New browser test files: ${delta.newBrowserFiles.map((file)=>`\`${file}\``).join(", ")}.`,
68
+
"Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.",
69
+
);
70
+
}
71
+
lines.push(
72
+
"",
73
+
"Keep tests that would fail for a real reason, and test logic below the UI where it can be. See [Testing](https://github.com/pingdotgg/t3code/blob/main/docs/internals/testing.md).",
Copy file name to clipboardExpand all lines: .macroscope/check-run-agents/ui-consistency.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -44,7 +44,7 @@ The reference for how this codebase wants UI built is the composer banner system
44
44
45
45
-`ComposerBanner.tsx` exports one object of small slot components (`Root`, `Row`, `Icon`, `Content`, `Actions`, `Dismiss`, `Children`, and so on). Each slot owns its own Tailwind classes, exposes a `data-slot` attribute, takes `className` and spreads the rest of its props, and uses `cn` so callers can adjust without overriding. Variants and density are props on `Root`, not ad hoc class strings at call sites. Where a slot needs a real control it renders `Button` from `ui/` rather than a styled `<button>`.
46
46
-`ComposerBannerStack.tsx` composes those slots into the ordered stack and owns only stack behavior (priority, expand and collapse, dismiss transitions).
47
-
- Consumers such as `ComposerPlanFollowUpBanner.tsx` are a few lines of `<ComposerBanner.Row><ComposerBanner.Icon/><ComposerBanner.Content>…` and style only their own content.
47
+
- Consumers compose the slots and style only their own content.
0 commit comments