Skip to content

Commit a036489

Browse files
authored
revert(web): undo hover timestamp change from #28610 (#29680)
Co-authored-by: maria-rcks <[email protected]>
1 parent 55e2538 commit a036489

4 files changed

Lines changed: 3 additions & 72 deletions

File tree

‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1528,60 +1528,6 @@ describe("deriveMessagesTimelineRows", () => {
15281528
expect(rows.at(-1)).toMatchObject({ kind: "thinking" });
15291529
});
15301530

1531-
it("keeps the latest finished reply's timestamp while a command is still running", () => {
1532-
const reply = (streaming: boolean) => ({
1533-
id: "assistant-reply-entry",
1534-
kind: "message" as const,
1535-
createdAt: "2026-01-01T00:00:10Z",
1536-
message: {
1537-
id: "assistant-reply" as never,
1538-
role: "assistant" as const,
1539-
text: "Training finished, checking memory next.",
1540-
runId: "turn-1" as never,
1541-
createdAt: "2026-01-01T00:00:10Z",
1542-
updatedAt: "2026-01-01T00:00:12Z",
1543-
streaming,
1544-
},
1545-
});
1546-
const rowsWith = (streaming: boolean) =>
1547-
deriveMessagesTimelineRows({
1548-
timelineEntries: [
1549-
reply(streaming),
1550-
{
1551-
id: "command-entry",
1552-
kind: "work",
1553-
createdAt: "2026-01-01T00:00:15Z",
1554-
entry: {
1555-
id: "command",
1556-
createdAt: "2026-01-01T00:00:15Z",
1557-
runId: "turn-1" as never,
1558-
label: "Running command",
1559-
command: "nvidia-smi",
1560-
tone: "tool" as const,
1561-
toolLifecycleStatus: "inProgress" as const,
1562-
},
1563-
},
1564-
],
1565-
latestRun: {
1566-
runId: "turn-1" as never,
1567-
status: "running",
1568-
startedAt: "2026-01-01T00:00:00Z",
1569-
completedAt: null,
1570-
},
1571-
isWorking: true,
1572-
activeTurnStartedAt: "2026-01-01T00:00:00Z",
1573-
turnDiffSummaries: [],
1574-
supportsConversationRollback: false,
1575-
}).find((row) => row.id === "assistant-reply-entry");
1576-
1577-
expect(rowsWith(false)).toMatchObject({
1578-
showAssistantMeta: false,
1579-
showAssistantTimestamp: true,
1580-
showAssistantCopyButton: false,
1581-
});
1582-
expect(rowsWith(true)).toMatchObject({ showAssistantTimestamp: false });
1583-
});
1584-
15851531
it("does not show Thinking once the open run's provider turn has ended", () => {
15861532
const input = {
15871533
timelineEntries: [

‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -591,8 +591,6 @@ type MessagesTimelineRowContent =
591591
message: ChatMessage;
592592
projectedItem?: OrchestrationV2ProjectedTurnItem;
593593
showAssistantMeta: boolean;
594-
/** The latest finished reply of a still-running response shows only its timestamp. */
595-
showAssistantTimestamp: boolean;
596594
showAssistantCopyButton: boolean;
597595
assistantCopyStreaming: boolean;
598596
assistantTurnDiffSummary?: TurnDiffSummary | undefined;
@@ -2029,10 +2027,10 @@ export function deriveMessagesTimelineRows(input: {
20292027
timelineEntry.message.role === "assistant" &&
20302028
runIdIsActiveResponse(timelineEntry.message.runId);
20312029

2032-
const isTerminalAssistantMessage =
2030+
const showAssistantMeta =
20332031
timelineEntry.message.role === "assistant" &&
2034-
terminalAssistantMessageIds.has(timelineEntry.message.id);
2035-
const showAssistantMeta = isTerminalAssistantMessage && !assistantResponseStillInProgress;
2032+
terminalAssistantMessageIds.has(timelineEntry.message.id) &&
2033+
!assistantResponseStillInProgress;
20362034

20372035
nextRows.push({
20382036
kind: "message",
@@ -2043,10 +2041,6 @@ export function deriveMessagesTimelineRows(input: {
20432041
? {}
20442042
: { projectedItem: timelineEntry.projectedItem }),
20452043
showAssistantMeta,
2046-
showAssistantTimestamp:
2047-
isTerminalAssistantMessage &&
2048-
assistantResponseStillInProgress &&
2049-
!timelineEntry.message.streaming,
20502044
showAssistantCopyButton: showAssistantMeta,
20512045
assistantCopyStreaming: timelineEntry.message.streaming || assistantResponseStillInProgress,
20522046
assistantTurnDiffSummary:
@@ -2510,7 +2504,6 @@ function isRowUnchanged(a: MessagesTimelineRow, b: MessagesTimelineRow): boolean
25102504
a.message === bm.message &&
25112505
a.projectedItem === bm.projectedItem &&
25122506
a.showAssistantMeta === bm.showAssistantMeta &&
2513-
a.showAssistantTimestamp === bm.showAssistantTimestamp &&
25142507
a.showAssistantCopyButton === bm.showAssistantCopyButton &&
25152508
a.assistantCopyStreaming === bm.assistantCopyStreaming &&
25162509
a.assistantTurnDiffSummary === bm.assistantTurnDiffSummary &&

‎apps/web/src/components/chat/TimelineAssistantRows.tsx‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,6 @@ export function AssistantTimelineRow({ row }: { row: Extract<TimelineRow, { kind
7676
showCopyButton={row.showAssistantCopyButton}
7777
copyStreaming={row.assistantCopyStreaming}
7878
/>
79-
) : row.showAssistantTimestamp ? (
80-
<AssistantMessageMeta
81-
className="mt-1.5"
82-
message={row.message}
83-
showCopyButton={false}
84-
copyStreaming={row.assistantCopyStreaming}
85-
/>
8679
) : null}
8780
</div>
8881
</>

‎apps/web/src/components/chat/timelineMinimapItems.test.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ describe("deriveTimelineMinimapItems", () => {
1515
id: "image-only",
1616
createdAt: at,
1717
showAssistantMeta: false,
18-
showAssistantTimestamp: false,
1918
showAssistantCopyButton: false,
2019
assistantCopyStreaming: false,
2120
message: {

0 commit comments

Comments
 (0)