Skip to content

Commit a0229de

Browse files
committed
test(opencode): require session and prompt cancellation on timeout
1 parent 7bdb51e commit a0229de

1 file changed

Lines changed: 32 additions & 2 deletions

File tree

‎apps/server/src/textGeneration/OpenCodeTextGeneration.test.ts‎

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ const runtimeMock = {
2424
authHeaders: [] as Array<string | null>,
2525
closeCalls: [] as string[],
2626
sessionCreateCalls: 0,
27+
sessionCreateSignals: [] as Array<AbortSignal | undefined>,
28+
promptSignals: [] as Array<AbortSignal | undefined>,
2729
connectionError: undefined as Error | undefined,
2830
sessionCreateError: undefined as unknown,
2931
sessionResult: undefined as { data?: { id: string } } | undefined,
@@ -39,6 +41,8 @@ const runtimeMock = {
3941
this.state.authHeaders.length = 0;
4042
this.state.closeCalls.length = 0;
4143
this.state.sessionCreateCalls = 0;
44+
this.state.sessionCreateSignals.length = 0;
45+
this.state.promptSignals.length = 0;
4246
this.state.connectionError = undefined;
4347
this.state.sessionCreateError = undefined;
4448
this.state.sessionResult = undefined;
@@ -95,14 +99,19 @@ const OpenCodeRuntimeTestDouble: OpenCodeRuntime.OpenCodeRuntimeShape = {
9599
createOpenCodeSdkClient: ({ baseUrl, serverPassword }) =>
96100
({
97101
session: {
98-
create: async () => {
102+
create: async (_input: unknown, options?: { readonly signal?: AbortSignal }) => {
99103
runtimeMock.state.sessionCreateCalls += 1;
104+
runtimeMock.state.sessionCreateSignals.push(options?.signal);
100105
if (runtimeMock.state.sessionCreateError !== undefined) {
101106
throw runtimeMock.state.sessionCreateError;
102107
}
103108
return runtimeMock.state.sessionResult ?? { data: { id: `${baseUrl}/session` } };
104109
},
105-
prompt: async (input: { readonly parts: ReadonlyArray<unknown> }) => {
110+
prompt: async (
111+
input: { readonly parts: ReadonlyArray<unknown> },
112+
options?: { readonly signal?: AbortSignal },
113+
) => {
114+
runtimeMock.state.promptSignals.push(options?.signal);
106115
runtimeMock.state.promptUrls.push(baseUrl);
107116
runtimeMock.state.promptParts.push(input.parts);
108117
runtimeMock.state.authHeaders.push(
@@ -635,6 +644,27 @@ it.layer(OpenCodeTextGenerationExistingServerTestLayer)(
635644
expect(error).toBeInstanceOf(TextGenerationError);
636645
expect(error.operation).toBe("generateCommitMessage");
637646
expect(error.detail).toContain("timed out");
647+
expect(runtimeMock.state.promptSignals.at(-1)?.aborted).toBe(true);
648+
}),
649+
).pipe(Effect.provide(TestClock.layer())),
650+
);
651+
it.effect("aborts a stalled OpenCode session creation after the timeout", () =>
652+
withOpenCodeTextGeneration(DEFAULT_OPENCODE_SETTINGS, (textGeneration) =>
653+
Effect.gen(function* () {
654+
runtimeMock.state.sessionResult = new Promise(() => {}) as unknown as NonNullable<
655+
typeof runtimeMock.state.sessionResult
656+
>;
657+
const child = yield* textGeneration
658+
.generateCommitMessage(DEFAULT_COMMIT_MESSAGE_INPUT)
659+
.pipe(Effect.forkChild);
660+
while (runtimeMock.state.sessionCreateCalls === 0) {
661+
yield* Effect.yieldNow;
662+
}
663+
yield* TestClock.adjust(181_000);
664+
const error = yield* Fiber.join(child).pipe(Effect.flip);
665+
expect(error).toBeInstanceOf(TextGenerationError);
666+
expect(error.detail).toContain("timed out");
667+
expect(runtimeMock.state.sessionCreateSignals.at(-1)?.aborted).toBe(true);
638668
}),
639669
).pipe(Effect.provide(TestClock.layer())),
640670
);

0 commit comments

Comments
 (0)