Repository navigation
Commit 9f45f72
committed
perf(mobile): recycle the default v2 home list and scope the snooze minute tick
The default Home screen rendered the v2 thread list with a bare RN
FlatList: no recycling, no item equality, and the 60s snooze-minute
clock rode in the list's extraData, so every visible row (each one a
ReanimatedSwipeable + PR subscription) re-rendered on every tick and on
every unrelated shell update. The legacy v1 list and the iPad sidebar
already use LegendList with recycleItems + itemsAreEqual for the same
rows; Home's default path was the outlier.
Swap the v2 Home list onto the same LegendList configuration and move
the clock out of extraData and onto the items: each v2-thread item now
carries its precomputed row time, the snooze-menu minute (only for rows
whose menu actually offers snooze presets), and its trailing-divider
flag, so the recycler's equality invalidates only rows whose visible
text or menu moved. The shared equality and the sidebar's wrapper now
match, and the sidebar drops its own minute-tick extraData bust too.
Thread rows also get reference-stable provider-instance objects, which
previously broke the memoized rows' props comparison on every render.1 parent d7819c1 commit 9f45f72
7 files changed
Lines changed: 718 additions & 86 deletions
File tree
- apps/mobile/src/features
- home
- threads
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| |||
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
141 | 146 | | |
142 | 147 | | |
143 | 148 | | |
| |||
655 | 660 | | |
656 | 661 | | |
657 | 662 | | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
658 | 666 | | |
659 | 667 | | |
660 | 668 | | |
| |||
783 | 791 | | |
784 | 792 | | |
785 | 793 | | |
| 794 | + | |
786 | 795 | | |
787 | | - | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
788 | 804 | | |
789 | 805 | | |
790 | 806 | | |
| |||
793 | 809 | | |
794 | 810 | | |
795 | 811 | | |
796 | | - | |
797 | | - | |
798 | | - | |
799 | | - | |
800 | | - | |
| 812 | + | |
801 | 813 | | |
802 | 814 | | |
803 | 815 | | |
| |||
816 | 828 | | |
817 | 829 | | |
818 | 830 | | |
819 | | - | |
| 831 | + | |
820 | 832 | | |
821 | 833 | | |
822 | 834 | | |
| |||
853 | 865 | | |
854 | 866 | | |
855 | 867 | | |
856 | | - | |
| 868 | + | |
857 | 869 | | |
858 | | - | |
| 870 | + | |
| 871 | + | |
859 | 872 | | |
860 | 873 | | |
861 | 874 | | |
862 | 875 | | |
863 | 876 | | |
864 | 877 | | |
865 | | - | |
| 878 | + | |
866 | 879 | | |
867 | 880 | | |
868 | 881 | | |
| |||
931 | 944 | | |
932 | 945 | | |
933 | 946 | | |
934 | | - | |
| 947 | + | |
935 | 948 | | |
936 | 949 | | |
937 | 950 | | |
938 | | - | |
939 | 951 | | |
940 | 952 | | |
941 | 953 | | |
942 | 954 | | |
943 | 955 | | |
944 | 956 | | |
945 | | - | |
946 | 957 | | |
947 | 958 | | |
948 | 959 | | |
949 | 960 | | |
950 | | - | |
951 | | - | |
952 | | - | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
953 | 965 | | |
954 | 966 | | |
955 | 967 | | |
956 | 968 | | |
957 | 969 | | |
958 | 970 | | |
959 | 971 | | |
960 | | - | |
961 | 972 | | |
962 | 973 | | |
963 | 974 | | |
964 | 975 | | |
965 | 976 | | |
966 | 977 | | |
967 | 978 | | |
968 | | - | |
969 | 979 | | |
970 | 980 | | |
971 | 981 | | |
| |||
1225 | 1235 | | |
1226 | 1236 | | |
1227 | 1237 | | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
1228 | 1241 | | |
1229 | | - | |
| 1242 | + | |
1230 | 1243 | | |
1231 | 1244 | | |
1232 | 1245 | | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
1233 | 1251 | | |
1234 | 1252 | | |
1235 | 1253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| |||
483 | 485 | | |
484 | 486 | | |
485 | 487 | | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
486 | 491 | | |
487 | 492 | | |
488 | 493 | | |
| |||
607 | 612 | | |
608 | 613 | | |
609 | 614 | | |
| 615 | + | |
610 | 616 | | |
611 | 617 | | |
612 | 618 | | |
| |||
625 | 631 | | |
626 | 632 | | |
627 | 633 | | |
| 634 | + | |
628 | 635 | | |
629 | 636 | | |
630 | 637 | | |
| |||
789 | 796 | | |
790 | 797 | | |
791 | 798 | | |
792 | | - | |
793 | | - | |
794 | | - | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
795 | 804 | | |
796 | 805 | | |
797 | 806 | | |
798 | 807 | | |
799 | 808 | | |
800 | 809 | | |
801 | 810 | | |
802 | | - | |
803 | 811 | | |
804 | 812 | | |
805 | 813 | | |
| |||
808 | 816 | | |
809 | 817 | | |
810 | 818 | | |
811 | | - | |
812 | 819 | | |
813 | 820 | | |
814 | 821 | | |
815 | 822 | | |
816 | 823 | | |
817 | 824 | | |
818 | | - | |
819 | | - | |
820 | | - | |
821 | | - | |
822 | | - | |
823 | | - | |
824 | | - | |
825 | | - | |
826 | | - | |
| 825 | + | |
| 826 | + | |
827 | 827 | | |
828 | 828 | | |
829 | 829 | | |
830 | 830 | | |
831 | | - | |
832 | | - | |
833 | | - | |
834 | | - | |
835 | | - | |
836 | | - | |
837 | | - | |
838 | | - | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | 831 | | |
844 | | - | |
| 832 | + | |
845 | 833 | | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
| 834 | + | |
| 835 | + | |
854 | 836 | | |
855 | 837 | | |
856 | 838 | | |
| |||
917 | 899 | | |
918 | 900 | | |
919 | 901 | | |
920 | | - | |
| 902 | + | |
921 | 903 | | |
| 904 | + | |
922 | 905 | | |
923 | 906 | | |
924 | | - | |
| 907 | + | |
925 | 908 | | |
926 | 909 | | |
927 | 910 | | |
| |||
1104 | 1087 | | |
1105 | 1088 | | |
1106 | 1089 | | |
1107 | | - | |
1108 | 1090 | | |
1109 | 1091 | | |
1110 | 1092 | | |
| |||
1114 | 1096 | | |
1115 | 1097 | | |
1116 | 1098 | | |
1117 | | - | |
| 1099 | + | |
1118 | 1100 | | |
1119 | 1101 | | |
1120 | 1102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | | - | |
37 | 35 | | |
38 | 36 | | |
39 | 37 | | |
| |||
69 | 67 | | |
70 | 68 | | |
71 | 69 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | 70 | | |
77 | 71 | | |
78 | 72 | | |
| |||
453 | 447 | | |
454 | 448 | | |
455 | 449 | | |
456 | | - | |
457 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
458 | 459 | | |
459 | 460 | | |
460 | 461 | | |
| |||
549 | 550 | | |
550 | 551 | | |
551 | 552 | | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
559 | 556 | | |
560 | 557 | | |
561 | 558 | | |
| |||
0 commit comments