Skip to content

Commit 9d71b19

Browse files
fix(pull-requests): route self-hosted GitLab remotes
1 parent a7b0366 commit 9d71b19

5 files changed

Lines changed: 144 additions & 7 deletions

File tree

‎apps/server/src/pullRequest/PullRequestService.test.ts‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import type {
1010
} from "@t3tools/contracts";
1111

1212
import * as ProjectionSnapshotQuery from "../orchestration/Services/ProjectionSnapshotQuery.ts";
13+
import * as SourceControlProviderRegistry from "../sourceControl/SourceControlProviderRegistry.ts";
1314
import {
1415
PullRequestProviderError,
1516
type ProviderChangeRequest,
@@ -144,11 +145,16 @@ function fakeProvider(
144145
function makeService(input: {
145146
readonly projects: ReadonlyArray<OrchestrationProjectShell>;
146147
readonly providers: ReadonlyArray<PullRequestProviderApi>;
148+
readonly resolveHandle?: SourceControlProviderRegistry.SourceControlProviderRegistry["Service"]["resolveHandle"];
147149
}) {
148150
return PullRequestService.make.pipe(
149151
Effect.provide(
150152
Layer.mergeAll(
151153
Layer.succeed(PullRequestProviderRegistry, fromProviders(input.providers)),
154+
Layer.mock(SourceControlProviderRegistry.SourceControlProviderRegistry)({
155+
resolveHandle:
156+
input.resolveHandle ?? (() => Effect.die("Unexpected provider refinement")),
157+
}),
152158
Layer.mock(ProjectionSnapshotQuery.ProjectionSnapshotQuery)({
153159
getShellSnapshot: () =>
154160
Effect.succeed({
@@ -163,6 +169,41 @@ function makeService(input: {
163169
);
164170
}
165171

172+
it.effect("refines unknown self-hosted GitLab projects before listing merge requests", () =>
173+
Effect.gen(function* () {
174+
let refinementCalls = 0;
175+
const selfHosted = project({
176+
id: "p1",
177+
title: "self-hosted",
178+
workspaceRoot: "/gitlab",
179+
repository: "group/project",
180+
provider: "unknown",
181+
host: "code.example.test",
182+
});
183+
const service = yield* makeService({
184+
projects: [
185+
selfHosted,
186+
{ ...selfHosted, id: "p2" as ProjectId, workspaceRoot: "/gitlab-worktree" },
187+
],
188+
providers: [fakeProvider("gitlab")],
189+
resolveHandle: ({ context }) => {
190+
refinementCalls += 1;
191+
assert.strictEqual(context?.remoteUrl, "https://code.example.test/group/project.git");
192+
return Effect.succeed({
193+
context: { ...context!, provider: { ...context!.provider, kind: "gitlab" } },
194+
provider: undefined as never,
195+
});
196+
},
197+
});
198+
199+
const result = yield* service.list({ state: "open" });
200+
201+
assert.strictEqual(refinementCalls, 1);
202+
assert.strictEqual(result.providers[0]?.host, "code.example.test");
203+
assert.strictEqual(result.providers[0]?.kind, "gitlab");
204+
}),
205+
);
206+
166207
/** A row as a host that reads several repositories at once hands it over. */
167208
function batchedChangeRequest(number: number, repository: string, updatedAt: string) {
168209
return { ...changeRequest(number, updatedAt), repository };

‎apps/server/src/pullRequest/PullRequestService.ts‎

Lines changed: 60 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,13 @@ import {
3636
type PullRequestSubmitReviewInput,
3737
type PullRequestThreadReplyInput,
3838
type PullRequestThreadResolutionInput,
39+
type SourceControlProviderInfo,
3940
type SourceControlProviderKind,
4041
} from "@t3tools/contracts";
42+
import { detectSourceControlProviderFromRemoteUrl } from "@t3tools/shared/sourceControl";
4143

4244
import * as ProjectionSnapshotQuery from "../orchestration/Services/ProjectionSnapshotQuery.ts";
45+
import * as SourceControlProviderRegistry from "../sourceControl/SourceControlProviderRegistry.ts";
4346
import {
4447
type ProviderChangeRequest,
4548
type ProviderListCursor,
@@ -360,6 +363,49 @@ function repositoryIdentityOf(project: OrchestrationProjectShell): string | null
360363
export const make = Effect.gen(function* () {
361364
const registry = yield* PullRequestProviderRegistry;
362365
const projections = yield* ProjectionSnapshotQuery.ProjectionSnapshotQuery;
366+
const sourceControlProviders = yield* SourceControlProviderRegistry.SourceControlProviderRegistry;
367+
368+
const refineUnknownProjectKinds = (
369+
projects: ReadonlyArray<OrchestrationProjectShell>,
370+
filter: Pick<PullRequestListInput, "projectId" | "host">,
371+
) => {
372+
const refinements = new Map<
373+
string,
374+
{
375+
project: OrchestrationProjectShell;
376+
provider: SourceControlProviderInfo;
377+
remoteName: string;
378+
remoteUrl: string;
379+
}
380+
>();
381+
for (const project of projects) {
382+
if (filter.projectId !== undefined && project.id !== filter.projectId) continue;
383+
const identity = project.repositoryIdentity;
384+
if (identity?.provider !== "unknown" || repositoryIdentityOf(project) === null) continue;
385+
const host = pullRequestHostOf(identity, "unknown");
386+
if (filter.host !== undefined && host !== filter.host.toLowerCase()) continue;
387+
const { remoteName, remoteUrl } = identity.locator;
388+
const provider = detectSourceControlProviderFromRemoteUrl(remoteUrl);
389+
if (provider !== null && !refinements.has(provider.baseUrl)) {
390+
refinements.set(provider.baseUrl, { project, provider, remoteName, remoteUrl });
391+
}
392+
}
393+
394+
return Effect.forEach(
395+
refinements,
396+
([baseUrl, { project, provider, remoteName, remoteUrl }]) =>
397+
sourceControlProviders
398+
.resolveHandle({
399+
cwd: project.workspaceRoot,
400+
context: { provider, remoteName, remoteUrl },
401+
})
402+
.pipe(
403+
Effect.map((handle) => [baseUrl, handle.context?.provider.kind ?? "unknown"] as const),
404+
Effect.orElseSucceed(() => [baseUrl, "unknown"] as const),
405+
),
406+
{ concurrency: REPOSITORY_CONCURRENCY },
407+
).pipe(Effect.map((resolved) => new Map(resolved)));
408+
};
363409

364410
const listWorkspaceProjects = (
365411
filter: Pick<PullRequestListInput, "projectId" | "host">,
@@ -373,7 +419,12 @@ export const make = Effect.gen(function* () {
373419
cause: error,
374420
}),
375421
),
376-
Effect.map((snapshot) => {
422+
Effect.flatMap((snapshot) =>
423+
refineUnknownProjectKinds(snapshot.projects, filter).pipe(
424+
Effect.map((refinedKinds) => ({ refinedKinds, snapshot })),
425+
),
426+
),
427+
Effect.map(({ refinedKinds, snapshot }) => {
377428
const supported: SupportedProject[] = [];
378429
const unimplemented = new Map<
379430
string,
@@ -383,16 +434,19 @@ export const make = Effect.gen(function* () {
383434
const seen = new Set<string>();
384435
for (const project of snapshot.projects) {
385436
if (filter.projectId !== undefined && project.id !== filter.projectId) continue;
386-
const kind = project.repositoryIdentity?.provider as
387-
| SourceControlProviderKind
388-
| undefined;
437+
const identity = project.repositoryIdentity;
438+
let kind = identity?.provider as SourceControlProviderKind | undefined;
389439
const repository = repositoryIdentityOf(project);
390-
if (kind === undefined || repository === null) continue;
440+
if (!identity || kind === undefined || repository === null) continue;
391441
// Worktrees of one repository are separate projects; reading the remote once keeps
392442
// the page from repeating every change request per local checkout. The host is part
393443
// of the key, so the same `owner/repo` on two hosts stays two repositories.
394-
const host = pullRequestHostOf(project.repositoryIdentity, kind);
444+
const host = pullRequestHostOf(identity, kind);
395445
if (filter.host !== undefined && host !== filter.host.toLowerCase()) continue;
446+
if (kind === "unknown") {
447+
const provider = detectSourceControlProviderFromRemoteUrl(identity.locator.remoteUrl);
448+
kind = provider === null ? kind : (refinedKinds.get(provider.baseUrl) ?? kind);
449+
}
396450
const api = registry.get(kind);
397451
// Recorded before the de-duplication below, so the viewer lookup keeps the alternates
398452
// the listing is about to drop.

‎apps/server/src/server.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,7 @@ const commandReadinessLayer = HttpRouter.middleware(
435435
const PullRequestServiceLive = PullRequestService.layer.pipe(
436436
// One registry entry per supported host; the service only knows the registry.
437437
Layer.provide(PullRequestProviderRegistry.layer),
438+
Layer.provide(SourceControlProviderRegistryLayerLive),
438439
Layer.provide(VcsProcess.layer),
439440
);
440441

‎apps/server/src/sourceControl/SourceControlProviderRegistry.test.ts‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,38 @@ self-hosted.example.test
203203
}),
204204
);
205205

206+
it.effect("refines the caller-selected remote instead of choosing another configured remote", () =>
207+
Effect.gen(function* () {
208+
const registry = yield* makeRegistry({
209+
remotes: [{ name: "origin", url: "[email protected]:fork/project.git" }],
210+
process: {
211+
run: () =>
212+
Effect.succeed(
213+
processOutput(`self-hosted.example.test
214+
✓ Logged in to self-hosted.example.test as gitlab-user
215+
`),
216+
),
217+
},
218+
});
219+
220+
const handle = yield* registry.resolveHandle({
221+
cwd: "/repo",
222+
context: {
223+
provider: {
224+
kind: "unknown",
225+
name: "self-hosted.example.test",
226+
baseUrl: "https://self-hosted.example.test",
227+
},
228+
remoteName: "upstream",
229+
remoteUrl: "https://self-hosted.example.test/group/project.git",
230+
},
231+
});
232+
233+
assert.strictEqual(handle.context?.provider.kind, "gitlab");
234+
assert.strictEqual(handle.context?.remoteName, "upstream");
235+
}),
236+
);
237+
206238
it.effect("routes authenticated self-hosted GitLab remotes on non-standard ports", () =>
207239
Effect.gen(function* () {
208240
const registry = yield* makeRegistry({

‎apps/server/src/sourceControl/SourceControlProviderRegistry.ts‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export class SourceControlProviderRegistry extends Context.Service<
5050
>;
5151
readonly resolveHandle: (input: {
5252
readonly cwd: string;
53+
readonly context?: SourceControlProvider.SourceControlProviderContext;
5354
}) => Effect.Effect<SourceControlProviderHandle, SourceControlProviderError>;
5455
readonly resolve: (input: {
5556
readonly cwd: string;
@@ -254,7 +255,15 @@ export const makeWithProviders = Effect.fn("makeSourceControlProviderRegistryWit
254255
});
255256

256257
const resolveHandle: SourceControlProviderRegistry["Service"]["resolveHandle"] = (input) =>
257-
Cache.get(providerContextCache, input.cwd).pipe(
258+
(input.context === undefined
259+
? Cache.get(providerContextCache, input.cwd)
260+
: refineUnknownRemoteProvider({
261+
specs: discoverySpecs,
262+
process,
263+
cwd: input.cwd,
264+
context: input.context,
265+
})
266+
).pipe(
258267
Effect.map((context) => {
259268
const kind = context?.provider.kind ?? "unknown";
260269
const provider = providers.get(kind) ?? unsupportedProvider(kind);

0 commit comments

Comments
 (0)