@@ -14,16 +14,17 @@ const makeTarget = (
1414 setDownloadDirectory,
1515} ) ;
1616
17+ const makeRelay = ( target : CdpRelayTarget , write : ( raw : string ) => void ) =>
18+ createCdpRelayConnection ( target , write , ( ) => { } ) ;
19+
1720// Each relay reply resolves after a few microtasks; one macrotask lets them all land.
1821// oxlint-disable-next-line t3code/no-real-time-wait-in-tests -- a zero-delay macrotask boundary, not a wait for time
1922const settle = ( ) => new Promise < void > ( ( resolve ) => setImmediate ( resolve ) ) ;
2023
2124describe ( "CDP relay" , ( ) => {
2225 it ( "announces only the tab's page, under its real target id" , async ( ) => {
2326 const written : Array < Record < string , unknown > > = [ ] ;
24- const relay = createCdpRelayConnection ( makeTarget ( vi . fn ( ) ) , ( raw ) =>
25- written . push ( JSON . parse ( raw ) ) ,
26- ) ;
27+ const relay = makeRelay ( makeTarget ( vi . fn ( ) ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
2728 relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
2829 relay . receive ( JSON . stringify ( { id : 2 , method : "Target.createTarget" , params : { } } ) ) ;
2930 await settle ( ) ;
@@ -51,9 +52,7 @@ describe("CDP relay", () => {
5152 new Promise < unknown > ( ( resolve ) => pending . push ( ( ) => resolve ( { method } ) ) ) ,
5253 ) ;
5354 const written : Array < Record < string , unknown > > = [ ] ;
54- const relay = createCdpRelayConnection ( makeTarget ( send ) , ( raw ) =>
55- written . push ( JSON . parse ( raw ) ) ,
56- ) ;
55+ const relay = makeRelay ( makeTarget ( send ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
5756 relay . receive (
5857 JSON . stringify ( { id : 5 , method : "Page.captureScreenshot" , sessionId : "t3-preview-page" } ) ,
5958 ) ;
@@ -76,7 +75,7 @@ describe("CDP relay", () => {
7675
7776 it ( "resumes paused child frames, so cross-site iframes run" , async ( ) => {
7877 const send = vi . fn ( async ( ) => ( { } ) ) ;
79- const relay = createCdpRelayConnection ( makeTarget ( send ) , ( ) => { } ) ;
78+ const relay = makeRelay ( makeTarget ( send ) , ( ) => { } ) ;
8079 relay . receive (
8180 JSON . stringify ( {
8281 id : 1 ,
@@ -102,9 +101,7 @@ describe("CDP relay", () => {
102101 it ( "acknowledges Playwright's focus emulation without forcing it onto the guest" , async ( ) => {
103102 const send = vi . fn ( async ( ) => ( { } ) ) ;
104103 const written : Array < Record < string , unknown > > = [ ] ;
105- const relay = createCdpRelayConnection ( makeTarget ( send ) , ( raw ) =>
106- written . push ( JSON . parse ( raw ) ) ,
107- ) ;
104+ const relay = makeRelay ( makeTarget ( send ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
108105 relay . receive (
109106 JSON . stringify ( {
110107 id : 1 ,
@@ -120,9 +117,7 @@ describe("CDP relay", () => {
120117
121118 it ( "routes tab events to the page session once the page is announced" , async ( ) => {
122119 const written : Array < Record < string , unknown > > = [ ] ;
123- const relay = createCdpRelayConnection ( makeTarget ( vi . fn ( ) ) , ( raw ) =>
124- written . push ( JSON . parse ( raw ) ) ,
125- ) ;
120+ const relay = makeRelay ( makeTarget ( vi . fn ( ) ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
126121 relay . event ( "Page.loadEventFired" , { } , undefined ) ;
127122 expect ( written ) . toEqual ( [ ] ) ;
128123 relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
@@ -140,9 +135,7 @@ describe("CDP relay extra sessions", () => {
140135 it ( "gives a second page session the page's commands and events" , async ( ) => {
141136 const send = vi . fn ( async ( ) => ( { } ) ) ;
142137 const written : Array < Record < string , unknown > > = [ ] ;
143- const relay = createCdpRelayConnection ( makeTarget ( send ) , ( raw ) =>
144- written . push ( JSON . parse ( raw ) ) ,
145- ) ;
138+ const relay = makeRelay ( makeTarget ( send ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
146139 relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
147140 relay . receive ( JSON . stringify ( { id : 2 , method : "Target.attachToBrowserTarget" } ) ) ;
148141 await settle ( ) ;
@@ -182,7 +175,7 @@ describe("CDP relay downloads", () => {
182175 const send = vi . fn ( async ( ) => ( { } ) ) ;
183176 const directories : Array < string | null > = [ ] ;
184177 const written : Array < Record < string , unknown > > = [ ] ;
185- const relay = createCdpRelayConnection (
178+ const relay = makeRelay (
186179 makeTarget ( send , ( directory ) => directories . push ( directory ) ) ,
187180 ( raw ) => written . push ( JSON . parse ( raw ) ) ,
188181 ) ;
@@ -213,3 +206,58 @@ describe("CDP relay downloads", () => {
213206 ] ) ;
214207 } ) ;
215208} ) ;
209+
210+ describe ( "CDP relay payload budget" , ( ) => {
211+ // 2,048 references to one 40 KiB string: about 80 MiB once serialized, little memory here.
212+ const oversized = Array ( 2048 ) . fill ( "x" . repeat ( 40 * 1024 ) ) ;
213+
214+ it ( "fails only an oversized reply and still returns a large screenshot" , async ( ) => {
215+ const screenshot = "A" . repeat ( 16 * 1024 * 1024 ) ;
216+ const send = vi . fn ( async ( method : string ) =>
217+ method === "DOM.getDocument" ? { nodes : oversized } : { data : screenshot } ,
218+ ) ;
219+ const written : Array < Record < string , unknown > > = [ ] ;
220+ const relay = makeRelay ( makeTarget ( send ) , ( raw ) => written . push ( JSON . parse ( raw ) ) ) ;
221+ relay . receive (
222+ JSON . stringify ( { id : 1 , method : "DOM.getDocument" , sessionId : "t3-preview-page" } ) ,
223+ ) ;
224+ relay . receive (
225+ JSON . stringify ( { id : 2 , method : "Page.captureScreenshot" , sessionId : "t3-preview-page" } ) ,
226+ ) ;
227+ await settle ( ) ;
228+
229+ const replies = written . map ( ( { id, error, result } ) => ( {
230+ id,
231+ error,
232+ size : ( result as { data ?: string } | undefined ) ?. data ?. length ,
233+ } ) ) ;
234+ expect ( replies ) . toEqual ( [
235+ { id : 1 , error : { code : - 32000 , message : "CDP payload too large" } , size : undefined } ,
236+ { id : 2 , error : undefined , size : screenshot . length } ,
237+ ] ) ;
238+ } ) ;
239+
240+ it . each ( [
241+ { args : oversized } ,
242+ { args : "\u0001" . repeat ( 12 * 1024 * 1024 ) } ,
243+ { args : Array ( 2_700_000 ) . fill ( - 0.0000010000000000000002 ) } ,
244+ ] ) ( "closes instead of dropping an oversized event (%#)" , async ( { args } ) => {
245+ const written : Array < Record < string , unknown > > = [ ] ;
246+ const close = vi . fn ( ) ;
247+ const relay = createCdpRelayConnection (
248+ makeTarget ( vi . fn ( ) ) ,
249+ ( raw ) => written . push ( JSON . parse ( raw ) ) ,
250+ close ,
251+ ) ;
252+ relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
253+ await settle ( ) ;
254+ written . length = 0 ;
255+
256+ relay . event ( "Runtime.consoleAPICalled" , { args } , "" ) ;
257+ relay . event ( "Page.loadEventFired" , { timestamp : 1 } , "" ) ;
258+
259+ relay . receive ( JSON . stringify ( { id : 2 , method : "Target.setAutoAttach" } ) ) ;
260+ expect ( close ) . toHaveBeenCalledOnce ( ) ;
261+ expect ( written . map ( ( message ) => message [ "method" ] ) ) . toEqual ( [ ] ) ;
262+ } ) ;
263+ } ) ;
0 commit comments