@@ -4,6 +4,7 @@ import { expect, it } from "@effect/vitest";
44import * as Duration from "effect/Duration" ;
55import * as Effect from "effect/Effect" ;
66import * as Layer from "effect/Layer" ;
7+ import * as Option from "effect/Option" ;
78import * as TestClock from "effect/testing/TestClock" ;
89import * as SqlClient from "effect/unstable/sql/SqlClient" ;
910
@@ -50,6 +51,7 @@ const repositoryFailure = new PersistenceSqlError({
5051
5152const failingSessionLookupRepositoryLayer = Layer . succeed ( AuthSessions . AuthSessionRepository , {
5253 create : ( ) => Effect . void ,
54+ createReplacingActive : ( ) => Effect . succeed ( [ ] ) ,
5355 getById : ( ) => Effect . fail ( repositoryFailure ) ,
5456 listActive : ( ) => Effect . succeed ( [ ] ) ,
5557 revoke : ( ) => Effect . fail ( repositoryFailure ) ,
@@ -181,6 +183,78 @@ it.layer(NodeServices.layer)("SessionStore.layer", (it) => {
181183 } ) . pipe ( Effect . provide ( Layer . merge ( makeSessionStoreLayer ( ) , TestClock . layer ( ) ) ) ) ,
182184 ) ;
183185
186+ it . effect ( "atomically replaces active sessions with the same subject and method" , ( ) =>
187+ Effect . gen ( function * ( ) {
188+ const sessions = yield * SessionStore . SessionStore ;
189+ const browser = yield * sessions . issue ( {
190+ subject : "desktop-bootstrap" ,
191+ method : "browser-session-cookie" ,
192+ } ) ;
193+ const [ firstBearer , secondBearer ] = yield * Effect . all (
194+ [
195+ sessions . issue ( {
196+ subject : "desktop-bootstrap" ,
197+ method : "bearer-access-token" ,
198+ replaceActiveForSubjectAndMethod : true ,
199+ } ) ,
200+ sessions . issue ( {
201+ subject : "desktop-bootstrap" ,
202+ method : "bearer-access-token" ,
203+ replaceActiveForSubjectAndMethod : true ,
204+ } ) ,
205+ ] ,
206+ { concurrency : "unbounded" } ,
207+ ) ;
208+
209+ const active = yield * sessions . listActive ( ) ;
210+ const bearerVerification = yield * Effect . all ( [
211+ sessions . verify ( firstBearer . token ) . pipe ( Effect . option ) ,
212+ sessions . verify ( secondBearer . token ) . pipe ( Effect . option ) ,
213+ ] ) ;
214+
215+ expect ( active ) . toHaveLength ( 2 ) ;
216+ expect ( active . find ( ( entry ) => entry . sessionId === browser . sessionId ) ) . toBeDefined ( ) ;
217+ expect (
218+ active . filter (
219+ ( entry ) =>
220+ entry . subject === "desktop-bootstrap" && entry . method === "bearer-access-token" ,
221+ ) ,
222+ ) . toHaveLength ( 1 ) ;
223+ expect ( bearerVerification . filter ( Option . isSome ) ) . toHaveLength ( 1 ) ;
224+ } ) . pipe ( Effect . provide ( makeSessionStoreLayer ( ) ) ) ,
225+ ) ;
226+
227+ it . effect ( "keeps the previous desktop session valid when replacement fails" , ( ) =>
228+ Effect . gen ( function * ( ) {
229+ const sessions = yield * SessionStore . SessionStore ;
230+ const sql = yield * SqlClient . SqlClient ;
231+ const previous = yield * sessions . issue ( {
232+ subject : "desktop-bootstrap" ,
233+ method : "bearer-access-token" ,
234+ } ) ;
235+ yield * sql `
236+ CREATE TRIGGER reject_auth_session_insert BEFORE INSERT ON auth_sessions
237+ BEGIN
238+ SELECT RAISE(ABORT, 'simulated insert failure');
239+ END
240+ ` ;
241+
242+ const error = yield * sessions
243+ . issue ( {
244+ subject : "desktop-bootstrap" ,
245+ method : "bearer-access-token" ,
246+ replaceActiveForSubjectAndMethod : true ,
247+ } )
248+ . pipe ( Effect . flip ) ;
249+
250+ expect ( error . _tag ) . toBe ( "SessionCredentialIssueError" ) ;
251+ expect ( ( yield * sessions . verify ( previous . token ) ) . sessionId ) . toBe ( previous . sessionId ) ;
252+ expect ( ( yield * sessions . listActive ( ) ) . map ( ( session ) => session . sessionId ) ) . toEqual ( [
253+ previous . sessionId ,
254+ ] ) ;
255+ } ) . pipe ( Effect . provide ( Layer . mergeAll ( makeSessionStoreLayer ( ) , SqlitePersistenceMemory ) ) ) ,
256+ ) ;
257+
184258 it . effect ( "rejects websocket tokens once the parent session has expired" , ( ) =>
185259 Effect . gen ( function * ( ) {
186260 const sessions = yield * SessionStore . SessionStore ;
0 commit comments