Skip to content

Commit 9bf3158

Browse files
committed
perf(mobile): skip unchanged terminal toolbar fade updates
1 parent 53896ae commit 9bf3158

1 file changed

Lines changed: 45 additions & 25 deletions

File tree

‎apps/mobile/src/components/ComposerToolbar.tsx‎

Lines changed: 45 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { ComponentProps, ReactNode } from "react";
2-
import { useCallback, useMemo, useState } from "react";
2+
import { useCallback, useRef, useState } from "react";
33
import {
44
Pressable,
55
ScrollView,
@@ -148,39 +148,59 @@ export function ComposerToolbarScroller(props: {
148148
readonly fadeSurface?: "card" | "sheet";
149149
readonly contentPaddingRight?: number;
150150
}) {
151-
const [metrics, setMetrics] = useState({
151+
const metricsRef = useRef({
152152
contentWidth: 0,
153153
offsetX: 0,
154154
viewportWidth: 0,
155+
showLeftFade: false,
156+
showRightFade: false,
157+
});
158+
const [scrollEdges, setScrollEdges] = useState({
159+
showLeftFade: false,
160+
showRightFade: false,
155161
});
156162

157-
const scrollEdges = useMemo(() => {
163+
const updateScrollEdges = useCallback(() => {
164+
const metrics = metricsRef.current;
158165
const maxOffset = Math.max(0, metrics.contentWidth - metrics.viewportWidth);
159-
return {
160-
showLeftFade: metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON,
161-
showRightFade: metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON,
162-
};
163-
}, [metrics]);
164-
165-
const handleLayout = useCallback((event: LayoutChangeEvent) => {
166-
const viewportWidth = event.nativeEvent.layout.width;
167-
setMetrics((current) =>
168-
current.viewportWidth === viewportWidth ? current : { ...current, viewportWidth },
169-
);
166+
const showLeftFade = metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON;
167+
const showRightFade = metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON;
168+
if (metrics.showLeftFade === showLeftFade && metrics.showRightFade === showRightFade) {
169+
return;
170+
}
171+
metrics.showLeftFade = showLeftFade;
172+
metrics.showRightFade = showRightFade;
173+
setScrollEdges({ showLeftFade, showRightFade });
170174
}, []);
171175

172-
const handleContentSizeChange = useCallback((contentWidth: number) => {
173-
setMetrics((current) =>
174-
current.contentWidth === contentWidth ? current : { ...current, contentWidth },
175-
);
176-
}, []);
176+
const handleLayout = useCallback(
177+
(event: LayoutChangeEvent) => {
178+
const viewportWidth = event.nativeEvent.layout.width;
179+
if (metricsRef.current.viewportWidth === viewportWidth) return;
180+
metricsRef.current.viewportWidth = viewportWidth;
181+
updateScrollEdges();
182+
},
183+
[updateScrollEdges],
184+
);
177185

178-
const handleScroll = useCallback((event: NativeSyntheticEvent<NativeScrollEvent>) => {
179-
const offsetX = event.nativeEvent.contentOffset.x;
180-
setMetrics((current) =>
181-
Math.abs(current.offsetX - offsetX) < 1 ? current : { ...current, offsetX },
182-
);
183-
}, []);
186+
const handleContentSizeChange = useCallback(
187+
(contentWidth: number) => {
188+
if (metricsRef.current.contentWidth === contentWidth) return;
189+
metricsRef.current.contentWidth = contentWidth;
190+
updateScrollEdges();
191+
},
192+
[updateScrollEdges],
193+
);
194+
195+
const handleScroll = useCallback(
196+
(event: NativeSyntheticEvent<NativeScrollEvent>) => {
197+
const offsetX = event.nativeEvent.contentOffset.x;
198+
if (Math.abs(metricsRef.current.offsetX - offsetX) < 1) return;
199+
metricsRef.current.offsetX = offsetX;
200+
updateScrollEdges();
201+
},
202+
[updateScrollEdges],
203+
);
184204

185205
return (
186206
<View className="relative min-w-0 flex-1">

0 commit comments

Comments
 (0)