Skip to content

Commit 9a9e419

Browse files
refactor(web): ChatView's model, mode, and workspace choices live in useComposerSelection
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent e25227a commit 9a9e419

2 files changed

Lines changed: 298 additions & 176 deletions

File tree

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 32 additions & 176 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { useComposerSelection } from "./chat/useComposerSelection";
12
import { useProjectCloneBanner } from "./chat/useProjectCloneBanner";
23
import { useAttachmentPreviewHandoff } from "./chat/useAttachmentPreviewHandoff";
34
import { useTimelineRewind } from "./chat/useTimelineRewind";
@@ -55,7 +56,6 @@ import {
5556
type ModelSelection,
5657
type OrchestrationV2ProviderTurn,
5758
type PreviewAnnotationPayload,
58-
ProviderInstanceId,
5959
type ServerProvider,
6060
type ScopedThreadRef,
6161
type ThreadId,
@@ -199,10 +199,8 @@ import { useNowMinute } from "../hooks/useNowMinute";
199199
import { usePanelAnimationSettings, usePanelPresence } from "../panelAnimations";
200200
import { useNewThreadHandler } from "../hooks/useHandleNewThread";
201201
import { useOpenPanelPullRequestUrl } from "../hooks/useOpenPanelPullRequestUrl";
202-
import { resolveAppModelSelectionForInstance } from "../modelSelection";
203202
import { isPreviewFocused } from "../lib/previewFocus";
204203
import { getTerminalFocusOwner } from "../lib/terminalFocus";
205-
import { resolveNewDraftStartFromOrigin } from "../lib/chatThreadActions";
206204
import {
207205
deriveLogicalProjectKeyFromSettings,
208206
selectProjectGroupingSettings,
@@ -331,7 +329,6 @@ import {
331329
dismissBranchMismatchForSession,
332330
shouldShowPlanFollowUpPrompt,
333331
shouldRenderPreviewMiniPlayer,
334-
getStartedThreadModelChangeBlockReason,
335332
deriveLockedProvider,
336333
resolveFileAttachmentUrl,
337334
resolveComposerInteractionMode,
@@ -370,7 +367,6 @@ import { draftFanoutSelectionsAtom, draftSendState } from "./chat/chatViewSend";
370367
import {
371368
isCompactCommandMessage,
372369
type LocalThreadErrorEntry,
373-
makeModelDisabledReason,
374370
makeThreadErrorSetter,
375371
} from "./ChatView.logic";
376372

@@ -587,9 +583,6 @@ export default function ChatView(props: ChatViewProps) {
587583
})();
588584
const settings = useEnvironmentSettings(environmentId);
589585
const clientSettingsHydrated = useClientSettingsHydrated();
590-
const setStickyComposerModelSelection = useComposerDraftStore(
591-
(store) => store.setStickyModelSelection,
592-
);
593586
const timestampFormat = settings.timestampFormat;
594587
const navigate = useNavigate();
595588
// Selects primitives: an object here is new on every router store update, which
@@ -639,11 +632,6 @@ export default function ChatView(props: ChatViewProps) {
639632
return draft ? composerDraftHasUserContent({ ...draft, prompt: "" }) : false;
640633
});
641634
const setComposerDraftPrompt = useComposerDraftStore((store) => store.setPrompt);
642-
const setComposerDraftModelSelection = useComposerDraftStore((store) => store.setModelSelection);
643-
const setComposerDraftRuntimeMode = useComposerDraftStore((store) => store.setRuntimeMode);
644-
const setComposerDraftInteractionMode = useComposerDraftStore(
645-
(store) => store.setInteractionMode,
646-
);
647635
const setDraftThreadContext = useComposerDraftStore((store) => store.setDraftThreadContext);
648636
const getDraftSessionByLogicalProjectKey = useComposerDraftStore(
649637
(store) => store.getDraftSessionByLogicalProjectKey,
@@ -2102,39 +2090,6 @@ export default function ChatView(props: ChatViewProps) {
21022090
scripts: activeProjectScripts,
21032091
settings,
21042092
});
2105-
2106-
const handleRuntimeModeChange = (mode: RuntimeMode) => {
2107-
if (mode === runtimeMode) return;
2108-
setComposerDraftRuntimeMode(composerDraftTarget, mode);
2109-
if (isLocalDraftThread) {
2110-
setDraftThreadContext(composerDraftTarget, { runtimeMode: mode });
2111-
}
2112-
scheduleComposerFocus();
2113-
};
2114-
const handleRuntimeModeChangeStable = useStableCallback(handleRuntimeModeChange);
2115-
2116-
const handleInteractionModeChange = (mode: ProviderInteractionMode) => {
2117-
if (mode === "plan" && !interactionModeEnabled) return;
2118-
if (mode === interactionMode) return;
2119-
setComposerDraftInteractionMode(composerDraftTarget, mode);
2120-
if (isLocalDraftThread) {
2121-
setDraftThreadContext(composerDraftTarget, { interactionMode: mode });
2122-
}
2123-
scheduleComposerFocus();
2124-
};
2125-
const handleInteractionModeChangeStable = useStableCallback(handleInteractionModeChange);
2126-
const toggleInteractionMode = () => {
2127-
if (!interactionModeEnabled) return;
2128-
handleInteractionModeChange(interactionMode === "plan" ? "default" : "plan");
2129-
};
2130-
const toggleInteractionModeStable = useStableCallback(toggleInteractionMode);
2131-
const openProviderSetup = (instanceId: ProviderInstanceId) => {
2132-
void navigate({
2133-
to: "/settings/providers",
2134-
search: { environmentId, instanceId },
2135-
});
2136-
};
2137-
const openProviderSetupStable = useStableCallback(openProviderSetup);
21382093
const canOperatePreview = useEnvironmentScope(
21392094
activeThreadRef?.environmentId ?? null,
21402095
AuthPreviewOperateScope,
@@ -3173,6 +3128,37 @@ export default function ChatView(props: ChatViewProps) {
31733128
void sendStandaloneCommand("/compact", "Failed to compact context.");
31743129
};
31753130

3131+
const {
3132+
getModelDisabledReason,
3133+
handleInteractionModeChange,
3134+
handleInteractionModeChangeStable,
3135+
handleRuntimeModeChangeStable,
3136+
onEnvModeChangeStable,
3137+
onProviderModelSelectStable,
3138+
onStartFromOriginChange,
3139+
openProviderSetupStable,
3140+
toggleInteractionModeStable,
3141+
} = useComposerSelection({
3142+
environmentId,
3143+
composerDraftTarget,
3144+
draftThread,
3145+
activeThread,
3146+
activeRuntime,
3147+
activeProjectSettings,
3148+
settings,
3149+
providerStatuses,
3150+
lockedProvider,
3151+
supportsProviderSwitchingViaHandoff,
3152+
multipleModelSelections,
3153+
runtimeMode,
3154+
interactionMode,
3155+
interactionModeEnabled,
3156+
isLocalDraftThread,
3157+
canOverrideServerThreadEnvMode,
3158+
setPendingServerThreadEnvModeEntry,
3159+
setPendingServerThreadStartFromOriginByThreadId,
3160+
scheduleComposerFocus,
3161+
});
31763162
const { onSend, onResume, onImplementPlanInNewThread, isResuming } = useComposerSend({
31773163
environmentId,
31783164
routeThreadKey,
@@ -3259,120 +3245,6 @@ export default function ChatView(props: ChatViewProps) {
32593245
});
32603246
const onImplementPlanInNewThreadStable = useStableCallback(onImplementPlanInNewThread);
32613247

3262-
// Keyed on the fields it reads: the thread and runtime objects change with
3263-
// every streamed event, and a new function re-renders the whole model picker.
3264-
const hasStartedSession = activeRuntime !== null;
3265-
const runtimeProviderInstanceId = activeRuntime?.providerInstanceId ?? null;
3266-
const currentModelSelection = activeThread?.modelSelection ?? null;
3267-
const getModelDisabledReason = makeModelDisabledReason(
3268-
currentModelSelection
3269-
? {
3270-
providers: providerStatuses,
3271-
hasStartedSession,
3272-
supportsProviderSwitchingViaHandoff,
3273-
currentModelSelection,
3274-
currentProviderInstanceId: runtimeProviderInstanceId,
3275-
}
3276-
: null,
3277-
);
3278-
3279-
const onProviderModelSelect = (
3280-
instanceId: ProviderInstanceId,
3281-
model: string,
3282-
options?: { focusComposer?: boolean },
3283-
) => {
3284-
if (!activeThread) return;
3285-
const entry = providerStatuses.find((snapshot) => snapshot.instanceId === instanceId);
3286-
const resolvedDriverKind = entry?.driver ?? null;
3287-
if (
3288-
!supportsProviderSwitchingViaHandoff &&
3289-
lockedProvider !== null &&
3290-
resolvedDriverKind !== null &&
3291-
resolvedDriverKind !== lockedProvider
3292-
) {
3293-
if (options?.focusComposer !== false) scheduleComposerFocus();
3294-
return;
3295-
}
3296-
if (
3297-
!supportsProviderSwitchingViaHandoff &&
3298-
lockedProvider !== null &&
3299-
activeRuntime?.providerInstanceId
3300-
) {
3301-
const currentEntry = providerStatuses.find(
3302-
(snapshot) => snapshot.instanceId === activeRuntime.providerInstanceId,
3303-
);
3304-
if (
3305-
currentEntry?.continuation?.groupKey &&
3306-
entry?.continuation?.groupKey &&
3307-
currentEntry.continuation.groupKey !== entry.continuation.groupKey
3308-
) {
3309-
if (options?.focusComposer !== false) scheduleComposerFocus();
3310-
return;
3311-
}
3312-
}
3313-
const resolvedModel = resolveAppModelSelectionForInstance(
3314-
instanceId,
3315-
settings,
3316-
providerStatuses,
3317-
model,
3318-
);
3319-
if (!resolvedModel) {
3320-
if (options?.focusComposer !== false) scheduleComposerFocus();
3321-
return;
3322-
}
3323-
const rememberedOptions =
3324-
useComposerDraftStore.getState().stickyOptionsByModelByProvider[instanceId]?.[resolvedModel];
3325-
const nextModelSelection: ModelSelection =
3326-
rememberedOptions !== undefined && rememberedOptions.length > 0
3327-
? { instanceId, model: resolvedModel, options: [...rememberedOptions] }
3328-
: { instanceId, model: resolvedModel };
3329-
const modelChangeBlockReason = getStartedThreadModelChangeBlockReason({
3330-
providers: providerStatuses,
3331-
hasStartedSession: activeRuntime !== null,
3332-
supportsProviderSwitchingViaHandoff,
3333-
currentModelSelection: activeThread.modelSelection,
3334-
currentProviderInstanceId: activeRuntime?.providerInstanceId ?? null,
3335-
nextModelSelection,
3336-
});
3337-
if (modelChangeBlockReason) {
3338-
toastManager.add({
3339-
type: "warning",
3340-
title: modelChangeBlockReason.title,
3341-
description: modelChangeBlockReason.description,
3342-
});
3343-
if (options?.focusComposer !== false) scheduleComposerFocus();
3344-
return;
3345-
}
3346-
setComposerDraftModelSelection(
3347-
scopeThreadRef(activeThread.environmentId, activeThread.id),
3348-
nextModelSelection,
3349-
{ explicit: true, replaceOptions: true },
3350-
);
3351-
setStickyComposerModelSelection(nextModelSelection);
3352-
if (options?.focusComposer !== false) scheduleComposerFocus();
3353-
};
3354-
const onProviderModelSelectStable = useStableCallback(onProviderModelSelect);
3355-
const onEnvModeChange = (mode: DraftThreadEnvMode) => {
3356-
if (multipleModelSelections !== null) return;
3357-
if (canOverrideServerThreadEnvMode) {
3358-
if (activeThread) setPendingServerThreadEnvModeEntry({ threadId: activeThread.id, mode });
3359-
scheduleComposerFocus();
3360-
return;
3361-
}
3362-
if (isLocalDraftThread) {
3363-
setDraftThreadContext(composerDraftTarget, {
3364-
envMode: mode,
3365-
startFromOrigin: resolveNewDraftStartFromOrigin({
3366-
envMode: mode,
3367-
newWorktreesStartFromOrigin: activeProjectSettings.settings.newWorktreesStartFromOrigin,
3368-
}),
3369-
...(mode === "worktree" && draftThread?.worktreePath ? { worktreePath: null } : {}),
3370-
});
3371-
}
3372-
scheduleComposerFocus();
3373-
};
3374-
const onEnvModeChangeStable = useStableCallback(onEnvModeChange);
3375-
33763248
const onWorktreeSetupWorkLocally = () => {
33773249
if (!worktreeSetup || worktreeSetup.phase !== "running" || !draftId) {
33783250
return;
@@ -3453,22 +3325,6 @@ export default function ChatView(props: ChatViewProps) {
34533325
workLocallyResendReady,
34543326
]);
34553327

3456-
const onStartFromOriginChange = (nextStartFromOrigin: boolean) => {
3457-
if (canOverrideServerThreadEnvMode && activeThread) {
3458-
setPendingServerThreadStartFromOriginByThreadId((current) =>
3459-
current[activeThread.id] === nextStartFromOrigin
3460-
? current
3461-
: { ...current, [activeThread.id]: nextStartFromOrigin },
3462-
);
3463-
return;
3464-
}
3465-
if (isLocalDraftThread) {
3466-
setDraftThreadContext(composerDraftTarget, {
3467-
startFromOrigin: nextStartFromOrigin,
3468-
});
3469-
}
3470-
};
3471-
34723328
const onExpandTimelineImage = (preview: ExpandedImagePreview) => {
34733329
openExpandedImagePreview(routeThreadKey, preview);
34743330
};

0 commit comments

Comments
 (0)