Skip to content

Commit 98f74fd

Browse files
committed
ci: keep merged checks reporting independently
A lint failure no longer skips release smoke, and a typecheck failure no longer skips the desktop build.
1 parent 8ddd77f commit 98f74fd

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ jobs:
8989
uses: ./.github/actions/ci-changes
9090

9191
- name: Setup Vite+
92+
id: setup
9293
uses: voidzero-dev/setup-vp@v1
9394
with:
9495
node-version-file: package.json
@@ -105,8 +106,9 @@ jobs:
105106
- name: Check
106107
run: vp check
107108

109+
# Runs even when an earlier lint step failed, as its own job did.
108110
- name: Exercise release-only workflow steps
109-
if: steps.changes.outputs.release_smoke != 'false'
111+
if: ${{ !cancelled() && steps.setup.outcome == 'success' && steps.changes.outputs.release_smoke != 'false' }}
110112
run: node scripts/release-smoke.ts
111113

112114
build:
@@ -146,26 +148,31 @@ jobs:
146148
run-install: true
147149

148150
- name: Ensure Electron runtime is installed
151+
id: electron
149152
run: vp run --filter @t3tools/desktop ensure:electron
150153

154+
# Typecheck and the build report independently: one failing does not
155+
# skip the other.
151156
- name: Typecheck
152-
if: needs.changes.outputs.typecheck != 'false'
157+
if: ${{ !cancelled() && steps.electron.outcome == 'success' && needs.changes.outputs.typecheck != 'false' }}
153158
run: vpr typecheck
154159

155160
- name: Finish installing browser secret helper build libraries
156-
if: needs.changes.outputs.build != 'false'
161+
id: apt
162+
if: ${{ !cancelled() && needs.changes.outputs.build != 'false' }}
157163
timeout-minutes: 5
158164
run: |
159165
until test -s "$RUNNER_TEMP/apt-status"; do sleep 1; done
160166
cat "$RUNNER_TEMP/apt.log"
161167
exit "$(cat "$RUNNER_TEMP/apt-status")"
162168
163169
- name: Build desktop pipeline
164-
if: needs.changes.outputs.build != 'false'
170+
id: build
171+
if: ${{ !cancelled() && steps.electron.outcome == 'success' && steps.apt.outcome == 'success' && needs.changes.outputs.build != 'false' }}
165172
run: vp run build:desktop
166173

167174
- name: Verify preload bundle output
168-
if: needs.changes.outputs.build != 'false'
175+
if: ${{ !cancelled() && steps.build.outcome == 'success' }}
169176
run: node apps/desktop/scripts/verify-preload-bundle.mjs
170177

171178
# Everything except `t3` (apps/server) and the web app, which has its own job

0 commit comments

Comments
 (0)