Skip to content

Commit 975c1e3

Browse files
fix(mobile): stop refreshes in hidden PR Guide panes
1 parent 9d7997a commit 975c1e3

6 files changed

Lines changed: 584 additions & 14 deletions

File tree

‎apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,12 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
746746
</View>
747747
</View>
748748
) : null}
749-
{tab === "guide" ? <PullRequestGuideContent params={params} /> : null}
749+
{tab === "guide" ? (
750+
<PullRequestGuideContent
751+
params={params}
752+
visible={section === "guide"}
753+
/>
754+
) : null}
750755
{tab === "activity" ? (
751756
<PullRequestActivityFilters
752757
value={activityFilter}

‎apps/mobile/src/features/pull-requests/guide/PullRequestGuideScreen.tsx‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,15 @@ const attentionLabels = {
4848
accessibility: "An accessibility call",
4949
};
5050

51-
export function PullRequestGuideContent({ params }: { readonly params: PullRequestParams }) {
51+
export function PullRequestGuideContent({
52+
params,
53+
visible = true,
54+
}: {
55+
readonly params: PullRequestParams;
56+
readonly visible?: boolean;
57+
}) {
5258
const navigation = useNavigation();
53-
const state = useReviewGuide(params);
59+
const state = useReviewGuide(params, visible);
5460
const { guide, stale } = reviewGuideState(state.data);
5561
return (
5662
<Animated.View layout={PR_ROW_LAYOUT} className="w-full max-w-[760px] self-center">

0 commit comments

Comments
 (0)