Skip to content

Commit 9678427

Browse files
bscholar-ttclaude
andcommitted
fix(pi): correct extension_ui_request handling per Pi RPC docs
- Fire-and-forget methods (notify/setStatus/setWidget/setTitle/set_editor_text) don't expect a response — stop sending spurious { value: "" } replies - editor expects { value: "..." } back like input, not cancellation — wire it through the same freeform path - Expand PendingExtensionUI.method to include "editor" Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent bfa551d commit 9678427

1 file changed

Lines changed: 13 additions & 14 deletions

File tree

‎apps/server/src/provider/Layers/PiAdapter.ts‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ interface PendingExtensionUI {
7878
readonly piId: string;
7979
readonly questionId: string;
8080
readonly deferred: Deferred.Deferred<ProviderUserInputAnswers, never>;
81-
readonly method: "select" | "confirm" | "input";
81+
readonly method: "select" | "confirm" | "input" | "editor";
8282
// Populated for `input` requests that were parsed as numbered lists.
8383
// Used to map selected labels back to 1-based indices for Pi's multi-select protocol.
8484
readonly numberedOptions?: ReadonlyArray<string>;
@@ -484,23 +484,19 @@ export const makePiAdapter = Effect.fn("makePiAdapter")(function* (
484484
context: PiSessionContext,
485485
event: RpcExtensionUIRequest,
486486
) {
487-
// Non-interactive side-effects: acknowledge immediately so Pi doesn't hang
487+
// Fire-and-forget side-effects: Pi does not wait for a response.
488488
if (
489489
event.method === "notify" ||
490490
event.method === "setStatus" ||
491491
event.method === "setWidget" ||
492492
event.method === "setTitle" ||
493493
event.method === "set_editor_text"
494494
) {
495-
yield* context.writeExtensionResponse({ type: "extension_ui_response", id: event.id, value: "" });
496495
return;
497496
}
498497

499-
// editor: no useful mapping, cancel immediately
500-
if (event.method === "editor") {
501-
yield* context.writeExtensionResponse({ type: "extension_ui_response", id: event.id, cancelled: true });
502-
return;
503-
}
498+
// editor: surface as freeform text input (same protocol shape as input).
499+
// Falls through to the input branch below.
504500

505501
// select / confirm / input: surface as user-input.requested
506502
const ourRequestId = ApprovalRequestId.make(yield* Random.nextUUIDv4);
@@ -531,10 +527,13 @@ export const makePiAdapter = Effect.fn("makePiAdapter")(function* (
531527
multiSelect: false,
532528
};
533529
} else {
534-
// input — Pi uses this for multi-select (numbered list in title) and freeform.
535-
// If the title contains a numbered list, parse it into real options with multiSelect.
536-
// Otherwise surface with empty options; T3's auto-added "Other" field handles free text.
537-
const parsed = parseNumberedList(event.title);
530+
// input / editor — both expect { value: "..." } back.
531+
// input: Pi uses this for multi-select (numbered list in title) and freeform.
532+
// If the title contains a numbered list, parse it into real options with multiSelect.
533+
// Otherwise surface with empty options; T3's auto-added "Other" field handles free text.
534+
// editor: multi-line freeform, no options — same freeform path.
535+
const title = "title" in event ? event.title : "";
536+
const parsed = event.method === "input" ? parseNumberedList(title) : null;
538537
if (parsed) {
539538
numberedOptions = parsed.items;
540539
question = {
@@ -547,8 +546,8 @@ export const makePiAdapter = Effect.fn("makePiAdapter")(function* (
547546
} else {
548547
question = {
549548
id: questionId,
550-
header: event.title.slice(0, 12),
551-
question: event.title,
549+
header: title.slice(0, 12),
550+
question: title,
552551
options: [],
553552
multiSelect: false,
554553
};

0 commit comments

Comments
 (0)