Repository navigation
Commit 963c034
refactor(web): the upload queue alone records finished file uploads on drafts
Problem: ChatComposer ran an effect on every upload-store change to write
uploadedAttachmentId/uploadEnvironmentId into the draft for each file whose
upload was ready. The upload queue already does this when an upload finishes
or a persisted upload verifies, so the effect almost always wrote nothing.
It only mattered when a file landed in a draft after its upload had finished
(stash or failed-send restore).
Fix: startAttachmentUpload's early return for an upload that is already
ready in the same environment now stamps the draft that holds the file. The
composer's upload effect already calls startAttachmentUpload for that file,
so the queue now does all the stamping, and the ChatComposer effect and its
setFileUpload selector are removed.
Effects: ChatComposer.tsx 1 fewer (the stamping effect). The upload-start
effect stays: it starts uploads, which are I/O.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent dc84b09 commit 963c034
3 files changed
Lines changed: 33 additions & 34 deletions
File tree
- apps/web/src
- components/chat
- lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
811 | 811 | | |
812 | 812 | | |
813 | 813 | | |
814 | | - | |
815 | 814 | | |
816 | 815 | | |
817 | 816 | | |
| |||
880 | 879 | | |
881 | 880 | | |
882 | 881 | | |
883 | | - | |
884 | | - | |
885 | | - | |
886 | | - | |
887 | | - | |
888 | | - | |
889 | | - | |
890 | | - | |
891 | | - | |
892 | | - | |
893 | | - | |
894 | | - | |
895 | | - | |
896 | | - | |
897 | | - | |
898 | | - | |
899 | | - | |
900 | | - | |
901 | | - | |
902 | | - | |
903 | | - | |
904 | | - | |
905 | | - | |
906 | | - | |
907 | | - | |
908 | | - | |
909 | | - | |
910 | | - | |
911 | | - | |
912 | | - | |
913 | | - | |
914 | 882 | | |
915 | 883 | | |
916 | 884 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
382 | 408 | | |
383 | 409 | | |
384 | 410 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
60 | 62 | | |
61 | 63 | | |
62 | 64 | | |
| |||
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
85 | | - | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
| |||
110 | 112 | | |
111 | 113 | | |
112 | 114 | | |
113 | | - | |
| 115 | + | |
114 | 116 | | |
115 | 117 | | |
116 | 118 | | |
| |||
402 | 404 | | |
403 | 405 | | |
404 | 406 | | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
405 | 410 | | |
406 | 411 | | |
407 | 412 | | |
| |||
0 commit comments