Skip to content

Commit 959ad1d

Browse files
committed
feat(web): point provider environment variables at a secret provider
Signed-off-by: Yordis Prieto <[email protected]>
1 parent 00a18b7 commit 959ad1d

7 files changed

Lines changed: 441 additions & 71 deletions

‎apps/web/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"@t3tools/client-runtime": "workspace:*",
3535
"@t3tools/contracts": "workspace:*",
3636
"@t3tools/provider-core": "workspace:*",
37+
"@t3tools/secret-provider-definitions": "workspace:*",
3738
"@t3tools/shared": "workspace:*",
3839
"@tanstack/react-pacer": "^0.19.4",
3940
"@tanstack/react-router": "^1.160.2",

‎apps/web/src/components/settings/AddProviderInstanceDialog.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ import { resolveOfficialAcpRegistryIconUrl } from "./AcpRegistryIcon";
5555
import { AddManagedCodexAccountDialog } from "./CodexSetupSection";
5656
import { MultipleAccountsNote } from "./MultipleAccountsNote";
5757
import { ProviderEnvironmentSection } from "./ProviderInstanceCard";
58+
import { useSecretSources } from "./SecretSourceInput";
5859

5960
/** Limit the slug to 48 chars so the composed ProviderInstanceId fits its 64-char cap. */
6061
function slugifyLabel(value: string): string {
@@ -160,6 +161,7 @@ export function AddProviderInstanceDialog({
160161
onCreated,
161162
}: AddProviderInstanceDialogProps) {
162163
const settings = useEnvironmentSettings(environmentId);
164+
const secretSources = useSecretSources(environmentId);
163165
const persistProviderInstance = usePersistEnvironmentProviderInstanceMutation(environmentId);
164166
const canManageProviders = useEnvironmentScope(environmentId, AuthProvidersManageScope);
165167

@@ -536,6 +538,7 @@ export function AddProviderInstanceDialog({
536538
<ProviderEnvironmentSection
537539
environment={localEnvironment}
538540
onChange={setLocalEnvironment}
541+
secretSources={secretSources}
539542
/>
540543
) : null}
541544
</SettingsGroup>

‎apps/web/src/components/settings/ProviderInstanceCard.test.ts‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import { describe, expect, it } from "vite-plus/test";
2-
import type { ServerProviderModel } from "@t3tools/contracts";
2+
import { SecretProviderId, type ServerProviderModel } from "@t3tools/contracts";
33

44
import {
55
deriveProviderModelsForDisplay,
6+
nextProviderEnvironmentWithFieldSecret,
67
nextProviderEnvironmentWithFieldValue,
78
} from "./ProviderInstanceCard";
89

@@ -75,6 +76,20 @@ describe("provider environment helpers", () => {
7576
).toEqual([{ name: "CURSOR_API_KEY", value: "new-key", sensitive: true }]);
7677
});
7778

79+
it("points a stored provider secret at a secret provider and drops the stored value", () => {
80+
const secret = {
81+
provider: SecretProviderId.make("personal"),
82+
reference: "op://Private/Cursor/credential",
83+
};
84+
const stored = [{ name: "CURSOR_API_KEY", value: "", sensitive: true, valueRedacted: true }];
85+
const referenced = nextProviderEnvironmentWithFieldSecret(stored, cursorApiKeyField, secret);
86+
87+
expect(referenced).toEqual([{ name: "CURSOR_API_KEY", value: secret, sensitive: true }]);
88+
expect(
89+
nextProviderEnvironmentWithFieldSecret(referenced, cursorApiKeyField, undefined),
90+
).toEqual([]);
91+
});
92+
7893
it("applies the secure field default when replacing an existing non-sensitive value", () => {
7994
expect(
8095
nextProviderEnvironmentWithFieldValue(

0 commit comments

Comments
 (0)