@@ -1825,9 +1825,37 @@ describe("cached pull request detail", () => {
18251825 return {
18261826 getItem : ( key : string ) => held . get ( key ) ?? null ,
18271827 setItem : ( key : string , value : string ) => void held . set ( key , value ) ,
1828+ removeItem : ( key : string ) => void held . delete ( key ) ,
1829+ size : ( ) => held . size ,
18281830 } ;
18291831 } ;
18301832
1833+ it ( "keeps only the 20 most recently saved pull requests" , ( ) => {
1834+ const storage = makeStorage ( ) ;
1835+ const numbered = ( number : number ) => ( { ...reference , number } ) ;
1836+ for ( let number = 1 ; number <= 21 ; number += 1 ) {
1837+ writePullRequestDetailSnapshot ( storage , "env-1" , numbered ( number ) , detail ( { number } ) ) ;
1838+ }
1839+ expect ( readPullRequestDetailSnapshot ( storage , "env-1" , numbered ( 1 ) ) ) . toBeNull ( ) ;
1840+ expect ( readPullRequestDetailSnapshot ( storage , "env-1" , numbered ( 2 ) ) ?. number ) . toBe ( 2 ) ;
1841+ expect ( readPullRequestDetailSnapshot ( storage , "env-1" , numbered ( 21 ) ) ?. number ) . toBe ( 21 ) ;
1842+ // Twenty snapshots plus the list of their keys.
1843+ expect ( storage . size ( ) ) . toBe ( 21 ) ;
1844+ } ) ;
1845+
1846+ it ( "saving a pull request again keeps it as the newest without growing the list" , ( ) => {
1847+ const storage = makeStorage ( ) ;
1848+ const numbered = ( number : number ) => ( { ...reference , number } ) ;
1849+ for ( let number = 1 ; number <= 20 ; number += 1 ) {
1850+ writePullRequestDetailSnapshot ( storage , "env-1" , numbered ( number ) , detail ( { number } ) ) ;
1851+ }
1852+ writePullRequestDetailSnapshot ( storage , "env-1" , numbered ( 1 ) , detail ( { number : 1 } ) ) ;
1853+ writePullRequestDetailSnapshot ( storage , "env-1" , numbered ( 21 ) , detail ( { number : 21 } ) ) ;
1854+ expect ( readPullRequestDetailSnapshot ( storage , "env-1" , numbered ( 1 ) ) ?. number ) . toBe ( 1 ) ;
1855+ expect ( readPullRequestDetailSnapshot ( storage , "env-1" , numbered ( 2 ) ) ) . toBeNull ( ) ;
1856+ expect ( storage . size ( ) ) . toBe ( 21 ) ;
1857+ } ) ;
1858+
18311859 it ( "hydrates the last title, author, and counts so a reopen does not ghost the tab" , ( ) => {
18321860 const storage = makeStorage ( ) ;
18331861 writePullRequestDetailSnapshot ( storage , "env-1" , reference , detail ( ) ) ;
0 commit comments