Skip to content

Commit 94b5e0a

Browse files
juliusmarmingecodex
andcommitted
test: remove redundant VCS cause assertions
Co-authored-by: codex <[email protected]>
1 parent 3c998fc commit 94b5e0a

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

‎apps/server/src/git/GitWorkflowService.test.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ describe("GitWorkflowService", () => {
135135
),
136136
);
137137

138-
it.effect("preserves structured workflow detection failures and their cause", () => {
138+
it.effect("structures workflow detection failures without exposing upstream details", () => {
139139
const cause = new VcsRepositoryDetectionError({
140140
operation: "VcsDriverRegistry.detect",
141141
cwd: "/repo",
@@ -151,7 +151,6 @@ describe("GitWorkflowService", () => {
151151
operation: "GitWorkflowService.status",
152152
cwd: "/repo",
153153
detail: "Failed to detect a VCS repository for this Git workflow.",
154-
cause,
155154
});
156155
expect(error.message).not.toContain(cause.detail);
157156
}).pipe(
@@ -163,7 +162,7 @@ describe("GitWorkflowService", () => {
163162
);
164163
});
165164

166-
it.effect("preserves structured command detection failures and their cause", () => {
165+
it.effect("structures command detection failures without exposing upstream details", () => {
167166
const cause = new VcsRepositoryDetectionError({
168167
operation: "VcsDriverRegistry.detect",
169168
cwd: "/repo",
@@ -180,7 +179,6 @@ describe("GitWorkflowService", () => {
180179
command: "vcs-route",
181180
cwd: "/repo",
182181
detail: "Failed to detect a VCS repository for this Git command.",
183-
cause,
184182
});
185183
expect(error.message).not.toContain(cause.detail);
186184
}).pipe(

‎apps/server/src/vcs/VcsStatusBroadcaster.test.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,6 @@ describe("VcsStatusBroadcaster", () => {
629629
defectTags: ["TypeError"],
630630
interruptionCount: 0,
631631
});
632-
assert.strictEqual(failure.cause, nestedCause);
633632
});
634633

635634
it.effect("stops the remote poller after the last stream subscriber disconnects", () => {

0 commit comments

Comments
 (0)