@@ -5128,19 +5128,19 @@ it.effect("reuses an observed merged state for strict settlement reads", () =>
51285128 } ) ,
51295129) ;
51305130
5131- it . effect ( "announces state, edits, and conflicts a detail read sees" , ( ) =>
5131+ it . effect ( "announces state a detail read sees first or newly " , ( ) =>
51325132 Effect . gen ( function * ( ) {
51335133 let detail = {
5134- ...hostedChangeRequest ( "body" ) ,
51355134 state : "open" as "open" | "closed" | "merged" ,
5135+ updatedAt : "2026-07-02T00:00:00Z" ,
51365136 } ;
51375137 let summaryState : "open" | "merged" = "open" ;
51385138 const reference = { projectId : "p1" as ProjectId , repository : "acme/web" , number : 1 } ;
51395139 const service = yield * makeService ( {
51405140 projects : [ project ( { id : "p1" , title : "web" , workspaceRoot : "/a" , repository : "acme/web" } ) ] ,
51415141 providers : [
51425142 fakeProvider ( SourceControlProviderKind . make ( "github" ) , {
5143- getChangeRequest : ( ) => Effect . succeed ( detail ) ,
5143+ getChangeRequest : ( ) => Effect . succeed ( { ... hostedChangeRequest ( "body" ) , ... detail } ) ,
51445144 getChangeRequestSummary : ( ) =>
51455145 Effect . succeed ( {
51465146 ...changeRequest ( 1 , "2026-07-04T00:00:00Z" ) ,
@@ -5159,37 +5159,28 @@ it.effect("announces state, edits, and conflicts a detail read sees", () =>
51595159 yield * Effect . yieldNow ;
51605160 } ) ;
51615161
5162- // First sight announces; unchanged fields , even from a fresh read, do not.
5162+ // First sight announces; the same state again , even from a fresh read, does not.
51635163 yield * readDetail ;
51645164 yield * readDetail ;
51655165 assert . deepStrictEqual ( announced , [ "github.com/acme/web#1" ] ) ;
51665166
5167- // An edit bumps the host update time; a new conflict does not, and announces anyway.
5168- detail = { ...detail , title : "Updated title" , updatedAt : "2026-07-02T12:00:00Z" } ;
5167+ detail = { state : "closed" , updatedAt : "2026-07-03T00:00:00Z" } ;
51695168 yield * readDetail ;
51705169 assert . strictEqual ( announced . length , 2 ) ;
5171- detail = { ...detail , mergeability : "conflicting" } ;
5172- yield * readDetail ;
5173- yield * readDetail ;
5174- assert . strictEqual ( announced . length , 3 ) ;
5175-
5176- detail = { ...detail , state : "closed" , updatedAt : "2026-07-03T00:00:00Z" } ;
5177- yield * readDetail ;
5178- assert . strictEqual ( announced . length , 4 ) ;
51795170
51805171 // A summary seeing the merge first does not hide it from the detail read after.
51815172 summaryState = "merged" ;
51825173 yield * service . summary ( reference , { recoverTransientFailure : false } ) ;
51835174 yield * Effect . yieldNow ;
5184- assert . strictEqual ( announced . length , 4 ) ;
5185- detail = { ... detail , state : "merged" , updatedAt : "2026-07-04T00:00:00Z" } ;
5175+ assert . strictEqual ( announced . length , 2 ) ;
5176+ detail = { state : "merged" , updatedAt : "2026-07-04T00:00:00Z" } ;
51865177 yield * readDetail ;
5187- assert . strictEqual ( announced . length , 5 ) ;
5178+ assert . strictEqual ( announced . length , 3 ) ;
51885179
51895180 // A detail read older than the merge cannot announce a reopen.
5190- detail = { ... detail , state : "open" , updatedAt : "2026-07-03T00:00:00Z" } ;
5181+ detail = { state : "open" , updatedAt : "2026-07-03T00:00:00Z" } ;
51915182 yield * readDetail ;
5192- assert . strictEqual ( announced . length , 5 ) ;
5183+ assert . strictEqual ( announced . length , 3 ) ;
51935184 } ) ,
51945185) ;
51955186
0 commit comments