Skip to content

Commit 91c1e3a

Browse files
perf(web): toggling a client setting no longer re-renders every settings row
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent b987b57 commit 91c1e3a

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

‎apps/web/src/components/settings/useSettingsProjectGroups.ts‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
11
import { useClientSettings } from "../../hooks/useSettings";
2-
import { selectProjectGroupingSettings } from "../../logicalProject";
32
import { buildSidebarProjectSnapshots } from "../../sidebarProjectGrouping";
43
import { useEnvironments, usePrimaryEnvironmentId } from "../../state/environments";
54
import { useProjects } from "../../state/entities";
65

76
export function useSettingsProjectGroups() {
87
const projects = useProjects();
9-
const settings = useClientSettings(selectProjectGroupingSettings);
8+
// Read the grouping fields one by one: a selector that builds an object hands back a new
9+
// identity on every client settings write, which rebuilds every group and, through the
10+
// settings scope, re-renders every settings row.
11+
const sidebarProjectGroupingMode = useClientSettings(
12+
(settings) => settings.sidebarProjectGroupingMode,
13+
);
14+
const sidebarProjectGroupingOverrides = useClientSettings(
15+
(settings) => settings.sidebarProjectGroupingOverrides,
16+
);
1017
const primaryEnvironmentId = usePrimaryEnvironmentId();
1118
const { environments } = useEnvironments();
1219
const labels = new Map(environments.map((entry) => [entry.environmentId, entry.label]));
1320
return buildSidebarProjectSnapshots({
1421
projects,
15-
settings,
22+
settings: { sidebarProjectGroupingMode, sidebarProjectGroupingOverrides },
1623
primaryEnvironmentId,
1724
resolveEnvironmentLabel: (id) => labels.get(id) ?? null,
1825
}).sort((a, b) => a.displayName.localeCompare(b.displayName));

0 commit comments

Comments
 (0)