Skip to content

Commit 90f987b

Browse files
perf(web): the PR guide diff loader compiles with the React Compiler
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a702563 commit 90f987b

1 file changed

Lines changed: 21 additions & 19 deletions

File tree

‎apps/web/src/components/pullRequest/guide/useGuideDiffFiles.ts‎

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { FileDiffMetadata } from "@pierre/diffs";
22
import type { EnvironmentId, PullRequestRef } from "@t3tools/contracts";
3-
import { useEffect, useState } from "react";
3+
import { useState } from "react";
44

55
import { getRenderablePatch, resolveFileDiffPath } from "~/lib/diffRendering";
66
import { pullRequestEnvironment } from "~/state/pullRequests";
@@ -13,6 +13,7 @@ interface LoadedDiff {
1313
readonly cursor: string | null;
1414
readonly done: boolean;
1515
readonly files: ReadonlyMap<string, FileDiffMetadata>;
16+
readonly folded: unknown;
1617
}
1718

1819
const NO_FILES: ReadonlyMap<string, FileDiffMetadata> = new Map();
@@ -34,9 +35,10 @@ export function useGuideDiffFiles({
3435
cursor: null,
3536
done: false,
3637
files: NO_FILES,
38+
folded: null,
3739
});
3840
const current: LoadedDiff =
39-
loaded.key === key ? loaded : { key, cursor: null, done: false, files: NO_FILES };
41+
loaded.key === key ? loaded : { key, cursor: null, done: false, files: NO_FILES, folded: null };
4042
const missing = wantedPaths.some((path) => !current.files.has(path));
4143
const loading = missing && !current.done;
4244
const query = useEnvironmentQuery(
@@ -48,25 +50,25 @@ export function useGuideDiffFiles({
4850
: null,
4951
);
5052

53+
// Each page is folded in once, during the render that first sees it.
5154
const data = query.data;
52-
const cursor = current.cursor;
53-
useEffect(() => {
54-
if (data === null) return;
55-
setLoaded((previous) => {
56-
const base =
57-
previous.key === key ? previous : { key, cursor: null, done: false, files: NO_FILES };
58-
if (base.cursor !== cursor || base.done) return base;
59-
const parsed = getRenderablePatch(
60-
data.patch,
61-
`pull-request-guide:${key}:${cursor ?? "first"}`,
62-
);
63-
const files = new Map(base.files);
64-
if (parsed?.kind === "files") {
65-
for (const file of parsed.files) files.set(resolveFileDiffPath(file), file);
66-
}
67-
return { key, cursor: data.nextCursor, done: data.nextCursor === null, files };
55+
if (data !== null && !current.done && current.folded !== data) {
56+
const parsed = getRenderablePatch(
57+
data.patch,
58+
`pull-request-guide:${key}:${current.cursor ?? "first"}`,
59+
);
60+
const files = new Map(current.files);
61+
if (parsed?.kind === "files") {
62+
for (const file of parsed.files) files.set(resolveFileDiffPath(file), file);
63+
}
64+
setLoaded({
65+
key,
66+
cursor: data.nextCursor,
67+
done: data.nextCursor === null,
68+
files,
69+
folded: data,
6870
});
69-
}, [cursor, data, key]);
71+
}
7072

7173
return {
7274
files: current.files,

0 commit comments

Comments
 (0)