Skip to content

Commit 8f8d18f

Browse files
refactor(provider-acp-registry): move the ACP Registry into its own package
The ACP Registry moves into @t3tools/provider-acp-registry, built on @t3tools/provider-acp: - ./settings: AcpRegistrySettings and the distribution preference, moved out of contracts. - ./client: label, settings form, no default instance, and the registry glyph clients fall back to while an agent's own icon loads. - ./server: the driver, the adapter driver, and the managed-binary directories the terminal manager keeps off agent PATHs. - ./server/AcpRegistrySupport and ./server/AcpRegistryRuntimeCoordinator: the catalog and coordinator services, imported as namespaces. AcpRegistryCatalog.layerFromHost builds both from ProviderHost paths. - ./testing: adapter, probe, and Devin helpers the server's ACP tests use. The package reaches the server only through ProviderHost. Its settings gain withSnapshot, which the catalog uses to check whether an installed agent is still referenced before removing it. The test host's settings can now change during a test (TestProviderHostSettings). Two generic pieces move to shared packages: PtyAdapter to @t3tools/shared and ProviderAuthFlow to provider-core. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 563645c commit 8f8d18f

55 files changed

Lines changed: 451 additions & 236 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎apps/mobile/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
"@t3tools/mobile-markdown-text": "file:./modules/t3-markdown-text",
7070
"@t3tools/mobile-review-diff-native": "file:./modules/t3-review-diff",
7171
"@t3tools/mobile-terminal-native": "file:./modules/t3-terminal",
72+
"@t3tools/provider-acp-registry": "workspace:*",
7273
"@t3tools/provider-core": "workspace:*",
7374
"@t3tools/provider-cursor": "workspace:*",
7475
"@t3tools/provider-grok": "workspace:*",

‎apps/mobile/src/lib/providerClients.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { isProviderDriverKind } from "@t3tools/contracts";
2+
import { acpRegistryClient } from "@t3tools/provider-acp-registry/client";
23
import { makeProviderClientRegistry } from "@t3tools/provider-core/client";
34
import { cursorClient } from "@t3tools/provider-cursor/client";
45
import { grokClient } from "@t3tools/provider-grok/client";
@@ -13,6 +14,7 @@ const providerClients = makeProviderClientRegistry([
1314
museClient,
1415
openCodeClient,
1516
piClient,
17+
acpRegistryClient,
1618
]);
1719

1820
/** The client definition for a driver kind, or `undefined` for drivers drawn by hand. */

‎apps/server/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
"@ff-labs/fff-node": "0.9.4",
3737
"@muse-code/sdk": "1.4.2",
3838
"@napi-rs/keyring": "^1.3.0",
39-
"@noble/hashes": "catalog:",
4039
"@opencode-ai/sdk": "^1.3.15",
4140
"@t3tools/provider-acp": "workspace:*",
41+
"@t3tools/provider-acp-registry": "workspace:*",
4242
"@t3tools/provider-core": "workspace:*",
4343
"@t3tools/provider-cursor": "workspace:*",
4444
"@t3tools/provider-grok": "workspace:*",

‎apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
normalizeDevinSessionUpdate,
33
normalizeDevinToolCall,
44
extractDevinSubagentUpdate,
5-
} from "./DevinAcp.ts";
5+
} from "@t3tools/provider-acp-registry/testing";
66
// @effect-diagnostics nodeBuiltinImport:off
77
import * as NodeChildProcess from "node:child_process";
88
import * as NodeFS from "node:fs";
@@ -95,7 +95,7 @@ import { makeGrokAdapterV2 } from "@t3tools/provider-grok/testing";
9595
import {
9696
acpRegistryPromptFailure,
9797
registerMistralVibeAcpExtensions,
98-
} from "./AcpRegistryAdapterV2.ts";
98+
} from "@t3tools/provider-acp-registry/testing";
9999

100100
const DEFAULT_GROK_SETTINGS = Schema.decodeSync(GrokSettings)({});
101101

‎apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import * as ServerSettings from "../../serverSettings.ts";
1919
import type {
2020
AcpRegistryAvailableCommands,
2121
AcpRegistryLiveConfiguration,
22-
} from "../../provider/acp/AcpRegistryProbe.ts";
23-
import * as AcpRegistrySupport from "../../provider/acp/AcpRegistrySupport.ts";
22+
} from "@t3tools/provider-acp-registry/testing";
23+
import * as AcpRegistrySupport from "@t3tools/provider-acp-registry/server/AcpRegistrySupport";
2424
import { ACP_SESSION_MODE_OPTION_ID } from "@t3tools/provider-acp/server/sessionConfig";
2525
import * as AcpSessionRuntime from "@t3tools/provider-acp/server/AcpSessionRuntime";
2626
import * as IdAllocator from "@t3tools/provider-core/server/IdAllocator";
@@ -31,12 +31,12 @@ import {
3131
} from "./AcpAdapterV2.testkit.ts";
3232
import { ProviderAdapterV2RuntimePolicy } from "@t3tools/provider-core/server/ProviderAdapter";
3333
import { BUILT_IN_PROVIDER_ADAPTER_DRIVER_KINDS_V2 } from "../builtInProviderAdapterDrivers.ts";
34+
import { AcpRegistryAdapterV2Driver } from "@t3tools/provider-acp-registry/server";
3435
import {
3536
ACP_REGISTRY_PROVIDER,
36-
AcpRegistryAdapterV2Driver,
3737
makeAcpRegistryAdapterV2,
3838
acpRegistryPromptFailure,
39-
} from "./AcpRegistryAdapterV2.ts";
39+
} from "@t3tools/provider-acp-registry/testing";
4040

4141
const registryUrl = "https://registry.test/registry.json";
4242
const decodeAcpRegistryAdapterSettings = Schema.decodeUnknownEffect(

‎apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as NodeServices from "@effect/platform-node/NodeServices";
2-
import { AcpRegistrySettings } from "@t3tools/contracts";
2+
import { AcpRegistrySettings } from "@t3tools/provider-acp-registry/settings";
33
import { resolveSelfInvocation } from "@t3tools/shared/nodeRuntime";
44
import * as Effect from "effect/Effect";
55
import * as FileSystem from "effect/FileSystem";
@@ -24,7 +24,7 @@ import {
2424
ACP_REGISTRY_DEFAULT_INSTANCE_ID,
2525
ACP_REGISTRY_PROVIDER,
2626
makeAcpRegistryAdapterV2,
27-
} from "./AcpRegistryAdapterV2.ts";
27+
} from "@t3tools/provider-acp-registry/testing";
2828

2929
const REPLAY_SETTINGS = Schema.decodeUnknownSync(AcpRegistrySettings)({
3030
agentId: "replay-agent",

‎apps/server/src/orchestration-v2/ProviderAdapterRegistry.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import * as Schema from "effect/Schema";
1818
import type * as Scope from "effect/Scope";
1919
import * as Stream from "effect/Stream";
2020

21-
import * as ProviderAuthFlow from "../provider/ProviderAuthFlow.ts";
21+
import * as ProviderAuthFlow from "@t3tools/provider-core/server/ProviderAuthFlow";
2222
import type { ProviderAuthController } from "../provider/ProviderAuthService.ts";
2323
import type { ProviderInstance } from "@t3tools/provider-core/server/driver";
2424
import * as ProviderInstanceRegistry from "../provider/ProviderInstanceRegistry.ts";

‎apps/server/src/orchestration-v2/builtInProviderAdapterDrivers.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { ProviderDriverKind } from "@t3tools/contracts";
33
import {
44
AcpRegistryAdapterV2Driver,
55
type AcpRegistryAdapterV2DriverEnv,
6-
} from "./Adapters/AcpRegistryAdapterV2.ts";
6+
} from "@t3tools/provider-acp-registry/server";
77
import {
88
ClaudeAdapterV2Driver,
99
type ClaudeAdapterV2DriverEnv,

‎apps/server/src/provider/AcpRegistryCatalog.ts‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

apps/server/src/provider/acp/AcpRegistryProbe.test.ts renamed to apps/server/src/provider/AcpRegistryProbe.test.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import * as NodePath from "node:path";
33
import * as NodeURL from "node:url";
44

55
import * as NodeServices from "@effect/platform-node/NodeServices";
6-
import { AcpRegistrySettings, ProviderInstanceId } from "@t3tools/contracts";
6+
import { ProviderInstanceId } from "@t3tools/contracts";
7+
import { AcpRegistrySettings } from "@t3tools/provider-acp-registry/settings";
78
import { describe, expect, it } from "@effect/vitest";
89
import * as Deferred from "effect/Deferred";
910
import * as Effect from "effect/Effect";
@@ -21,12 +22,12 @@ import {
2122
normalizeAcpRegistryAuthMethods,
2223
normalizeAcpRegistryCommands,
2324
probeAcpRegistryConfiguration,
24-
} from "./AcpRegistryProbe.ts";
25-
import * as AcpRegistrySupport from "./AcpRegistrySupport.ts";
25+
} from "@t3tools/provider-acp-registry/testing";
26+
import * as AcpRegistrySupport from "@t3tools/provider-acp-registry/server/AcpRegistrySupport";
2627

2728
const instanceId = ProviderInstanceId.make("acpRegistry_codex");
2829
const __dirname = NodePath.dirname(NodeURL.fileURLToPath(import.meta.url));
29-
const mockAgentPath = NodePath.join(__dirname, "../../../scripts/acp-mock-agent.ts");
30+
const mockAgentPath = NodePath.join(__dirname, "../../scripts/acp-mock-agent.ts");
3031
const decodeSettings = Schema.decodeSync(AcpRegistrySettings);
3132

3233
describe("ACP Registry probe", () => {

0 commit comments

Comments
 (0)