Skip to content

Commit 8df96fb

Browse files
fix(web): add tooltips to boring sidebar actions (#26477)
1 parent 6e1bec5 commit 8df96fb

2 files changed

Lines changed: 36 additions & 21 deletions

File tree

‎apps/web/src/components/sidebar/SidebarProjectFolderHeader.tsx‎

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { useUiStateStore } from "../../uiStateStore";
99
import { resolveSidebarFolderDot, resolveThreadLastVisitedAt } from "../Sidebar.logic";
1010
import { ProjectFavicon } from "../ProjectFavicon";
1111
import { Button } from "../ui/button";
12+
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
1213

1314
const FOLDER_DOT_CLASS_NAME = {
1415
attention: "bg-warning",
@@ -100,15 +101,22 @@ export const SidebarProjectFolderHeader = memo(function SidebarProjectFolderHead
100101
</button>
101102
{/* Sits over the count, which hides on hover, and left of the chevron. */}
102103
<span className="absolute inset-y-0 right-6 flex items-center opacity-0 focus-within:opacity-100 group-hover/project-folder:opacity-100 pointer-coarse:opacity-100">
103-
<Button
104-
data-sidebar-action-for={rowId}
105-
size="icon-xs"
106-
variant="ghost-muted"
107-
aria-label={`New thread in ${group.displayName}`}
108-
onClick={() => props.onNewThread(group)}
109-
>
110-
<SquarePenIcon aria-hidden />
111-
</Button>
104+
<Tooltip>
105+
<TooltipTrigger
106+
render={
107+
<Button
108+
data-sidebar-action-for={rowId}
109+
size="icon-xs"
110+
variant="ghost-muted"
111+
aria-label={`New thread in ${group.displayName}`}
112+
onClick={() => props.onNewThread(group)}
113+
/>
114+
}
115+
>
116+
<SquarePenIcon aria-hidden />
117+
</TooltipTrigger>
118+
<TooltipPopup>New thread in {group.displayName}</TooltipPopup>
119+
</Tooltip>
112120
</span>
113121
</li>
114122
);

‎apps/web/src/components/sidebar/SidebarThreadRow.tsx‎

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,18 +1352,25 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
13521352
<TooltipPopup side="top">Un-settle thread</TooltipPopup>
13531353
</Tooltip>
13541354
) : (
1355-
<button
1356-
type="button"
1357-
aria-label="Settle thread"
1358-
onClick={handleSettleClick}
1359-
onPointerDown={handleActionPointerDown}
1360-
className={cn(
1361-
"pointer-events-none absolute inset-y-0 right-0 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-2 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
1362-
isWoke && "group-any-hover/sidebar-row:static",
1363-
)}
1364-
>
1365-
<CheckIcon className="size-3" />
1366-
</button>
1355+
<Tooltip>
1356+
<TooltipTrigger
1357+
render={
1358+
<button
1359+
type="button"
1360+
aria-label="Settle thread"
1361+
onClick={handleSettleClick}
1362+
onPointerDown={handleActionPointerDown}
1363+
className={cn(
1364+
"pointer-events-none absolute inset-y-0 right-0 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-2 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
1365+
isWoke && "group-any-hover/sidebar-row:static",
1366+
)}
1367+
/>
1368+
}
1369+
>
1370+
<CheckIcon className="size-3" />
1371+
</TooltipTrigger>
1372+
<TooltipPopup side="top">Settle thread</TooltipPopup>
1373+
</Tooltip>
13671374
)}
13681375
</span>
13691376
)}

0 commit comments

Comments
 (0)