Skip to content

Commit 8c82528

Browse files
saphidclaude
andcommitted
fix(server): Antigravity text generation maps agent errors to fixed text
Copying the ACP error message into TextGenerationError.detail broke the error rule in docs/internals/effect-services.md. A sign-in-required error (ACP code -32000) now shows the fixed Antigravity sign-in text; other agent failures keep the generic detail. The agent's message stays in cause. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a87d9a9 commit 8c82528

2 files changed

Lines changed: 16 additions & 13 deletions

File tree

‎apps/server/src/textGeneration/AntigravityTextGeneration.test.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -452,23 +452,23 @@ it.layer(NodeServices.layer)("AntigravityTextGeneration", (it) => {
452452
}).pipe(Effect.scoped),
453453
);
454454

455-
it.effect("keeps Antigravity's error message when the prompt request fails", () =>
455+
it.effect.each([
456+
{
457+
code: -32000,
458+
detail: "Sign in to Antigravity in Settings before you continue.",
459+
},
460+
{ code: -32603, detail: "Antigravity text generation failed." },
461+
])("maps ACP error $code from the prompt request to a fixed detail", ({ code, detail }) =>
456462
Effect.gen(function* () {
457463
const fixture = yield* makeFixture({
458464
prompt: () =>
459-
Effect.fail(
460-
new AcpRequestError({
461-
code: -32603,
462-
errorMessage: "Model is temporarily unavailable.",
463-
}),
464-
),
465+
Effect.fail(new AcpRequestError({ code, errorMessage: "Raw provider failure text." })),
465466
});
466467
const error = yield* fixture.textGeneration
467468
.generateThreadTitle(fixture.titleInput)
468469
.pipe(Effect.flip);
469-
expect(error.detail).toBe(
470-
"Antigravity text generation failed: Model is temporarily unavailable.",
471-
);
470+
expect(error.detail).toBe(detail);
471+
expect(error.detail).not.toContain("Raw provider failure text.");
472472
yield* fixture.assertCleaned;
473473
}).pipe(Effect.scoped),
474474
);

‎apps/server/src/textGeneration/AntigravityTextGeneration.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@ import { type AcpError, AcpRequestError } from "effect-acp/errors";
1313

1414
import { applyAntigravityAcpModelSelection } from "../provider/acp/AntigravityAcpSupport.ts";
1515
import { removeAntigravitySessionFiles } from "../provider/acp/AntigravitySessionFiles.ts";
16+
import {
17+
ANTIGRAVITY_SIGN_IN_REQUIRED_MESSAGE,
18+
isAntigravitySignInRequiredError,
19+
} from "../provider/antigravityAuthSupport.ts";
1620
import type * as AcpSessionRuntime from "@t3tools/provider-acp/server/AcpSessionRuntime";
1721
import * as TextGenerationOperations from "@t3tools/provider-core/server/textGenerationOperations";
1822

1923
const ANTIGRAVITY_TIMEOUT_MS = 180_000;
2024
const MAX_OUTPUT_CHARS = 128_000;
2125
const isTextGenerationError = Schema.is(TextGenerationError);
22-
const isAcpRequestError = Schema.is(AcpRequestError);
2326
const isProviderSetupError = Schema.is(ProviderSetupError);
2427
const isNativeSessionId = Schema.is(Schema.String.check(Schema.isUUID(4)));
2528
const Configuration = Schema.Record(Schema.String, Schema.Unknown);
@@ -326,8 +329,8 @@ export const makeAntigravityTextGeneration = Effect.fn("makeAntigravityTextGener
326329
operation: input.operation,
327330
detail: isProviderSetupError(cause)
328331
? cause.detail
329-
: isAcpRequestError(cause)
330-
? `Antigravity text generation failed: ${cause.errorMessage}`
332+
: isAntigravitySignInRequiredError(cause)
333+
? ANTIGRAVITY_SIGN_IN_REQUIRED_MESSAGE
331334
: "Antigravity text generation failed.",
332335
cause,
333336
}),

0 commit comments

Comments
 (0)