Skip to content

Commit 8be2408

Browse files
perf(web): tooltips compile with the React Compiler
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent f5cb328 commit 8be2408

2 files changed

Lines changed: 46 additions & 28 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,5 @@ export const REACT_COMPILED_FILES = [
2424
"apps/web/src/hooks/useIncrementalTimelineEntries.ts",
2525
"apps/web/src/hooks/useProactivePanels.ts",
2626
"apps/web/src/hooks/useRightPanelSurfaceClose.ts",
27+
"apps/web/src/components/ui/tooltip.tsx",
2728
] as const;

‎apps/web/src/components/ui/tooltip.tsx‎

Lines changed: 45 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
import { Tooltip as TooltipPrimitive } from "@base-ui/react/tooltip";
2-
import { createContext, use, useEffect, useRef, type ComponentProps, type RefObject } from "react";
2+
import {
3+
createContext,
4+
use,
5+
useEffect,
6+
useRef,
7+
useState,
8+
type ComponentProps,
9+
type RefObject,
10+
} from "react";
311

412
import { cn } from "~/lib/utils";
513
import { useNativeTitlebarHeight } from "~/lib/windowControlsOverlay";
@@ -10,65 +18,74 @@ const COLLISION_PADDING = 5;
1018
const TooltipProvider = TooltipPrimitive.Provider;
1119

1220
type TooltipActionsRef = RefObject<TooltipPrimitive.Root.Actions | null>;
21+
22+
// Context values are frozen to the compiler, so consumers update the hovered
23+
// tooltip through these calls rather than by writing to a shared ref.
24+
function createTooltipHoverTracker() {
25+
let hovered: { trigger: HTMLElement; actionsRef: TooltipActionsRef } | null = null;
26+
return {
27+
hover(trigger: HTMLElement, actionsRef: TooltipActionsRef) {
28+
hovered = { trigger, actionsRef };
29+
},
30+
release(actionsRef: TooltipActionsRef) {
31+
if (hovered?.actionsRef === actionsRef) hovered = null;
32+
},
33+
dismissUnfocused() {
34+
const tooltip = hovered;
35+
if (!tooltip || tooltip.trigger.contains(tooltip.trigger.ownerDocument.activeElement)) {
36+
return;
37+
}
38+
hovered = null;
39+
// Base UI also cancels delayed hover opens through this action.
40+
tooltip.actionsRef.current?.close();
41+
},
42+
};
43+
}
44+
45+
type TooltipHoverTracker = ReturnType<typeof createTooltipHoverTracker>;
1346
const TooltipHoverContext = createContext<TooltipActionsRef | null>(null);
14-
const TooltipScrollContext = createContext<RefObject<{
15-
trigger: HTMLElement;
16-
actionsRef: TooltipActionsRef;
17-
} | null> | null>(null);
47+
const TooltipScrollContext = createContext<TooltipHoverTracker | null>(null);
1848

1949
function TooltipScrollDismissArea({ onScrollCapture, ...props }: ComponentProps<"div">) {
20-
const hovered = useRef<{ trigger: HTMLElement; actionsRef: TooltipActionsRef } | null>(null);
50+
const [tracker] = useState(createTooltipHoverTracker);
2151
return (
22-
<TooltipScrollContext value={hovered}>
52+
<TooltipScrollContext value={tracker}>
2353
<div
2454
{...props}
2555
onScrollCapture={(event) => {
2656
onScrollCapture?.(event);
27-
const tooltip = hovered.current;
28-
if (!tooltip || tooltip.trigger.contains(tooltip.trigger.ownerDocument.activeElement)) {
29-
return;
30-
}
31-
hovered.current = null;
32-
// Base UI also cancels delayed hover opens through this action.
33-
tooltip.actionsRef.current?.close();
57+
tracker.dismissUnfocused();
3458
}}
3559
/>
3660
</TooltipScrollContext>
3761
);
3862
}
3963

4064
function Tooltip<Payload>(props: TooltipPrimitive.Root.Props<Payload>) {
41-
const hovered = use(TooltipScrollContext);
65+
const tracker = use(TooltipScrollContext);
4266
const localActionsRef = useRef<TooltipPrimitive.Root.Actions | null>(null);
4367
const actionsRef = props.actionsRef ?? localActionsRef;
44-
useEffect(
45-
() => () => {
46-
if (hovered?.current?.actionsRef === actionsRef) hovered.current = null;
47-
},
48-
[actionsRef, hovered],
49-
);
68+
useEffect(() => () => tracker?.release(actionsRef), [actionsRef, tracker]);
5069

51-
if (!hovered) return <TooltipPrimitive.Root {...props} />;
70+
if (!tracker) return <TooltipPrimitive.Root {...props} />;
5271
return (
5372
<TooltipHoverContext value={actionsRef}>
5473
<TooltipPrimitive.Root
5574
{...props}
5675
actionsRef={actionsRef}
5776
onOpenChange={(open, details) => {
5877
props.onOpenChange?.(open, details);
59-
if (!open && !details.isCanceled && hovered.current?.actionsRef === actionsRef) {
60-
hovered.current = null;
61-
}
78+
if (!open && !details.isCanceled) tracker.release(actionsRef);
6279
}}
6380
/>
6481
</TooltipHoverContext>
6582
);
6683
}
6784

6885
function TooltipTrigger(props: TooltipPrimitive.Trigger.Props) {
69-
const hovered = use(TooltipScrollContext);
86+
const tracker = use(TooltipScrollContext);
7087
const actionsRef = use(TooltipHoverContext);
71-
if (!hovered || !actionsRef) {
88+
if (!tracker || !actionsRef) {
7289
return <TooltipPrimitive.Trigger data-slot="tooltip-trigger" {...props} />;
7390
}
7491
return (
@@ -77,7 +94,7 @@ function TooltipTrigger(props: TooltipPrimitive.Trigger.Props) {
7794
{...props}
7895
onMouseEnter={(event) => {
7996
props.onMouseEnter?.(event);
80-
hovered.current = { trigger: event.currentTarget, actionsRef };
97+
tracker.hover(event.currentTarget, actionsRef);
8198
}}
8299
/>
83100
);

0 commit comments

Comments
 (0)