Repository navigation
Commit 8b84250
test(server): ACP teardown tests pass on Windows hosts
Fixes #17011. Two AcpAdapterV2 tests fake processGroupPlatform "win32"
but still depend on the real host platform, so they fail on Windows.
"Windows teardown is one-shot explicitly with independent finalizer
cleanup": the runtime's scope finalizer is deliberately independent of
the cached explicit teardown and picks its kill path from
HostProcessPlatform. On a Windows host it calls taskkill through the
stubbed spawner a second time, so the final count is 2, not 1. On Linux
it sends SIGKILL instead. The assertion now expects the finalizer's
extra taskkill only on a Windows host, so Linux runs are unchanged.
"poisons the session when hard teardown defects and blocks replacement
work": the mock agent's running-command fixture runs `bash -c 'sleep
120 & ...'` and publishes $$/$! as host PIDs. With Git Bash those are
MSYS PIDs, so process.kill(pid, 0) never sees them. With WSL's bash.exe
first on PATH, the Windows temp path never receives the PID file, and
the test hangs until its timeout. It now uses the same Linux-host guard
as the other real-process fixture tests in this file.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 0f09627 commit 8b84250
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12328 | 12328 | | |
12329 | 12329 | | |
12330 | 12330 | | |
12331 | | - | |
| 12331 | + | |
| 12332 | + | |
| 12333 | + | |
| 12334 | + | |
| 12335 | + | |
12332 | 12336 | | |
12333 | 12337 | | |
12334 | 12338 | | |
| |||
12437 | 12441 | | |
12438 | 12442 | | |
12439 | 12443 | | |
| 12444 | + | |
12440 | 12445 | | |
12441 | 12446 | | |
12442 | 12447 | | |
| |||
0 commit comments