Skip to content

Commit 8b0f3ea

Browse files
only21milclaude
andcommitted
fix(server): keep scheduled tasks in a stable order across updates
The scheduled task list sorted by updated_at, which toggles, run start/finish and edits all rewrite. Clients render that order as-is, so toggling a task moved it to the top and slid another row's switch under the pointer. Sort by created_at DESC instead. New tasks still appear first, and nothing after creation changes a row's position. listDueTasks keeps its own next_run_at ordering, so dispatch order is unchanged. Fixes #16390 Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 07d38b8 commit 8b0f3ea

2 files changed

Lines changed: 50 additions & 1 deletion

File tree

‎apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,3 +107,50 @@ it.effect("preserves a due run when a save only pads the scheduled hour", () =>
107107
}).pipe(Effect.provide(ScheduledTaskService.layer.pipe(Layer.provide(layerDependencies))));
108108
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
109109
);
110+
111+
it.effect("keeps the task list order when a toggle or edit rewrites updated_at", () =>
112+
Effect.gen(function* () {
113+
yield* TestClock.setTime(Date.parse("2026-07-01T09:00:00.000Z"));
114+
const layerDependencies = Layer.mergeAll(
115+
NodeCrypto.layer,
116+
Scheduler.layer,
117+
Layer.mock(ThreadLaunchService.ThreadLaunchService)({}),
118+
Layer.mock(ThreadManagementService.ThreadManagementService)({}),
119+
Layer.mock(SecretRequests.SecretRequests)({}),
120+
);
121+
yield* Effect.gen(function* () {
122+
const service = yield* ScheduledTaskService.ScheduledTaskService;
123+
const input = (id: string) => ({
124+
id,
125+
title: id,
126+
prompt: "Review the open pull requests.",
127+
enabled: true,
128+
schedule: { type: "interval", everyMs: 60_000 },
129+
projectId: "project-stable-order",
130+
workspaceStrategy: { type: "root" },
131+
modelSelection: { instanceId: "codex", model: "gpt-5.4" },
132+
runtimeMode: "full-access",
133+
interactionMode: "default",
134+
});
135+
const listedIds = service
136+
.list()
137+
.pipe(Effect.map(({ tasks }) => tasks.map((task) => String(task.id))));
138+
139+
const older = yield* service.upsert(yield* decodeUpsertInput(input("scheduled-task:older")));
140+
yield* TestClock.adjust("1 second");
141+
yield* service.upsert(yield* decodeUpsertInput(input("scheduled-task:newer")));
142+
const order = ["scheduled-task:newer", "scheduled-task:older"];
143+
expect(yield* listedIds).toEqual(order);
144+
145+
yield* TestClock.adjust("1 second");
146+
const toggled = yield* service.setEnabled({ id: older.task.id, enabled: false });
147+
expect(toggled.task.updatedAt > older.task.updatedAt).toBe(true);
148+
expect(yield* listedIds).toEqual(order);
149+
150+
yield* TestClock.adjust("1 second");
151+
const edit = { ...input(older.task.id), requireExisting: true, title: "Edited" };
152+
yield* service.upsert(yield* decodeUpsertInput({ ...edit, enabled: false }));
153+
expect(yield* listedIds).toEqual(order);
154+
}).pipe(Effect.provide(ScheduledTaskService.layer.pipe(Layer.provide(layerDependencies))));
155+
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
156+
);

‎apps/server/src/scheduledTasks/ScheduledTaskService.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,9 @@ export const layer = Layer.effect(
403403
webhook_token,
404404
webhook_secret
405405
FROM scheduled_tasks
406-
ORDER BY updated_at DESC, task_id ASC
406+
-- Not updated_at: toggles, runs and edits rewrite it, and clients render
407+
-- this order as-is, so rows would move under the pointer.
408+
ORDER BY created_at DESC, task_id ASC
407409
`;
408410

409411
const listRows = Effect.fn("ScheduledTaskService.listRows")(function* () {

0 commit comments

Comments
 (0)