Skip to content

Commit 896abc2

Browse files
fix(web): hide row actions while dragging
1 parent 82d7376 commit 896abc2

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1556,7 +1556,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
15561556
remain visible AND clickable while the row is hovered. Only
15571557
the time/jump label yields to the settle affordance. */}
15581558
{prBadge}
1559-
{dragDestination ?? (
1559+
{sortable?.isDragging ? (
1560+
dragDestination
1561+
) : (
15601562
<span className="relative ml-auto flex h-6 min-w-8 shrink-0 items-center justify-end">
15611563
<span
15621564
className={cn(
@@ -1709,7 +1711,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
17091711
actions on hover/keyboard focus or while the popover is open. Keeping
17101712
the hidden state out of flow lets the project label reclaim
17111713
space without either state overlapping it. */}
1712-
{dragDestination ?? (
1714+
{sortable?.isDragging ? (
1715+
dragDestination
1716+
) : (
17131717
<span className="group/sidebar-status-slot relative ml-auto flex h-5 min-w-8 shrink-0 items-stretch justify-end text-xs">
17141718
{/* Read-only status labels yield to the hover actions. Woke is
17151719
itself an action, so it stays pointer-enabled and visible

‎docs/user/thread-sidebar.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,10 @@ shelf, which wakes it, but threads cannot be dragged into the shelf because snoo
5252
time. Dragging a pinned thread out of the pinned section does not ask for unpin confirmation.
5353
Pinned and active boundary labels appear only while dragging, without moving the rows. The
5454
destination boundary highlights. When you cross into another section, the dragged thread shows
55-
its destination, such as **→ Active**. Its pin marker hides during the drag. Reordering within
56-
the same section does not show a destination badge. When there are no pins, drag to the top edge
57-
to pin a thread. Section labels also identify empty sections and a collapsed settled shelf.
55+
its destination, such as **→ Active**. Its usual pin, status, and hover actions hide during the
56+
drag. Reordering within the same section does not show a destination badge. When there are no
57+
pins, drag to the top edge to pin a thread. Section labels also identify empty sections and a
58+
collapsed settled shelf.
5859

5960
Drag within the pinned or active section to change its order. Other rows slide aside to show the
6061
spot where the thread will land. Drops into either section keep the position you choose. On

0 commit comments

Comments
 (0)