Skip to content

Commit 8947aff

Browse files
committed
fix(web): align radio menu item labels
1 parent 5ef4988 commit 8947aff

2 files changed

Lines changed: 24 additions & 1 deletion

File tree

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
import { renderToStaticMarkup } from "react-dom/server";
2+
import { describe, expect, it } from "vite-plus/test";
3+
4+
import { Menu, MenuRadioGroup, MenuRadioItem } from "./menu";
5+
6+
describe("menu radio item geometry", () => {
7+
it("keeps radio-item icons on the same text grid as menu items", () => {
8+
const html = renderToStaticMarkup(
9+
<Menu>
10+
<MenuRadioGroup value="merge">
11+
<MenuRadioItem value="merge">
12+
<span className="flex items-center gap-2">
13+
<svg aria-hidden className="size-3.5" />
14+
<span>Merge</span>
15+
</span>
16+
</MenuRadioItem>
17+
</MenuRadioGroup>
18+
</Menu>,
19+
);
20+
21+
expect(html).toContain("-mx-0.5");
22+
});
23+
});

‎apps/web/src/components/ui/menu.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ function MenuRadioItem({
158158
return (
159159
<MenuPrimitive.RadioItem
160160
className={cn(
161-
"flex min-h-8 in-data-[side=none]:min-w-[calc(var(--anchor-width)+1.25rem)] cursor-pointer items-center rounded-sm px-2 py-1 text-base text-foreground outline-none data-checked:bg-foreground/[0.08] data-disabled:pointer-events-none data-disabled:cursor-not-allowed data-highlighted:bg-accent data-highlighted:text-accent-foreground data-disabled:opacity-64 sm:min-h-7 sm:text-sm [&_svg:not([class*='size-'])]:size-4.5 sm:[&_svg:not([class*='size-'])]:size-4 [&_svg]:pointer-events-none [&_svg]:shrink-0",
161+
"[&_svg]:-mx-0.5 flex min-h-8 in-data-[side=none]:min-w-[calc(var(--anchor-width)+1.25rem)] cursor-pointer items-center rounded-sm px-2 py-1 text-base text-foreground outline-none data-checked:bg-foreground/[0.08] data-disabled:pointer-events-none data-disabled:cursor-not-allowed data-highlighted:bg-accent data-highlighted:text-accent-foreground data-disabled:opacity-64 sm:min-h-7 sm:text-sm [&_svg:not([class*='size-'])]:size-4.5 sm:[&_svg:not([class*='size-'])]:size-4 [&_svg]:pointer-events-none [&_svg]:shrink-0",
162162
className,
163163
)}
164164
data-slot="menu-radio-item"

0 commit comments

Comments
 (0)