@@ -90,6 +90,7 @@ vi.mock("./uuid", () => ({ uuidv4: () => "attachment-id" }));
9090
9191import {
9292 persistComposerAttachmentFile ,
93+ isComposerImageAttachment ,
9394 pickComposerFiles ,
9495 pickComposerImages ,
9596 pickComposerMedia ,
@@ -108,6 +109,7 @@ describe("composer file attachments", () => {
108109 mocks . open . mockReset ( ) ;
109110 mocks . size . mockReset ( ) ;
110111 mocks . readBase64 . mockReset ( ) ;
112+ mocks . manipulate . mockReset ( ) ;
111113 mocks . size . mockImplementation ( ( uri : string ) => ( uri . startsWith ( "content:" ) ? null : 42 ) ) ;
112114 } ) ;
113115
@@ -442,6 +444,169 @@ describe("composer file attachments", () => {
442444 } ) ;
443445 } ) ;
444446
447+ describe ( "images chosen through the file picker" , ( ) => {
448+ it . each ( [
449+ { name : "photo.bin" , mimeType : "image/jpeg" , expected : "image/jpeg" } ,
450+ { name : "photo.png" , mimeType : "image/png" , expected : "image/png" } ,
451+ { name : "photo.gif" , mimeType : "image/gif" , expected : "image/gif" } ,
452+ { name : "photo.webp" , mimeType : "image/webp" , expected : "image/webp" } ,
453+ { name : "photo.JPG" , mimeType : undefined , expected : "image/jpeg" } ,
454+ { name : "photo.PNG" , mimeType : "application/octet-stream" , expected : "image/png" } ,
455+ { name : "photo.gif" , mimeType : "binary/octet-stream" , expected : "image/gif" } ,
456+ { name : "photo.webp" , mimeType : "application/unknown" , expected : "image/webp" } ,
457+ { name : "photo.jpg" , mimeType : "IMAGE/PNG; charset=binary" , expected : "image/png" } ,
458+ ] ) ( "prepares $name ($mimeType) as $expected" , async ( { name, mimeType, expected } ) => {
459+ mocks . pickFile . mockResolvedValue ( {
460+ canceled : false ,
461+ assets : [ { uri : `file:///picker/${ name } ` , name, mimeType, size : 3 } ] ,
462+ } ) ;
463+ mocks . size . mockReturnValue ( 3 ) ;
464+ mocks . readBase64 . mockResolvedValue ( "YWJj" ) ;
465+
466+ const result = await pickComposerFiles ( { existingCount : 0 } ) ;
467+
468+ expect ( result ) . toEqual ( {
469+ files : [
470+ {
471+ id : "attachment-id" ,
472+ type : "image" ,
473+ name,
474+ mimeType : expected ,
475+ sizeBytes : 3 ,
476+ dataUrl : `data:${ expected } ;base64,YWJj` ,
477+ previewUri : `data:${ expected } ;base64,YWJj` ,
478+ } ,
479+ ] ,
480+ error : null ,
481+ } ) ;
482+ expect ( mocks . manipulate ) . not . toHaveBeenCalled ( ) ;
483+ expect ( mocks . delete ) . toHaveBeenCalledWith (
484+ `file:///documents/t3-composer-attachments/attachment-id-${ name } ` ,
485+ ) ;
486+ } ) ;
487+
488+ it . each ( [
489+ { name : "diagram.svg" , mimeType : "image/svg+xml" } ,
490+ { name : "photo.heic" , mimeType : "image/heic" } ,
491+ { name : "photo.tiff" , mimeType : "image/tiff" } ,
492+ { name : "photo.png" , mimeType : "application/pdf" } ,
493+ { name : "unknown.bin" , mimeType : "application/octet-stream" } ,
494+ ] ) ( "keeps $name ($mimeType) as a file" , async ( { name, mimeType } ) => {
495+ mocks . pickFile . mockResolvedValue ( {
496+ canceled : false ,
497+ assets : [ { uri : `file:///picker/${ name } ` , name, mimeType, size : 42 } ] ,
498+ } ) ;
499+
500+ const result = await pickComposerFiles ( { existingCount : 0 } ) ;
501+
502+ expect ( result . error ) . toBeNull ( ) ;
503+ expect ( result . files ) . toEqual ( [ expect . objectContaining ( { type : "file" , name, mimeType } ) ] ) ;
504+ expect ( mocks . readBase64 ) . not . toHaveBeenCalled ( ) ;
505+ expect ( mocks . manipulate ) . not . toHaveBeenCalled ( ) ;
506+ expect ( mocks . delete ) . not . toHaveBeenCalled ( ) ;
507+ } ) ;
508+
509+ it . each ( [ PROVIDER_SEND_TURN_MAX_IMAGE_BYTES , PROVIDER_SEND_TURN_MAX_IMAGE_BYTES + 1 ] ) (
510+ "classifies a measured %s byte PNG independently of picker metadata and file limit" ,
511+ async ( size ) => {
512+ mocks . pickFile . mockResolvedValue ( {
513+ canceled : false ,
514+ assets : [
515+ { uri : "file:///picker/photo.png" , name : "photo.png" , mimeType : "image/png" , size : 1 } ,
516+ ] ,
517+ } ) ;
518+ mocks . size . mockReturnValue ( size ) ;
519+ mocks . readBase64 . mockResolvedValue ( "YWJj" ) ;
520+
521+ const result = await pickComposerFiles ( {
522+ existingCount : 0 ,
523+ maxBytes : size > PROVIDER_SEND_TURN_MAX_IMAGE_BYTES ? size : 1024 ,
524+ } ) ;
525+
526+ expect ( result . error ) . toBeNull ( ) ;
527+ expect ( result . files [ 0 ] ?. type ) . toBe (
528+ size > PROVIDER_SEND_TURN_MAX_IMAGE_BYTES ? "file" : "image" ,
529+ ) ;
530+ expect ( isComposerImageAttachment ( result . files [ 0 ] ! ) ) . toBe (
531+ size <= PROVIDER_SEND_TURN_MAX_IMAGE_BYTES ,
532+ ) ;
533+ expect ( mocks . readBase64 ) . toHaveBeenCalledTimes (
534+ size > PROVIDER_SEND_TURN_MAX_IMAGE_BYTES ? 0 : 1 ,
535+ ) ;
536+ } ,
537+ ) ;
538+
539+ it . each ( [ false , true ] ) ( "fits a large PNG with oversized output: %s" , async ( oversized ) => {
540+ const header = Buffer . alloc ( 24 ) ;
541+ Buffer . from ( [ 0x89 , 0x50 , 0x4e , 0x47 , 0x0d , 0x0a , 0x1a , 0x0a ] ) . copy ( header ) ;
542+ header . write ( "IHDR" , 12 ) ;
543+ header . writeUInt32BE ( 4000 , 16 ) ;
544+ header . writeUInt32BE ( 3000 , 20 ) ;
545+ const original = header . toString ( "base64" ) ;
546+ mocks . readBase64 . mockResolvedValue ( original ) ;
547+ const resize = vi . fn ( ) ;
548+ const renderAsync = vi . fn ( async ( ) => ( {
549+ width : 4000 ,
550+ height : 3000 ,
551+ release : vi . fn ( ) ,
552+ saveAsync : vi . fn ( async ( ) => ( {
553+ uri : "file:///cache/fitted.png" ,
554+ base64 : oversized
555+ ? Buffer . alloc ( PROVIDER_SEND_TURN_MAX_IMAGE_BYTES + 1 ) . toString ( "base64" )
556+ : "YWJj" ,
557+ } ) ) ,
558+ } ) ) ;
559+ mocks . manipulate . mockImplementation ( ( ) => {
560+ const context = {
561+ resize : ( size : unknown ) => {
562+ resize ( size ) ;
563+ return context ;
564+ } ,
565+ renderAsync,
566+ } ;
567+ return context ;
568+ } ) ;
569+ mocks . pickFile . mockResolvedValue ( {
570+ canceled : false ,
571+ assets : [ { uri : "file:///picker/photo.png" , name : "photo.png" , mimeType : "image/png" } ] ,
572+ } ) ;
573+
574+ const result = await pickComposerFiles ( { existingCount : 0 } ) ;
575+
576+ expect ( resize ) . toHaveBeenCalledWith ( { width : 2000 , height : 1500 } ) ;
577+ expect ( result ) . toEqual ( {
578+ files : [
579+ expect . objectContaining ( {
580+ type : "image" ,
581+ mimeType : "image/png" ,
582+ sizeBytes : oversized ? header . length : 3 ,
583+ dataUrl : `data:image/png;base64,${ oversized ? original : "YWJj" } ` ,
584+ previewUri : oversized
585+ ? `data:image/png;base64,${ original } `
586+ : "file:///cache/fitted.png" ,
587+ } ) ,
588+ ] ,
589+ error : null ,
590+ } ) ;
591+ } ) ;
592+
593+ it ( "releases the owned copy when reading an image fails" , async ( ) => {
594+ mocks . pickFile . mockResolvedValue ( {
595+ canceled : false ,
596+ assets : [ { uri : "file:///picker/photo.png" , name : "photo.png" , mimeType : "image/png" } ] ,
597+ } ) ;
598+ mocks . readBase64 . mockRejectedValue ( new Error ( "unreadable image" ) ) ;
599+
600+ expect ( await pickComposerFiles ( { existingCount : 0 } ) ) . toEqual ( {
601+ files : [ ] ,
602+ error : "unreadable image" ,
603+ } ) ;
604+ expect ( mocks . delete ) . toHaveBeenCalledWith (
605+ "file:///documents/t3-composer-attachments/attachment-id-photo.png" ,
606+ ) ;
607+ } ) ;
608+ } ) ;
609+
445610 it ( "copies picked files into app-owned storage without loading their contents" , async ( ) => {
446611 mocks . pickFile . mockResolvedValue ( {
447612 canceled : false ,
0 commit comments