@@ -137,12 +137,11 @@ export function newestPullRequestObservation(
137137}
138138
139139function observePullRequestSummary (
140- environmentId : EnvironmentId ,
141- reference : PullRequestRef ,
140+ key : string ,
142141 summary : PullRequestSummary ,
143142 observedAt : number ,
144143) : void {
145- const atom = observedPullRequestSummaryAtom ( pullRequestSummaryKey ( environmentId , reference ) ) ;
144+ const atom = observedPullRequestSummaryAtom ( key ) ;
146145 appAtomRegistry . modify ( atom , ( previous ) => {
147146 const next = newestPullRequestObservation ( previous , { summary, observedAt } ) ;
148147 return next === previous ? [ false , previous ] : [ true , next ] ;
@@ -216,11 +215,11 @@ export function useSharedPullRequestSummary(
216215 : savedPullRequestKey ( environmentId , reference ) ,
217216 ) ,
218217 ) ;
218+ // Keyed structurally so a fresh reference object for the same pull request is a no-op.
219219 useLayoutEffect ( ( ) => {
220- if ( environmentId === null || reference === null || current === null || observedAt === null )
221- return ;
222- observePullRequestSummary ( environmentId , reference , current , observedAt ) ;
223- } , [ current , environmentId , reference , observedAt ] ) ;
220+ if ( key === "none" || current === null || observedAt === null ) return ;
221+ observePullRequestSummary ( key , current , observedAt ) ;
222+ } , [ current , key , observedAt ] ) ;
224223 const summary =
225224 newestPullRequestObservation (
226225 observed ,
@@ -343,13 +342,12 @@ export function usePullRequestList(
343342 for ( const [ environmentId , answer , observedAt ] of query . observations ) {
344343 for ( const entry of answer . entries ) {
345344 observePullRequestSummary (
346- environmentId ,
347- {
345+ pullRequestSummaryKey ( environmentId , {
348346 projectId : entry . projectId ,
349347 host : entry . host ,
350348 repository : entry . repository ,
351349 number : entry . number ,
352- } ,
350+ } ) ,
353351 pullRequestListEntryToSummary ( entry ) ,
354352 observedAt ,
355353 ) ;
0 commit comments