Skip to content

Commit 8575c6d

Browse files
t3dotggclaude
andcommitted
test(server): threads leave the shared Codex session on their next turn
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 6b9bb04 commit 8575c6d

1 file changed

Lines changed: 90 additions & 0 deletions

File tree

‎apps/server/src/orchestration-v2/SelectionRestart.integration.test.ts‎

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import * as Orchestrator from "./Orchestrator.ts";
3131
import * as ProviderAdapterRegistry from "./ProviderAdapterRegistry.ts";
3232
import * as ProviderReplayHarness from "./testkit/ProviderReplayHarness.ts";
3333
import { checkpointWorkspace } from "@t3tools/provider-testing/replayWorkspace";
34+
import * as IdAllocator from "@t3tools/provider-core/server/IdAllocator";
3435
import * as ProviderAdapter from "@t3tools/provider-core/server/ProviderAdapter";
3536

3637
const driver = ProviderDriverKind.make("codex");
@@ -443,6 +444,95 @@ it.live("retries a failed selection restart session open before completing", ()
443444
),
444445
);
445446

447+
it.live("moves a thread off its provider's shared session once sessions are per thread", () =>
448+
Effect.scoped(
449+
Effect.gen(function* () {
450+
const cwd = yield* checkpointWorkspace("selection-restart-shared-migration");
451+
const threadId = ThreadId.make("thread:selection-restart-shared-migration");
452+
const state = yield* Ref.make<RestartAdapterState>({
453+
activeTurn: null,
454+
opened: [],
455+
started: [],
456+
closedSessionCount: 0,
457+
failedReplacementOpen: true,
458+
});
459+
let capabilities = pooledCapabilities;
460+
const adapter = makeRestartAdapter(state);
461+
const layerRegistry = ProviderAdapterRegistry.layerSingle({
462+
...adapter,
463+
getCapabilities: () => Effect.sync(() => capabilities),
464+
});
465+
const sharedSessionId = IdAllocator.derive.providerSession({ providerInstanceId });
466+
467+
const sessionIds = yield* Effect.gen(function* () {
468+
const orchestrator = yield* Orchestrator.OrchestratorV2;
469+
const worker = yield* EffectWorker.OrchestrationEffectWorkerV2;
470+
const eventSink = yield* EventSink.EventSinkV2;
471+
const sendAndComplete = Effect.fn("sendAndComplete")(function* (text: string) {
472+
const completed = yield* eventSink
473+
.stream({ threadId, afterSequence: yield* eventSink.latestSequence({ threadId }) })
474+
.pipe(
475+
Stream.map((stored) => stored.event),
476+
Stream.filter(
477+
(event) => event.type === "run.updated" && event.payload.status === "completed",
478+
),
479+
Stream.take(1),
480+
Stream.runDrain,
481+
Effect.forkScoped,
482+
);
483+
yield* orchestrator.dispatch({
484+
type: "message.dispatch",
485+
createdBy: "user",
486+
creationSource: "web",
487+
commandId: CommandId.make(`command:selection-restart-shared-migration:${text}`),
488+
threadId,
489+
messageId: MessageId.make(`message:selection-restart-shared-migration:${text}`),
490+
text,
491+
attachments: [],
492+
modelSelection: replacementSelection,
493+
dispatchMode: { type: "start_immediately" },
494+
});
495+
yield* Fiber.join(completed);
496+
yield* worker.drain();
497+
return (yield* orchestrator.getThreadProjection(threadId)).providerThreads[0]
498+
?.providerSessionId;
499+
});
500+
501+
yield* orchestrator.dispatch({
502+
type: "thread.create",
503+
createdBy: "user",
504+
creationSource: "web",
505+
commandId: CommandId.make("command:selection-restart-shared-migration:create"),
506+
threadId,
507+
projectId: ProjectId.make("project:selection-restart"),
508+
title: "Shared session migration",
509+
modelSelection: replacementSelection,
510+
runtimeMode: "full-access",
511+
interactionMode: "default",
512+
branch: null,
513+
worktreePath: cwd,
514+
});
515+
const before = yield* sendAndComplete("first");
516+
capabilities = exclusiveCapabilities;
517+
const after = yield* sendAndComplete("second");
518+
return { before, after };
519+
}).pipe(
520+
Effect.provide(
521+
ProviderReplayHarness.layerWithRegistry(
522+
{ name: "selection-restart-shared-migration" },
523+
layerRegistry,
524+
),
525+
),
526+
);
527+
528+
assert.equal(sessionIds.before, sharedSessionId);
529+
assert.isDefined(sessionIds.after);
530+
assert.notEqual(sessionIds.after, sharedSessionId);
531+
assert.lengthOf((yield* Ref.get(state)).opened, 2);
532+
}),
533+
),
534+
);
535+
446536
it.live(
447537
"restarts the live session on a model change when a newer stopped session record exists",
448538
() =>

0 commit comments

Comments
 (0)