Skip to content

Commit 84346fb

Browse files
fix(web): hide row actions while dragging
1 parent 7f182a7 commit 84346fb

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1565,7 +1565,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
15651565
remain visible AND clickable while the row is hovered. Only
15661566
the time/jump label yields to the settle affordance. */}
15671567
{prBadge}
1568-
{dragDestination ?? (
1568+
{sortable?.isDragging ? (
1569+
dragDestination
1570+
) : (
15691571
<span className="relative ml-auto flex h-6 min-w-8 shrink-0 items-center justify-end">
15701572
<span
15711573
className={cn(
@@ -1718,7 +1720,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
17181720
actions on hover/keyboard focus or while the popover is open. Keeping
17191721
the hidden state out of flow lets the project label reclaim
17201722
space without either state overlapping it. */}
1721-
{dragDestination ?? (
1723+
{sortable?.isDragging ? (
1724+
dragDestination
1725+
) : (
17221726
<span className="group/sidebar-status-slot relative ml-auto flex h-5 min-w-8 shrink-0 items-stretch justify-end text-xs">
17231727
{/* Read-only status labels yield to the hover actions. Woke is
17241728
itself an action, so it stays pointer-enabled and visible

‎docs/user/thread-sidebar.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ shelf, which wakes it, but threads cannot be dragged into the shelf because snoo
3434
time. Dragging a pinned thread out of the pinned section does not ask for unpin confirmation.
3535
Pinned and active boundary labels appear only while dragging, without moving the rows. The
3636
destination boundary highlights. When you cross into another section, the dragged thread shows
37-
its destination, such as **→ Active**. Its pin marker hides during the drag. Reordering within
38-
the same section does not show a destination badge. When there are no pins, drag to the top edge
39-
to pin a thread. Section labels also identify empty sections and a collapsed settled shelf.
37+
its destination, such as **→ Active**. Its usual pin, status, and hover actions hide during the
38+
drag. Reordering within the same section does not show a destination badge. When there are no
39+
pins, drag to the top edge to pin a thread. Section labels also identify empty sections and a
40+
collapsed settled shelf.
4041

4142
Drag within the pinned or active section to change its order. Other rows slide aside to show the
4243
spot where the thread will land. Drops into either section keep the position you choose. On

0 commit comments

Comments
 (0)