Skip to content

Commit 83964f3

Browse files
committed
fix(muse): skip a blank subagent id when listing a background child
1 parent 8cf8dba commit 83964f3

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎packages/provider-muse/src/server/adapter.test.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1585,15 +1585,16 @@ describe("MuseAdapterV2", () => {
15851585
const { nativeId } = yield* startConversation(harness, fake);
15861586
const revisions = [
15871587
{ revision: 1, status: "inProgress" },
1588-
{ revision: 2, status: "inProgress", subagentId: "subagent-1" },
1588+
{ revision: 2, status: "inProgress", subagentId: "" },
1589+
{ revision: 3, status: "inProgress", subagentId: "subagent-1" },
15891590
{
1590-
revision: 3,
1591+
revision: 4,
15911592
status: "inProgress",
15921593
subagentId: "subagent-1",
15931594
childSessionId: "child-session-1",
15941595
},
15951596
{
1596-
revision: 4,
1597+
revision: 5,
15971598
status: "completed",
15981599
subagentId: "subagent-1",
15991600
childSessionId: "child-session-1",
@@ -1621,6 +1622,7 @@ describe("MuseAdapterV2", () => {
16211622
});
16221623
}
16231624
assert.deepStrictEqual(listed, [
1625+
{ nativeId: "sub-1", roster: ["sub-1"] },
16241626
{ nativeId: "sub-1", roster: ["sub-1"] },
16251627
{ nativeId: "subagent-1", roster: ["subagent-1"] },
16261628
{ nativeId: "child-session-1", roster: ["child-session-1"] },

‎packages/provider-muse/src/server/adapter.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ const nativeRef = (nativeId: string) => ({
254254
});
255255
/** The roster lists a child under its turn item's native id, so readers can pair the two. */
256256
const backgroundTaskId = (item: MuseItem) =>
257-
item.kind === "subagent" ? item.childSessionId || (item.subagentId ?? item.itemId) : item.itemId;
257+
item.kind === "subagent" ? item.childSessionId || item.subagentId || item.itemId : item.itemId;
258258
const recordSchema = Schema.Record(Schema.String, Schema.Unknown);
259259
const INFORMATIONAL_NOTIFICATIONS = new Set([
260260
"session/contextUsage",

0 commit comments

Comments
 (0)