Skip to content

Commit 835e42f

Browse files
perf(web): the sidebar chrome compiles without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit 835e42f

2 files changed

Lines changed: 17 additions & 19 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/components/sidebar/SidebarChrome.tsx",
99100
] as const;

‎apps/web/src/components/sidebar/SidebarChrome.tsx‎

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ArrowLeftIcon, ChartNoAxesColumnIcon, SettingsIcon } from "lucide-react";
22
import type { ReactNode } from "react";
3-
import { memo, useCallback } from "react";
3+
import { memo } from "react";
44
import { Link, useLocation, useNavigate } from "@tanstack/react-router";
55

66
import { useEnvironmentIdentificationMode } from "../../hooks/useSettings";
@@ -81,14 +81,11 @@ export function SidebarBrandWidthProbe({
8181
}: {
8282
onWidthChange: (width: number) => void;
8383
}) {
84-
const observeWidth = useCallback(
85-
(probe: HTMLDivElement) => {
86-
return observeResize(probe, ([entry]) => {
87-
if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth);
88-
});
89-
},
90-
[onWidthChange],
91-
);
84+
const observeWidth = (probe: HTMLDivElement) => {
85+
return observeResize(probe, ([entry]) => {
86+
if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth);
87+
});
88+
};
9289

9390
return (
9491
<div
@@ -167,34 +164,34 @@ export const SidebarUtilityMenu = memo(function SidebarUtilityMenu() {
167164
select: (location) => isSidebarUtilityPage(location.pathname),
168165
});
169166
const pullRequestsSupported = usePullRequestsSupported();
170-
const closeMobileSidebar = useCallback(() => {
167+
const closeMobileSidebar = () => {
171168
if (isMobile) {
172169
setOpenMobile(false);
173170
}
174-
}, [isMobile, setOpenMobile]);
175-
const handlePullRequestsClick = useCallback(() => {
171+
};
172+
const handlePullRequestsClick = () => {
176173
closeMobileSidebar();
177174
void navigate({
178175
to: "/pull-requests",
179176
search: readPullRequestListPreferences(),
180177
});
181-
}, [closeMobileSidebar, navigate]);
182-
const handleSettingsClick = useCallback(() => {
178+
};
179+
const handleSettingsClick = () => {
183180
closeMobileSidebar();
184181
void navigate({ to: "/settings" });
185-
}, [closeMobileSidebar, navigate]);
182+
};
186183

187-
const handleUsageClick = useCallback(() => {
184+
const handleUsageClick = () => {
188185
if (isMobile) {
189186
setOpenMobile(false);
190187
}
191188
void navigate({ to: "/usage" });
192-
}, [isMobile, navigate, setOpenMobile]);
189+
};
193190

194-
const handleBackClick = useCallback(() => {
191+
const handleBackClick = () => {
195192
closeMobileSidebar();
196193
void navigateToMainApp();
197-
}, [closeMobileSidebar, navigateToMainApp]);
194+
};
198195

199196
return (
200197
<SidebarMenu className="flex-row items-center">

0 commit comments

Comments
 (0)