@@ -5,6 +5,9 @@ import * as Option from "effect/Option";
55import { AsyncResult , Atom , AtomRegistry } from "effect/unstable/reactivity" ;
66import { vi } from "vite-plus/test" ;
77import { ProviderInstanceId } from "@t3tools/contracts" ;
8+ import { RegistryContext , useAtomSet } from "@effect/atom-react" ;
9+ import { createElement } from "react" ;
10+ import { renderToString } from "react-dom/server" ;
811
912vi . mock ( "expo-secure-store" , ( ) => ( {
1013 getItemAsync : vi . fn ( ) ,
@@ -125,12 +128,16 @@ describe("mobile preferences state", () => {
125128 } ) ,
126129 ) ;
127130
128- it . effect ( "keeps both favorites when updates are sent before a render" , ( ) =>
131+ it . effect ( "keeps both favorites when the React setter sends updates before a render" , ( ) =>
129132 Effect . gen ( function * ( ) {
130133 let persisted : Preferences = { modelFavorites : [ ] } ;
131134 const state = makePreferencesState ( {
132135 load : Effect . succeed ( persisted ) ,
133- savePatch : ( ) => Effect . die ( new Error ( "Favorite updates must use a transform." ) ) ,
136+ savePatch : ( patch ) =>
137+ Effect . sync ( ( ) => {
138+ persisted = { ...persisted , ...patch } ;
139+ return persisted ;
140+ } ) ,
134141 update : ( transform ) =>
135142 Effect . sync ( ( ) => {
136143 persisted = { ...persisted , ...transform ( persisted ) } ;
@@ -142,13 +149,31 @@ describe("mobile preferences state", () => {
142149 const unmountUpdate = registry . mount ( state . updatePreferencesAtom ) ;
143150 yield * AtomRegistry . getResult ( registry , state . preferencesAtom , { suspendOnWaiting : true } ) ;
144151
152+ function useSavePreferences ( ) {
153+ return useAtomSet ( state . updatePreferencesAtom ) ;
154+ }
155+ const setters : Array < ReturnType < typeof useSavePreferences > > = [ ] ;
156+ function CaptureSetter ( ) {
157+ setters . push ( useSavePreferences ( ) ) ;
158+ return null ;
159+ }
160+ // Exercise the real React setter, which treats bare functions as updates
161+ // to the atom's read value. Direct registry.set calls bypass that behavior.
162+ renderToString (
163+ createElement ( RegistryContext . Provider , { value : registry } , createElement ( CaptureSetter ) ) ,
164+ ) ;
165+ const savePreferences = setters [ 0 ] ! ;
145166 const provider = ProviderInstanceId . make ( "codex" ) ;
146- registry . set ( state . updatePreferencesAtom , ( current ) => ( {
147- modelFavorites : [ ...( current . modelFavorites ?? [ ] ) , { provider, model : "astra" } ] ,
148- } ) ) ;
149- registry . set ( state . updatePreferencesAtom , ( current ) => ( {
150- modelFavorites : [ ...( current . modelFavorites ?? [ ] ) , { provider, model : "sol" } ] ,
151- } ) ) ;
167+ savePreferences ( {
168+ transform : ( current ) => ( {
169+ modelFavorites : [ ...( current . modelFavorites ?? [ ] ) , { provider, model : "astra" } ] ,
170+ } ) ,
171+ } ) ;
172+ savePreferences ( {
173+ transform : ( current ) => ( {
174+ modelFavorites : [ ...( current . modelFavorites ?? [ ] ) , { provider, model : "sol" } ] ,
175+ } ) ,
176+ } ) ;
152177 yield * AtomRegistry . getResult ( registry , state . updatePreferencesAtom , {
153178 suspendOnWaiting : true ,
154179 } ) ;
@@ -158,6 +183,18 @@ describe("mobile preferences state", () => {
158183 { provider, model : "sol" } ,
159184 ] ) ;
160185
186+ savePreferences ( {
187+ transform : ( current ) => ( {
188+ modelFavorites : ( current . modelFavorites ?? [ ] ) . filter (
189+ ( favorite ) => favorite . model !== "astra" ,
190+ ) ,
191+ } ) ,
192+ } ) ;
193+ yield * AtomRegistry . getResult ( registry , state . updatePreferencesAtom , {
194+ suspendOnWaiting : true ,
195+ } ) ;
196+ expect ( persisted . modelFavorites ) . toEqual ( [ { provider, model : "sol" } ] ) ;
197+
161198 unmountUpdate ( ) ;
162199 unmountPreferences ( ) ;
163200 registry . dispose ( ) ;
0 commit comments