Skip to content

Commit 817c78c

Browse files
perf(web): the model picker compiles without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit 817c78c

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/components/chat/ProviderModelPicker.tsx",
99100
] as const;

‎apps/web/src/components/chat/ProviderModelPicker.tsx‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
type ProviderDriverKind,
66
type ResolvedKeybindingsConfig,
77
} from "@t3tools/contracts";
8-
import { memo, useEffect, useMemo, useState } from "react";
8+
import { memo, useEffect, useState } from "react";
99
import { Badge } from "../ui/badge";
1010
import { Popover, PopoverPopup, PopoverTrigger } from "../ui/popover";
1111
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
@@ -59,11 +59,8 @@ export const ProviderModelPicker = memo(function ProviderModelPicker(props: {
5959
const isMenuOpen = props.open ?? uncontrolledIsMenuOpen;
6060
const size = props.size ?? "sm";
6161

62-
const activeEntry = useMemo(() => {
63-
return (
64-
props.instanceEntries.find((entry) => entry.instanceId === props.activeInstanceId) ?? null
65-
);
66-
}, [props.activeInstanceId, props.instanceEntries]);
62+
const activeEntry =
63+
props.instanceEntries.find((entry) => entry.instanceId === props.activeInstanceId) ?? null;
6764

6865
const activeInstanceId = props.activeInstanceId;
6966
const selectedInstanceOptions = props.modelOptionsByInstance.get(activeInstanceId) ?? [];

0 commit comments

Comments
 (0)