Skip to content

Commit 80d7c66

Browse files
ci: stop uploading per-shard test cache reports
Server test shards uploaded a test-cache JSON artifact that nothing downloads. When GitHub's artifact API returned HTML errors, upload-artifact retried with backoff and held each shard for minutes. test:cached already writes the same numbers to the step summary, so drop the upload and the --report option. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent c8e8b58 commit 80d7c66

2 files changed

Lines changed: 2 additions & 23 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -489,15 +489,7 @@ jobs:
489489
run: >-
490490
vp run test:cached -- --shard ${{ matrix.shard }}/${{ strategy.job-total }}
491491
--uncached apps/server/integration/transferBudgetV2.integration.test.ts
492-
--verify-hits 1 --report "${{ runner.temp }}/test-cache-${{ matrix.shard }}.json" apps/server
493-
494-
- name: Upload test cache measurements
495-
if: always() && steps.changes.outputs.test_server != 'false'
496-
uses: actions/upload-artifact@v7
497-
with:
498-
name: test-cache-${{ matrix.shard }}
499-
path: ${{ runner.temp }}/test-cache-${{ matrix.shard }}.json
500-
if-no-files-found: error
492+
--verify-hits 1 apps/server
501493
502494
# integration/transferBudgetV2.integration.test.ts writes the report; exactly one shard
503495
# produces these files. Gating the upload on their presence keeps a

‎scripts/test-cached.ts‎

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ const { values, positionals } = NodeUtil.parseArgs({
1616
"group-size": { type: "string", default: "1" },
1717
concurrency: { type: "string", default: "1" },
1818
shard: { type: "string" },
19-
report: { type: "string" },
2019
"verify-hits": { type: "string", default: "0" },
2120
uncached: { type: "string", multiple: true, default: [] },
2221
help: { type: "boolean", short: "h" },
@@ -88,7 +87,7 @@ const result = NodeChildProcess.spawnSync(
8887
if (result.error) throw result.error;
8988
const cacheRunMs = performance.now() - started;
9089
process.exitCode = result.status ?? 1;
91-
if (values.report || verifyHits > 0) {
90+
if (verifyHits > 0) {
9291
const cacheRoot =
9392
process.env.VITE_CACHE_PATH || NodePath.join(root, "node_modules/.vite/task-cache");
9493
const summaryFiles = NodeFS.readdirSync(cacheRoot, { withFileTypes: true })
@@ -131,18 +130,6 @@ if (values.report || verifyHits > 0) {
131130
if (audit.status !== 0) process.exitCode = audit.status ?? 1;
132131
}
133132
}
134-
const report = {
135-
shard: values.shard,
136-
files,
137-
cacheRunMs,
138-
exitCode: result.status,
139-
summary,
140-
verification,
141-
};
142-
if (values.report) {
143-
NodeFS.mkdirSync(NodePath.dirname(values.report), { recursive: true });
144-
NodeFS.writeFileSync(values.report, `${JSON.stringify(report, null, 2)}\n`);
145-
}
146133
if (process.env.GITHUB_STEP_SUMMARY) {
147134
const remote = hits.filter((task) => task.result.CacheHit?.source === "Remote").length;
148135
const savedMs = hits.reduce(

0 commit comments

Comments
 (0)