Skip to content

Commit 808bee7

Browse files
t3dotggclaude
andauthored
chore(typecheck): typecheck with tsc-rs (#16704)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 6bbb72c commit 808bee7

40 files changed

Lines changed: 158 additions & 72 deletions

File tree

‎apps/desktop/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"scripts": {
88
"ensure:electron": "node scripts/ensure-electron-runtime.mjs",
99
"start": "node scripts/start-electron.mjs",
10-
"typecheck": "tsc --noEmit",
10+
"typecheck": "tsc-rs --noEmit",
1111
"test": "vp test run --passWithNoTests",
1212
"smoke-test": "node scripts/smoke-test.mjs"
1313
},

‎apps/mobile/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"sync:pierre-icons": "node scripts/sync-pierre-file-icons.mjs",
4444
"generate": "node --disable-warning=MODULE_TYPELESS_PACKAGE_JSON scripts/generate-uniwind-themes.mts",
4545
"test": "vp test run --config ../../vite.config.ts --dir .",
46-
"typecheck": "tsc --noEmit"
46+
"typecheck": "tsc-rs --noEmit"
4747
},
4848
"dependencies": {
4949
"@clerk/expo": "catalog:",

‎apps/server/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"build:bundle": "vp pack",
2020
"build:exe": "node scripts/cli.ts build-exe",
2121
"start": "node dist/bin.mjs",
22-
"typecheck": "tsc --noEmit",
22+
"typecheck": "tsc-rs --noEmit",
2323
"test": "vp test run",
2424
"record:codex-replay": "bun scripts/record-codex-app-server-replay-fixture.ts",
2525
"record:claude-replay": "bun scripts/record-claude-agent-sdk-replay-fixture.ts",

‎apps/server/scripts/record-muse-msp-replay-fixture.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,13 +236,13 @@ const record = Effect.gen(function* () {
236236

237237
const entries: Array<ProviderReplayEntry> = [];
238238
const commandIds: Array<Array<string>> = [];
239-
const placeholder = {
239+
const placeholder: ProviderReplayTranscript = {
240240
provider: MUSE_PROVIDER_KIND,
241241
protocol: MUSE_MSP_REPLAY_PROTOCOL,
242242
version: museVersion,
243243
scenario: fixture.name,
244244
entries: [],
245-
} satisfies ProviderReplayTranscript;
245+
};
246246
const materializeInput = materializeFixtureInput({
247247
scenario: fixture.name,
248248
fixtureInput,

‎apps/server/scripts/record-pi-rpc-replay-fixture.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,13 @@ const record = Effect.gen(function* () {
244244
);
245245

246246
const entries: Array<ProviderReplayEntry> = [];
247-
const placeholder = {
247+
const placeholder: ProviderReplayTranscript = {
248248
provider: PI_PROVIDER,
249249
protocol: PI_RPC_REPLAY_PROTOCOL,
250250
version: piVersion,
251251
scenario: fixture.name,
252252
entries: [],
253-
} satisfies ProviderReplayTranscript;
253+
};
254254
const layerRecordingSpawner = Layer.effect(
255255
ChildProcessSpawner.ChildProcessSpawner,
256256
Effect.map(Effect.service(ChildProcessSpawner.ChildProcessSpawner), (live) =>

‎apps/server/src/pullRequest/PullRequestService.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6202,7 +6202,7 @@ it.effect("releases an expired diff nobody reads again", () =>
62026202
const service = yield* makeService({
62036203
projects: [project({ id: "p1", title: "web", workspaceRoot: "/a", repository: "acme/web" })],
62046204
providers: [
6205-
fakeProvider("github", {
6205+
fakeProvider(SourceControlProviderKind.make("github"), {
62066206
getDiff: () => Effect.sync(() => ({ patch: "@@", truncated: false, nextCursor: null })),
62076207
}),
62086208
],

‎apps/web/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"dev": "vp dev",
99
"build": "vp build",
1010
"preview": "vp preview",
11-
"typecheck": "tsc --noEmit",
11+
"typecheck": "tsc-rs --noEmit",
1212
"test": "vp test run --passWithNoTests --project unit"
1313
},
1414
"dependencies": {

‎docs/operations/development.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,13 @@ vp lint <files>
106106
vp run --filter <package> typecheck
107107
```
108108

109+
TypeScript workspaces typecheck with tsc-rs, which has Effect diagnostics built in.
110+
Keep `typescript`, `@effect/tsgo`, and the `effect-tsgo patch` prepare step: editors
111+
still use them for Effect quick fixes and refactors. Keep `@effect/tsgo` on the
112+
effect-tsgo version that tsc-rs ports (see the tsc-rs README), or the two disagree
113+
on rule names.
114+
Marketing keeps `astro check` for Astro files.
115+
109116
Use `vp run lint:mobile` for native mobile changes. CI owns the full suite; see
110117
[ci.yml](../../.github/workflows/ci.yml) for its current jobs.
111118
The [manual Windows lane](../../.github/workflows/windows-tests.yml) is available for focused

‎infra/relay/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"tunnels:census": "node scripts/tunnel-census.ts",
1010
"destroy": "alchemy destroy",
1111
"test": "vp test run --config ../../vite.config.ts --dir .",
12-
"typecheck": "tsc --noEmit"
12+
"typecheck": "tsc-rs --noEmit"
1313
},
1414
"dependencies": {
1515
"@clerk/backend": "catalog:",

‎oxlint-plugin-t3code/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"private": true,
44
"type": "module",
55
"scripts": {
6-
"typecheck": "tsc --noEmit",
6+
"typecheck": "tsc-rs --noEmit",
77
"test": "vp test run --config ../vite.config.ts --dir ."
88
},
99
"dependencies": {

0 commit comments

Comments
 (0)