@@ -5,6 +5,7 @@ import { afterEach, describe, expect, it, vi } from "vite-plus/test";
55import {
66 createOfficeDocumentClient ,
77 OFFICE_PREVIEW_MAX_BYTES ,
8+ OFFICE_PREVIEW_TRANSFER_TIMEOUT_MS ,
89 OFFICE_PREVIEW_TIMEOUT_MS ,
910 readOfficeDocumentBytes ,
1011} from "./officeDocumentClient" ;
@@ -30,11 +31,46 @@ afterEach(() => {
3031} ) ;
3132
3233const source = { name : "book.xlsx" , format : "xlsx" as const , file : new Blob ( [ "bytes" ] ) } ;
34+ const remoteSource = {
35+ name : "book.xlsx" ,
36+ format : "xlsx" as const ,
37+ src : "https://environment.test/signed" ,
38+ } ;
3339const workerPosted = ( ) =>
3440 new Promise < TestWorker > ( ( resolve ) => {
3541 TestWorker . onPosted = resolve ;
3642 } ) ;
3743
44+ function controlledRemoteBody ( ) {
45+ let controller : ReadableStreamDefaultController < Uint8Array > | undefined ;
46+ let reading : ( ( ) => void ) | undefined ;
47+ const readStarted = new Promise < void > ( ( resolve ) => {
48+ reading = resolve ;
49+ } ) ;
50+ const cancel = vi . fn ( ) ;
51+ const stream = new ReadableStream < Uint8Array > ( {
52+ start ( value ) {
53+ controller = value ;
54+ } ,
55+ pull ( ) {
56+ reading ?.( ) ;
57+ } ,
58+ cancel,
59+ } ) ;
60+ vi . stubGlobal (
61+ "fetch" ,
62+ vi . fn ( async ( ) => new Response ( stream ) ) ,
63+ ) ;
64+ return {
65+ readStarted,
66+ cancel,
67+ complete ( ) {
68+ controller ?. enqueue ( new Uint8Array ( [ 1 , 2 , 3 ] ) ) ;
69+ controller ?. close ( ) ;
70+ } ,
71+ } ;
72+ }
73+
3874describe ( "bounded Office document loading" , ( ) => {
3975 it ( "enforces the limit on actual chunked HTTP bytes without Content-Length" , async ( ) => {
4076 const server = NodeHttp . createServer ( ( _request , response ) => {
@@ -76,6 +112,7 @@ describe("bounded Office document loading", () => {
76112 } ) ;
77113
78114 it ( "cancels a stalled reader when the document closes" , async ( ) => {
115+ vi . useFakeTimers ( ) ;
79116 let cancelled : ( ( ) => void ) | undefined ;
80117 const cancellation = new Promise < void > ( ( resolve ) => {
81118 cancelled = resolve ;
@@ -108,9 +145,157 @@ describe("bounded Office document loading", () => {
108145 await cancellation ;
109146 expect ( cancel ) . toHaveBeenCalledOnce ( ) ;
110147 expect ( vi . mocked ( fetch ) . mock . calls [ 0 ] ?. [ 1 ] ?. signal ?. aborted ) . toBe ( true ) ;
148+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
149+ } ) ;
150+
151+ it ( "allows a transfer beyond fifteen seconds before starting the parser's full watchdog" , async ( ) => {
152+ vi . useFakeTimers ( ) ;
153+ vi . stubGlobal ( "Worker" , TestWorker ) ;
154+ const response = controlledRemoteBody ( ) ;
155+ const client = createOfficeDocumentClient ( remoteSource ) ;
156+ const posted = workerPosted ( ) ;
157+ const unsubscribe = client . subscribe ( vi . fn ( ) ) ;
158+ await response . readStarted ;
159+ await vi . advanceTimersByTimeAsync ( OFFICE_PREVIEW_TIMEOUT_MS + 1000 ) ;
160+ expect ( client . getSnapshot ( ) ) . toEqual ( { status : "loading" } ) ;
161+ expect ( TestWorker . instances ) . toHaveLength ( 0 ) ;
162+ expect ( vi . mocked ( fetch ) . mock . calls [ 0 ] ?. [ 1 ] ?. signal ?. aborted ) . toBe ( false ) ;
163+ response . complete ( ) ;
164+ const worker = await posted ;
165+ expect ( new Uint8Array ( worker . postMessage . mock . calls [ 0 ] ! [ 0 ] . buffer ) ) . toEqual (
166+ new Uint8Array ( [ 1 , 2 , 3 ] ) ,
167+ ) ;
168+ expect ( vi . getTimerCount ( ) ) . toBe ( 1 ) ;
169+ await vi . advanceTimersByTimeAsync ( OFFICE_PREVIEW_TIMEOUT_MS - 1 ) ;
170+ expect ( client . getSnapshot ( ) ) . toEqual ( { status : "loading" } ) ;
171+ expect ( worker . terminate ) . not . toHaveBeenCalled ( ) ;
172+ await vi . advanceTimersByTimeAsync ( 1 ) ;
173+ expect ( client . getSnapshot ( ) ) . toMatchObject ( {
174+ status : "error" ,
175+ message : expect . stringContaining ( "preview timed out" ) ,
176+ } ) ;
177+ expect ( worker . terminate ) . toHaveBeenCalledOnce ( ) ;
178+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
179+ unsubscribe ( ) ;
180+ } ) ;
181+
182+ it ( "aborts a stalled transfer at its finite deadline without starting a parser" , async ( ) => {
183+ vi . useFakeTimers ( ) ;
184+ vi . stubGlobal ( "Worker" , TestWorker ) ;
185+ const response = controlledRemoteBody ( ) ;
186+ const client = createOfficeDocumentClient ( remoteSource ) ;
187+ const unsubscribe = client . subscribe ( vi . fn ( ) ) ;
188+ await response . readStarted ;
189+ await vi . advanceTimersByTimeAsync ( OFFICE_PREVIEW_TRANSFER_TIMEOUT_MS - 1 ) ;
190+ expect ( client . getSnapshot ( ) ) . toEqual ( { status : "loading" } ) ;
191+ await vi . advanceTimersByTimeAsync ( 1 ) ;
192+ expect ( client . getSnapshot ( ) ) . toMatchObject ( {
193+ status : "error" ,
194+ message : expect . stringContaining ( "download timed out" ) ,
195+ } ) ;
196+ expect ( response . cancel ) . toHaveBeenCalledOnce ( ) ;
197+ expect ( vi . mocked ( fetch ) . mock . calls [ 0 ] ?. [ 1 ] ?. signal ?. aborted ) . toBe ( true ) ;
198+ expect ( TestWorker . instances ) . toHaveLength ( 0 ) ;
199+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
200+ unsubscribe ( ) ;
201+ } ) ;
202+
203+ it . each ( [ "success" , "worker error" ] ) (
204+ "releases the parser deadline on %s" ,
205+ async ( result : string ) => {
206+ vi . useFakeTimers ( ) ;
207+ vi . stubGlobal ( "Worker" , TestWorker ) ;
208+ const client = createOfficeDocumentClient ( source ) ;
209+ const listener = vi . fn ( ) ;
210+ const posted = workerPosted ( ) ;
211+ const unsubscribe = client . subscribe ( listener ) ;
212+ const worker = await posted ;
213+ expect ( vi . getTimerCount ( ) ) . toBe ( 1 ) ;
214+ if ( result === "success" ) {
215+ const document = { kind : "spreadsheet" , sheets : [ ] , warnings : [ ] } ;
216+ worker . dispatchEvent (
217+ new MessageEvent ( "message" , {
218+ data : { id : worker . postMessage . mock . calls [ 0 ] ! [ 0 ] . id , ok : true , document } ,
219+ } ) ,
220+ ) ;
221+ expect ( client . getSnapshot ( ) ) . toEqual ( { status : "success" , document } ) ;
222+ } else {
223+ worker . dispatchEvent ( new Event ( "error" ) ) ;
224+ expect ( client . getSnapshot ( ) ) . toMatchObject ( {
225+ status : "error" ,
226+ message : expect . stringContaining ( "Unable to read" ) ,
227+ } ) ;
228+ }
229+ expect ( worker . terminate ) . toHaveBeenCalledOnce ( ) ;
230+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
231+ const calls = listener . mock . calls . length ;
232+ await vi . advanceTimersByTimeAsync ( OFFICE_PREVIEW_TRANSFER_TIMEOUT_MS ) ;
233+ expect ( listener ) . toHaveBeenCalledTimes ( calls ) ;
234+ unsubscribe ( ) ;
235+ } ,
236+ ) ;
237+
238+ it ( "releases the transfer deadline after an HTTP failure" , async ( ) => {
239+ vi . useFakeTimers ( ) ;
240+ const cancel = vi . fn ( ) ;
241+ vi . stubGlobal (
242+ "fetch" ,
243+ vi . fn ( async ( ) => new Response ( new ReadableStream ( { cancel } ) , { status : 403 } ) ) ,
244+ ) ;
245+ let complete : ( ( ) => void ) | undefined ;
246+ const completed = new Promise < void > ( ( resolve ) => {
247+ complete = resolve ;
248+ } ) ;
249+ const client = createOfficeDocumentClient ( remoteSource ) ;
250+ const unsubscribe = client . subscribe ( ( ) => {
251+ if ( client . getSnapshot ( ) . status === "error" ) complete ?.( ) ;
252+ } ) ;
253+ await completed ;
254+ expect ( client . getSnapshot ( ) ) . toMatchObject ( {
255+ status : "error" ,
256+ message : expect . stringContaining ( "HTTP 403" ) ,
257+ } ) ;
258+ expect ( cancel ) . toHaveBeenCalledOnce ( ) ;
259+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
260+ unsubscribe ( ) ;
261+ } ) ;
262+
263+ it ( "ignores an earlier transfer completed after unsubscribe and a new subscription" , async ( ) => {
264+ vi . useFakeTimers ( ) ;
265+ vi . stubGlobal ( "Worker" , TestWorker ) ;
266+ let resolveEarlier : ( ( response : Response ) => void ) | undefined ;
267+ const earlier = new Promise < Response > ( ( resolve ) => {
268+ resolveEarlier = resolve ;
269+ } ) ;
270+ vi . stubGlobal (
271+ "fetch" ,
272+ vi
273+ . fn ( )
274+ . mockReturnValueOnce ( earlier )
275+ . mockResolvedValueOnce ( new Response ( new Uint8Array ( [ 3 , 4 ] ) ) ) ,
276+ ) ;
277+ const client = createOfficeDocumentClient ( remoteSource ) ;
278+ const stopEarlier = client . subscribe ( vi . fn ( ) ) ;
279+ stopEarlier ( ) ;
280+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
281+ const posted = workerPosted ( ) ;
282+ const stopCurrent = client . subscribe ( vi . fn ( ) ) ;
283+ const worker = await posted ;
284+ resolveEarlier ?.( new Response ( new Uint8Array ( [ 1 , 2 ] ) ) ) ;
285+ await vi . advanceTimersByTimeAsync ( 0 ) ;
286+ expect ( TestWorker . instances ) . toHaveLength ( 1 ) ;
287+ expect ( new Uint8Array ( worker . postMessage . mock . calls [ 0 ] ! [ 0 ] . buffer ) ) . toEqual (
288+ new Uint8Array ( [ 3 , 4 ] ) ,
289+ ) ;
290+ expect ( client . getSnapshot ( ) ) . toEqual ( { status : "loading" } ) ;
291+ expect ( vi . getTimerCount ( ) ) . toBe ( 1 ) ;
292+ stopCurrent ( ) ;
293+ expect ( worker . terminate ) . toHaveBeenCalledOnce ( ) ;
294+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
111295 } ) ;
112296
113297 it ( "transfers bounded bytes and ignores results after termination" , async ( ) => {
298+ vi . useFakeTimers ( ) ;
114299 vi . stubGlobal ( "Worker" , TestWorker ) ;
115300 const client = createOfficeDocumentClient ( source ) ;
116301 const listener = vi . fn ( ) ;
@@ -127,6 +312,7 @@ describe("bounded Office document loading", () => {
127312 ) ;
128313 expect ( worker . terminate ) . toHaveBeenCalledOnce ( ) ;
129314 expect ( listener ) . toHaveBeenCalledTimes ( calls ) ;
315+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
130316 } ) ;
131317
132318 it ( "terminates a stuck parser at the watchdog deadline" , async ( ) => {
@@ -142,6 +328,7 @@ describe("bounded Office document loading", () => {
142328 message : expect . stringContaining ( "timed out" ) ,
143329 } ) ;
144330 expect ( TestWorker . instances [ 0 ] ! . terminate ) . toHaveBeenCalledOnce ( ) ;
331+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
145332 unsubscribe ( ) ;
146333 } ) ;
147334} ) ;
0 commit comments