Skip to content

Commit 7d62dd0

Browse files
committed
ci: run merged typecheck and release smoke in the background
Running them after build and lint serialized work that used to run in parallel, so PRs that skip the server tests could finish later.
1 parent 98f74fd commit 7d62dd0

1 file changed

Lines changed: 37 additions & 8 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,24 @@ jobs:
8989
uses: ./.github/actions/ci-changes
9090

9191
- name: Setup Vite+
92-
id: setup
9392
uses: voidzero-dev/setup-vp@v1
9493
with:
9594
node-version-file: package.json
9695
cache: true
9796
run-install: true
9897

98+
# Runs in the background next to the lint steps, so merging it into this
99+
# job adds no time; the last step reports its result.
100+
- name: Start release smoke
101+
id: smoke
102+
if: steps.changes.outputs.release_smoke != 'false'
103+
run: |
104+
(
105+
set +e
106+
node scripts/release-smoke.ts
107+
echo "$?" > "$RUNNER_TEMP/smoke-status"
108+
) > "$RUNNER_TEMP/smoke.log" 2>&1 < /dev/null &
109+
99110
- name: Ensure Electron runtime is installed
100111
run: vp run --filter @t3tools/desktop ensure:electron
101112

@@ -106,10 +117,14 @@ jobs:
106117
- name: Check
107118
run: vp check
108119

109-
# Runs even when an earlier lint step failed, as its own job did.
120+
# Reports even when an earlier lint step failed, as its own job did.
110121
- name: Exercise release-only workflow steps
111-
if: ${{ !cancelled() && steps.setup.outcome == 'success' && steps.changes.outputs.release_smoke != 'false' }}
112-
run: node scripts/release-smoke.ts
122+
if: ${{ !cancelled() && steps.smoke.outcome == 'success' }}
123+
timeout-minutes: 5
124+
run: |
125+
until test -s "$RUNNER_TEMP/smoke-status"; do sleep 1; done
126+
cat "$RUNNER_TEMP/smoke.log"
127+
exit "$(cat "$RUNNER_TEMP/smoke-status")"
113128
114129
build:
115130
name: Build and Typecheck
@@ -151,11 +166,17 @@ jobs:
151166
id: electron
152167
run: vp run --filter @t3tools/desktop ensure:electron
153168

154-
# Typecheck and the build report independently: one failing does not
155-
# skip the other.
156-
- name: Typecheck
169+
# Runs in the background while the build runs, and reports in the last
170+
# step: neither result hides the other.
171+
- name: Start typecheck
172+
id: typecheck
157173
if: ${{ !cancelled() && steps.electron.outcome == 'success' && needs.changes.outputs.typecheck != 'false' }}
158-
run: vpr typecheck
174+
run: |
175+
(
176+
set +e
177+
vpr typecheck
178+
echo "$?" > "$RUNNER_TEMP/typecheck-status"
179+
) > "$RUNNER_TEMP/typecheck.log" 2>&1 < /dev/null &
159180
160181
- name: Finish installing browser secret helper build libraries
161182
id: apt
@@ -175,6 +196,14 @@ jobs:
175196
if: ${{ !cancelled() && steps.build.outcome == 'success' }}
176197
run: node apps/desktop/scripts/verify-preload-bundle.mjs
177198

199+
- name: Typecheck
200+
if: ${{ !cancelled() && steps.typecheck.outcome == 'success' }}
201+
timeout-minutes: 5
202+
run: |
203+
until test -s "$RUNNER_TEMP/typecheck-status"; do sleep 1; done
204+
cat "$RUNNER_TEMP/typecheck.log"
205+
exit "$(cat "$RUNNER_TEMP/typecheck-status")"
206+
178207
# Everything except `t3` (apps/server) and the web app, which has its own job
179208
# below. `--parallel` drops the package dependency ordering that `vp run`
180209
# applies by default: these `test` tasks declare no `dependsOn` and resolve

0 commit comments

Comments
 (0)