Skip to content

Commit 7d11d8d

Browse files
committed
chore(review): drop CodeRabbit's Approvability check for now
Approvability fails when a maintainer should read a pull request, not when something is wrong with it. As an error check, it made CodeRabbit request changes with "Pre-merge checks failed" on outside pull requests, even after the contributor had resolved every finding. Without it, CodeRabbit's verdict comes only from its own comments: it requests changes while they're unresolved and approves once they are.
1 parent d720210 commit 7d11d8d

1 file changed

Lines changed: 1 addition & 22 deletions

File tree

‎.coderabbit.config.ts‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,7 @@
11
import { defineConfig, type CodeRabbitContext } from "@coderabbitai/config";
22

3-
const approvability = `Fail when a maintainer should read this pull request before CodeRabbit approves it, and name the rule and file. Fail if it:
4-
5-
- Changes a product default: a setting's default value, or what users get without opting in. Making a feature do what it already promises is a bug fix, not a default change.
6-
- Adds or broadens a directive that disables or suppresses a lint, type-checker, LSP, or other static-analysis diagnostic, including file-level, line-level, and configuration-level overrides.
7-
- Adds a subsystem or user workflow, or is a large refactor across apps or packages.
8-
- Changes packages/contracts or persisted data in a way that existing clients or stored data might not accept.
9-
- Changes authentication, pairing, credentials, secrets, or remote connection trust.
10-
- Adds or changes an external side effect, such as acting on GitHub, publishing a release, or calling a webhook.
11-
- Adds, upgrades, or patches a dependency.
12-
- Changes CI or release configuration, agent or contributor instructions, or any review tool's configuration, including .github/, AGENTS.md, CONTRIBUTING.md, .agents/, and .coderabbit.config.ts.
13-
14-
Otherwise pass. A focused bug fix, copy or layout fix, revert, or docs-only or test-only change passes unless a rule above applies. If you cannot decide, fail rather than report inconclusive. When failing, say that the pull request needs a maintainer's review.
15-
`;
16-
173
// Org members and collaborators merge their own pull requests. On anyone else's, CodeRabbit
18-
// requests changes until its comments are resolved and its checks pass, then approves.
4+
// requests changes until its comments are resolved, then approves.
195
const UNGATED_AUTHORS = new Set(["OWNER", "MEMBER", "COLLABORATOR"]);
206
const isGated = ({ pr }: CodeRabbitContext) => !UNGATED_AUTHORS.has(pr?.authorAssociation ?? "");
217

@@ -31,13 +17,6 @@ export default defineConfig((ctx) => ({
3117
pre_merge_checks: {
3218
docstrings: { mode: "off" },
3319
override_requested_reviewers_only: isGated(ctx),
34-
custom_checks: [
35-
{
36-
name: "Approvability",
37-
mode: isGated(ctx) ? "error" : "off",
38-
instructions: approvability,
39-
},
40-
],
4120
},
4221
path_filters: [
4322
// Vendored read-only reference checkouts of upstream Effect and Alchemy

0 commit comments

Comments
 (0)