Skip to content

Commit 7cbdabd

Browse files
committed
fix(server): unlink layers from newer sibling stack snapshots
1 parent afbee2d commit 7cbdabd

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎apps/server/src/orchestration-v2/Orchestrator.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3669,7 +3669,7 @@ const makeOrchestrator = Effect.fn("orchestrationV2.Orchestrator.layer")(functio
36693669
);
36703670
if (!stack) return thread;
36713671
targets = new Set(stack.layers);
3672-
for (const layer of existing.stack?.layers ?? []) {
3672+
for (const layer of stack.layers.flatMap((link) => link.stack?.layers ?? [])) {
36733673
const member = links.find((link) =>
36743674
threadPullRequestKeysEqual(link, { ...key, number: layer.number }),
36753675
);

‎apps/server/src/orchestration-v2/runtimeLayer.test.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2851,7 +2851,12 @@ it.layer(layerTest)("OrchestrationV2LayerLive lifecycle", (it) => {
28512851
commandId: CommandId.make(`sync-${id}`),
28522852
threadId,
28532853
...reference,
2854-
stack: reference.number === 1 || reference.number === 2 ? stack : null,
2854+
stack:
2855+
reference.number === 1 && stack
2856+
? { ...stack, layers: stack.layers.filter((layer) => layer.number < 3) }
2857+
: reference.number === 2
2858+
? stack
2859+
: null,
28552860
snapshot: {
28562861
state: "open",
28572862
title: "PR",

0 commit comments

Comments
 (0)