@@ -10,7 +10,12 @@ import { describe, expect, it } from "vite-plus/test";
1010import { createModelSelection } from "@t3tools/shared/model" ;
1111import { deriveEffectiveComposerModelState } from "./composerDraftStore" ;
1212import { getComposerProviderState } from "./components/chat/composerProviderState" ;
13- import { deriveProviderInstanceEntries , NO_PROVIDER_MODEL_SELECTION } from "./providerInstances" ;
13+ import { resolveComposerProviderSelection } from "./components/ChatView.logic" ;
14+ import {
15+ deriveProviderInstanceEntries ,
16+ NO_PROVIDER_MODEL_SELECTION ,
17+ providerInstanceEntriesFor ,
18+ } from "./providerInstances" ;
1419import {
1520 getAppModelOptionsForInstance ,
1621 resolveAppModelSelectionForInstance ,
@@ -780,3 +785,159 @@ describe("default model settings and new-thread composer parity", () => {
780785 } ,
781786 ) ;
782787} ) ;
788+
789+ describe ( "composer fallback to another instance of the same driver" , ( ) => {
790+ const claude = ProviderDriverKind . make ( "claudeAgent" ) ;
791+ const codex = ProviderDriverKind . make ( "codex" ) ;
792+ const disabled = ProviderInstanceId . make ( "claudeAgent" ) ;
793+ const fallback = ProviderInstanceId . make ( "claude_team" ) ;
794+ const effortModels : ServerProvider [ "models" ] = [
795+ {
796+ slug : "claude-opus-5-5" ,
797+ name : "Claude Opus 5.5" ,
798+ isCustom : false ,
799+ capabilities : {
800+ optionDescriptors : [
801+ {
802+ id : "effort" ,
803+ label : "Effort" ,
804+ type : "select" ,
805+ options : [ "medium" , "high" , "xhigh" ] . map ( ( id ) => ( {
806+ id,
807+ label : id ,
808+ isDefault : id === "medium" ,
809+ } ) ) ,
810+ } ,
811+ ] ,
812+ } ,
813+ } ,
814+ ] ;
815+ const providers : ReadonlyArray < ServerProvider > = [
816+ {
817+ ...provider ( { provider : claude , instanceId : disabled } ) ,
818+ enabled : false ,
819+ models : effortModels ,
820+ } ,
821+ { ...provider ( { provider : claude , instanceId : fallback } ) , models : effortModels } ,
822+ ] ;
823+ const picked = createModelSelection ( disabled , "claude-opus-5-5" , [
824+ { id : "effort" , value : "xhigh" } ,
825+ ] ) ;
826+
827+ // The same steps useComposerProviderModel takes, without the draft store.
828+ function composerFor ( input : {
829+ readonly providers : ReadonlyArray < ServerProvider > ;
830+ readonly draft ?: Parameters < typeof deriveEffectiveComposerModelState > [ 0 ] [ "draft" ] ;
831+ readonly threadModelSelection : ReturnType < typeof createModelSelection > ;
832+ } ) {
833+ const settings = {
834+ ...DEFAULT_UNIFIED_SETTINGS ,
835+ providerInstances : Object . fromEntries (
836+ input . providers . map ( ( provider ) => [
837+ provider . instanceId ,
838+ {
839+ driver : provider . driver ,
840+ enabled : provider . enabled ,
841+ config : { } ,
842+ } ,
843+ ] ) ,
844+ ) ,
845+ } ;
846+ const selection = resolveComposerProviderSelection ( {
847+ entries : providerInstanceEntriesFor ( input . providers , settings , null ) ,
848+ candidateInstanceIds : [ input . threadModelSelection . instanceId ] ,
849+ lockedProvider : null ,
850+ lockedInstanceId : undefined ,
851+ } ) ;
852+ const selectedInstanceId = selection . selectedProviderEntry ! . instanceId ;
853+ const selectedProvider = selection . selectedProviderEntry ! . driverKind ;
854+ const state = deriveEffectiveComposerModelState ( {
855+ draft : input . draft ?? null ,
856+ providers : input . providers ,
857+ selectedProvider,
858+ selectedInstanceId,
859+ requestedInstanceId : selection . requestedInstanceId ,
860+ threadModelSelection : input . threadModelSelection ,
861+ projectModelSelection : null ,
862+ settings,
863+ } ) ;
864+ const traits = getComposerProviderState ( {
865+ provider : selectedProvider ,
866+ model : state . selectedModel ,
867+ models : selection . selectedProviderEntry ! . models ,
868+ modelOptions : state . modelOptions ?. [ selectedInstanceId ] ,
869+ planModeEnabled : false ,
870+ } ) ;
871+ return { selectedInstanceId, state, traits } ;
872+ }
873+
874+ it ( "keeps the requested instance's effort on the fallback instance" , ( ) => {
875+ const { selectedInstanceId, state, traits } = composerFor ( {
876+ providers,
877+ threadModelSelection : picked ,
878+ } ) ;
879+
880+ expect ( selectedInstanceId ) . toBe ( fallback ) ;
881+ expect ( state . selectedModel ) . toBe ( "claude-opus-5-5" ) ;
882+ expect ( traits . promptEffort ) . toBe ( "xhigh" ) ;
883+ expect (
884+ createModelSelection ( fallback , state . selectedModel , traits . modelOptionsForDispatch ) ,
885+ ) . toEqual (
886+ createModelSelection ( fallback , "claude-opus-5-5" , [ { id : "effort" , value : "xhigh" } ] ) ,
887+ ) ;
888+ } ) ;
889+
890+ it ( "keeps options the fallback instance already has" , ( ) => {
891+ const { traits } = composerFor ( {
892+ providers,
893+ threadModelSelection : picked ,
894+ draft : {
895+ activeProvider : disabled ,
896+ modelSelectionByProvider : {
897+ [ disabled ] : picked ,
898+ [ fallback ] : createModelSelection ( fallback , "claude-opus-5-5" , [
899+ { id : "effort" , value : "high" } ,
900+ ] ) ,
901+ } ,
902+ } ,
903+ } ) ;
904+
905+ expect ( traits . promptEffort ) . toBe ( "high" ) ;
906+ } ) ;
907+
908+ it ( "does not carry options picked with another model" , ( ) => {
909+ // An optionless draft pick takes its options from the thread, which holds another model.
910+ const { state, traits } = composerFor ( {
911+ providers,
912+ threadModelSelection : createModelSelection ( disabled , "claude-sonnet-4-6" , [
913+ { id : "effort" , value : "high" } ,
914+ ] ) ,
915+ draft : {
916+ activeProvider : disabled ,
917+ modelSelectionByProvider : { [ disabled ] : createModelSelection ( disabled , "claude-opus-5-5" ) } ,
918+ } ,
919+ } ) ;
920+
921+ expect ( state . selectedModel ) . toBe ( "claude-opus-5-5" ) ;
922+ expect ( traits . promptEffort ) . toBe ( "medium" ) ;
923+ expect ( traits . modelOptionsForDispatch ) . toBeUndefined ( ) ;
924+ } ) ;
925+
926+ it ( "does not carry options to another driver" , ( ) => {
927+ const codexOnly : ReadonlyArray < ServerProvider > = [
928+ {
929+ ...provider ( { provider : claude , instanceId : disabled } ) ,
930+ enabled : false ,
931+ models : effortModels ,
932+ } ,
933+ provider ( { provider : codex , instanceId : "codex" , models : [ "gpt-6-astra" ] } ) ,
934+ ] ;
935+ const { selectedInstanceId, state } = composerFor ( {
936+ providers : codexOnly ,
937+ threadModelSelection : picked ,
938+ } ) ;
939+
940+ expect ( selectedInstanceId ) . toBe ( ProviderInstanceId . make ( "codex" ) ) ;
941+ expect ( state . modelOptions ?. [ selectedInstanceId ] ) . toBeUndefined ( ) ;
942+ } ) ;
943+ } ) ;
0 commit comments