Skip to content

Commit 7c723d8

Browse files
committed
fix(preview): normalize direct browser targets
Preserve address-bar scheme defaults for schemeless localhost and public hosts while keeping direct targets separate from environment-port remapping.
1 parent 2e1ad05 commit 7c723d8

2 files changed

Lines changed: 25 additions & 1 deletion

File tree

‎apps/web/src/browser/browserTargetResolver.test.ts‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,30 @@ describe("browser target resolver", () => {
3636
).toThrow(/authenticated preview gateway/);
3737
});
3838

39+
it("normalizes schemeless direct URLs without remapping loopback hosts", async () => {
40+
const { resolveBrowserNavigationTarget } = await import("./browserTargetResolver");
41+
const environmentId = EnvironmentId.make("environment-1");
42+
43+
expect(
44+
resolveBrowserNavigationTarget(environmentId, {
45+
kind: "url",
46+
url: "localhost:5173/app",
47+
}),
48+
).toEqual({
49+
requestedUrl: "localhost:5173/app",
50+
resolvedUrl: "http://localhost:5173/app",
51+
resolutionKind: "direct",
52+
environmentId,
53+
});
54+
expect(
55+
resolveBrowserNavigationTarget(environmentId, {
56+
kind: "url",
57+
url: "example.com/app",
58+
}).resolvedUrl,
59+
).toBe("https://example.com/app");
60+
expect(readPreparedConnection).not.toHaveBeenCalled();
61+
});
62+
3963
it("normalizes schemeless localhost server-picker values", async () => {
4064
readPreparedConnection.mockReturnValue({ httpBaseUrl: "http://localhost:3773" });
4165
const { resolveDiscoveredServerUrl } = await import("./browserTargetResolver");

‎apps/web/src/browser/browserTargetResolver.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function resolveBrowserNavigationTarget(
3636
if (target.kind === "url") {
3737
return {
3838
requestedUrl: target.url,
39-
resolvedUrl: target.url,
39+
resolvedUrl: normalizePreviewUrl(target.url),
4040
resolutionKind: "direct",
4141
environmentId,
4242
};

0 commit comments

Comments
 (0)