Skip to content

Commit 7c1eb37

Browse files
juliusmarmingecodex
andcommitted
Use positive browser opt-in for dev runner
Co-authored-by: codex <[email protected]>
1 parent 163030a commit 7c1eb37

3 files changed

Lines changed: 19 additions & 22 deletions

File tree

‎.agents/skills/test-t3-app/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ description: Launch and test the T3 Code web app in isolated development environ
1616

1717
Treat a base directory as disposable only when it was created or deliberately selected for the current test. Never delete or directly seed the shared `~/.t3` directory. Prefer starting with a new temporary base directory over clearing state of uncertain ownership.
1818

19-
The dev runner disables browser auto-open by default. Do not opt back into auto-open during automated testing: an automatically opened page can consume the one-time bootstrap token before the controlled browser uses it.
19+
The dev runner disables browser auto-open by default. Do not pass `--browser` during automated testing: an automatically opened page can consume the one-time bootstrap token before the controlled browser uses it.
2020

2121
## Authenticate the browser on the first navigation
2222

‎scripts/dev-runner.test.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function mockProcess(exit: number | PlatformError.PlatformError) {
5151
const devServerInput = {
5252
mode: "dev:server",
5353
t3Home: "/tmp/t3code-dev-runner",
54-
noBrowser: undefined,
54+
browser: undefined,
5555
autoBootstrapProjectFromCwd: undefined,
5656
logWebSocketEvents: undefined,
5757
host: undefined,
@@ -134,7 +134,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
134134
serverOffset: 0,
135135
webOffset: 0,
136136
t3Home: undefined,
137-
noBrowser: undefined,
137+
browser: undefined,
138138
autoBootstrapProjectFromCwd: undefined,
139139
logWebSocketEvents: undefined,
140140
host: undefined,
@@ -155,7 +155,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
155155
serverOffset: 0,
156156
webOffset: 0,
157157
t3Home: undefined,
158-
noBrowser: false,
158+
browser: true,
159159
autoBootstrapProjectFromCwd: undefined,
160160
logWebSocketEvents: undefined,
161161
host: undefined,
@@ -175,7 +175,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
175175
serverOffset: 0,
176176
webOffset: 0,
177177
t3Home: undefined,
178-
noBrowser: undefined,
178+
browser: undefined,
179179
autoBootstrapProjectFromCwd: undefined,
180180
logWebSocketEvents: undefined,
181181
host: undefined,
@@ -196,7 +196,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
196196
serverOffset: 0,
197197
webOffset: 0,
198198
t3Home: "/tmp/custom-t3",
199-
noBrowser: true,
199+
browser: false,
200200
autoBootstrapProjectFromCwd: false,
201201
logWebSocketEvents: true,
202202
host: "0.0.0.0",
@@ -226,7 +226,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
226226
serverOffset: 0,
227227
webOffset: 0,
228228
t3Home: undefined,
229-
noBrowser: undefined,
229+
browser: undefined,
230230
autoBootstrapProjectFromCwd: undefined,
231231
logWebSocketEvents: undefined,
232232
host: undefined,
@@ -249,7 +249,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
249249
serverOffset: 0,
250250
webOffset: 0,
251251
t3Home: undefined,
252-
noBrowser: undefined,
252+
browser: undefined,
253253
autoBootstrapProjectFromCwd: undefined,
254254
logWebSocketEvents: false,
255255
host: undefined,
@@ -270,7 +270,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
270270
serverOffset: 0,
271271
webOffset: 0,
272272
t3Home: "/tmp/my-t3",
273-
noBrowser: undefined,
273+
browser: undefined,
274274
autoBootstrapProjectFromCwd: undefined,
275275
logWebSocketEvents: undefined,
276276
host: undefined,
@@ -298,7 +298,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
298298
serverOffset: 0,
299299
webOffset: 0,
300300
t3Home: "/tmp/my-t3",
301-
noBrowser: true,
301+
browser: true,
302302
autoBootstrapProjectFromCwd: undefined,
303303
logWebSocketEvents: undefined,
304304
host: "127.0.0.1",
@@ -327,7 +327,7 @@ it.layer(NodeServices.layer)("dev-runner", (it) => {
327327
serverOffset: 0,
328328
webOffset: 0,
329329
t3Home: undefined,
330-
noBrowser: undefined,
330+
browser: undefined,
331331
autoBootstrapProjectFromCwd: undefined,
332332
logWebSocketEvents: undefined,
333333
host: undefined,

‎scripts/dev-runner.ts‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ interface CreateDevRunnerEnvInput {
221221
readonly serverOffset: number;
222222
readonly webOffset: number;
223223
readonly t3Home: string | undefined;
224-
readonly noBrowser: boolean | undefined;
224+
readonly browser: boolean | undefined;
225225
readonly autoBootstrapProjectFromCwd: boolean | undefined;
226226
readonly logWebSocketEvents: boolean | undefined;
227227
readonly host: string | undefined;
@@ -235,7 +235,7 @@ export function createDevRunnerEnv({
235235
serverOffset,
236236
webOffset,
237237
t3Home,
238-
noBrowser,
238+
browser,
239239
autoBootstrapProjectFromCwd,
240240
logWebSocketEvents,
241241
host,
@@ -281,8 +281,8 @@ export function createDevRunnerEnv({
281281
}
282282

283283
if (!isDesktopMode) {
284-
if (noBrowser !== undefined) {
285-
output.T3CODE_NO_BROWSER = noBrowser ? "1" : "0";
284+
if (browser === true) {
285+
output.T3CODE_NO_BROWSER = "0";
286286
} else if (!output.T3CODE_NO_BROWSER?.trim()) {
287287
output.T3CODE_NO_BROWSER = "1";
288288
}
@@ -477,7 +477,7 @@ export function resolveModePortOffsets<R = NetService.NetService>({
477477
interface DevRunnerCliInput {
478478
readonly mode: DevMode;
479479
readonly t3Home: string | undefined;
480-
readonly noBrowser: boolean | undefined;
480+
readonly browser: boolean | undefined;
481481
readonly autoBootstrapProjectFromCwd: boolean | undefined;
482482
readonly logWebSocketEvents: boolean | undefined;
483483
readonly host: string | undefined;
@@ -515,7 +515,7 @@ export function runDevRunnerWithInput(input: DevRunnerCliInput) {
515515
serverOffset,
516516
webOffset,
517517
t3Home: input.t3Home,
518-
noBrowser: input.noBrowser,
518+
browser: input.browser,
519519
autoBootstrapProjectFromCwd: input.autoBootstrapProjectFromCwd,
520520
logWebSocketEvents: input.logWebSocketEvents,
521521
host: input.host,
@@ -600,11 +600,8 @@ const devRunnerCli = Command.make("dev-runner", {
600600
),
601601
Flag.withFallbackConfig(optionalStringConfig("T3CODE_HOME")),
602602
),
603-
noBrowser: Flag.boolean("no-browser").pipe(
604-
Flag.withDescription(
605-
"Disable browser auto-open (default for web dev; set T3CODE_NO_BROWSER=0 to opt in).",
606-
),
607-
Flag.map((value) => (value ? true : undefined)),
603+
browser: Flag.boolean("browser").pipe(
604+
Flag.withDescription("Open a browser automatically (disabled by default for web dev)."),
608605
),
609606
autoBootstrapProjectFromCwd: Flag.boolean("auto-bootstrap-project-from-cwd").pipe(
610607
Flag.withDescription(

0 commit comments

Comments
 (0)