Skip to content

Commit 7ba6c39

Browse files
committed
fix(web): retry failed large file authorization
1 parent d359115 commit 7ba6c39

2 files changed

Lines changed: 23 additions & 4 deletions

File tree

‎apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,19 @@ describe("large text preview recovery", () => {
9595
await screen.rerender(preview("legacy-edit", 1));
9696
await vi.waitFor(() => expect(screen.container.textContent).toContain("original"));
9797
expect(workers).toHaveLength(4);
98+
assetUrlState.mockReturnValue({ _tag: "Failure" });
99+
await screen.rerender(preview("legacy-edit", 1));
100+
expect(screen.container.textContent).toContain("Unable to load file preview.");
101+
refresh.mockClear();
102+
refresh.mockImplementation(async () => {
103+
state(`${changed}#retried`);
104+
return changed;
105+
});
106+
await screen.getByRole("button", { name: "Try again" }).click();
107+
expect(refresh).toHaveBeenCalledOnce();
108+
await screen.rerender(preview("legacy-edit", 1));
109+
await vi.waitFor(() => expect(screen.container.textContent).toContain("changed"));
110+
expect(screen.container.querySelector('[role="alert"]')).toBeNull();
98111
} finally {
99112
URL.revokeObjectURL(original);
100113
URL.revokeObjectURL(changed);

‎apps/web/src/components/files/FilePreviewPanel.tsx‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,12 +1598,18 @@ export function WorkspaceLargeTextPreview(props: {
15981598
if (assetUrl._tag === "Success" && loaded?.revision !== contentRevision) {
15991599
setLoaded({ revision: contentRevision, url: assetUrl.url });
16001600
}
1601-
if (assetUrl._tag !== "Success" || loaded === null)
1601+
if (assetUrl._tag === "Failure")
16021602
return (
1603-
<div className="p-6 text-xs text-muted-foreground">
1604-
{assetUrl._tag === "Failure" ? "Unable to load file preview." : "Loading…"}
1605-
</div>
1603+
<FileSurfaceFailure
1604+
message="Unable to load file preview."
1605+
onRetry={() => {
1606+
setRevision((value) => value + 1);
1607+
void refreshAssetUrl().catch(showError);
1608+
}}
1609+
/>
16061610
);
1611+
if (assetUrl._tag !== "Success" || loaded === null)
1612+
return <div className="p-6 text-xs text-muted-foreground">Loading…</div>;
16071613
const src = `${loaded.url}${loaded.url.includes("?") ? "&" : "?"}revision=${encodeURIComponent(loaded.revision)}`;
16081614
return (
16091615
<>

0 commit comments

Comments
 (0)