Repository navigation
Commit 7b4b0b6
refactor(mobile): git action results buzz from where they are reported
GitActionProgressOverlay kept the previous progress phase in a ref and
diffed it in an effect to fire success/error haptics when a git action
finished. That reconstructs an event that already has one owner:
showGitActionResult, which every git action result passes through.
The haptic now fires there, picked by result type. The overlay loses its
ref and its effect.
Behavior: the haptic now fires even when no thread route overlay is
mounted, and its type always matches the result shown (the old diff
could miss a failure if a render showed idle or a still-visible earlier
result between the run ending and the error landing). Keyboard copy
feedback never went through "running" and still gets its haptic from
tryCopyTextWithHaptic.
Effects: GitActionProgressOverlay.tsx 1 -> 0.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 79f6cd3 commit 7b4b0b6
3 files changed
Lines changed: 44 additions & 15 deletions
File tree
- apps/mobile/src
- features/threads
- state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | | - | |
| 3 | + | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 28 | | |
43 | 29 | | |
44 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
34 | 40 | | |
35 | 41 | | |
36 | 42 | | |
| |||
0 commit comments