Skip to content

Commit 798865b

Browse files
MarcoDotIOclaude
andcommitted
fix(web): a single provider retry no longer reads "1 retries"
The work log said "Provider recovered (1 retries)" and "Provider error after 1 retries" when a provider reports no retry limit, as OpenCode and ACP providers do. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent c8a601c commit 798865b

2 files changed

Lines changed: 39 additions & 2 deletions

File tree

‎apps/web/src/session-logic.test.ts‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,41 @@ describe("V2 session presentation", () => {
179179
completedAt: now,
180180
}),
181181
).toMatchObject({ label: "Provider error after 10/10 retries" });
182+
183+
// OpenCode and ACP providers report no retry limit.
184+
const firstRetry = { attempt: 1, maxAttempts: null, retryDelayMs: null };
185+
expect(
186+
providerErrorPresentation({
187+
...retryItem,
188+
status: "completed",
189+
completedAt: now,
190+
retry: firstRetry,
191+
}),
192+
).toMatchObject({ label: "Provider recovered (1 retry)" });
193+
expect(
194+
providerErrorPresentation({
195+
...retryItem,
196+
status: "failed",
197+
completedAt: now,
198+
retry: firstRetry,
199+
}),
200+
).toMatchObject({ label: "Provider error after 1 retry" });
201+
expect(
202+
providerErrorPresentation({
203+
...retryItem,
204+
status: "completed",
205+
completedAt: now,
206+
retry: { ...firstRetry, attempt: 2 },
207+
}),
208+
).toMatchObject({ label: "Provider recovered (2 retries)" });
209+
expect(
210+
providerErrorPresentation({
211+
...retryItem,
212+
status: "completed",
213+
completedAt: now,
214+
retry: { ...firstRetry, attempt: 1, maxAttempts: 10 },
215+
}),
216+
).toMatchObject({ label: "Provider recovered (1/10 retries)" });
182217
});
183218

184219
it("assigns run rollback to the turn-start message instead of a later steer", () => {

‎apps/web/src/session-logic.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,13 +377,15 @@ export function providerErrorPresentation(
377377
item.retry.maxAttempts === null
378378
? `${item.retry.attempt}`
379379
: `${item.retry.attempt}/${item.retry.maxAttempts}`;
380+
// The noun agrees with the number nearest it: "1 retry", but "1/10 retries".
381+
const retries = (item.retry.maxAttempts ?? item.retry.attempt) === 1 ? "retry" : "retries";
380382
const label =
381383
item.status === "running"
382384
? `Retrying provider (${progress})`
383385
: item.status === "completed"
384-
? `Provider recovered (${progress} retries)`
386+
? `Provider recovered (${progress} ${retries})`
385387
: item.status === "failed"
386-
? `${item.failure.class === "usage_limit" ? "Usage limit reached" : "Provider error"} after ${progress} retries`
388+
? `${item.failure.class === "usage_limit" ? "Usage limit reached" : "Provider error"} after ${progress} ${retries}`
387389
: `Provider retry stopped (${progress})`;
388390
const retryDelay =
389391
item.status === "running" && item.retry.retryDelayMs !== null && item.retry.retryDelayMs > 0

0 commit comments

Comments
 (0)