Skip to content

Commit 78fa3e5

Browse files
fix(server): recheck live triggers during manual reservation
1 parent f4234c0 commit 78fa3e5

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎apps/server/src/scheduledTasks/ScheduledTaskService.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,6 +781,11 @@ export const layer = Layer.effect(
781781
DateTime.toEpochMillis(parsedNextRunAt.value) > DateTime.toEpochMillis(startedAt))
782782
)
783783
return { task: active, running: false };
784+
if (trigger === "manual" && active.schedule.type === "webhook") {
785+
return yield* taskError("Webhook tasks run when their URL receives a request.", {
786+
taskId: active.id,
787+
});
788+
}
784789
if (webhook !== undefined) {
785790
const reason =
786791
active.createdAt !== task.createdAt
@@ -793,6 +798,7 @@ export const layer = Layer.effect(
793798
if (reason !== null) return yield* new WebhookDeliverySkipped({ reason });
794799
}
795800
yield* markRunning(active.id, active.projectId, startedAtIso);
801+
reservedAt = startedAtIso;
796802
return { task: active, running: true };
797803
}),
798804
)
@@ -813,7 +819,6 @@ export const layer = Layer.effect(
813819
}
814820
if (!reservedTask.running) return reservedTask.task;
815821
const active = reservedTask.task;
816-
reservedAt = startedAtIso;
817822
yield* notifyChanged;
818823

819824
const fireKey =

0 commit comments

Comments
 (0)